X-Git-Url: https://git.heureux-cyclage.org/?a=blobdiff_plain;f=tests%2Fphpunit%2Fincludes%2Ffilerepo%2Ffile%2FFileTest.php;h=3f4e46b5b0ced95c2b335418139eb573f6fb3651;hb=6b3e5511fb848890f174690885e748b90389c0b8;hp=65206107866b4a1adc92318f4d272b9b1405c744;hpb=9de4779e206628d8c7c9ae76785bfe825b5267d5;p=lhc%2Fweb%2Fwiklou.git

diff --git a/tests/phpunit/includes/filerepo/file/FileTest.php b/tests/phpunit/includes/filerepo/file/FileTest.php
index 6520610786..3f4e46b5b0 100644
--- a/tests/phpunit/includes/filerepo/file/FileTest.php
+++ b/tests/phpunit/includes/filerepo/file/FileTest.php
@@ -6,6 +6,7 @@ class FileTest extends MediaWikiMediaTestCase {
 	 * @param string $filename
 	 * @param bool $expected
 	 * @dataProvider providerCanAnimate
+	 * @covers File::canAnimateThumbIfAppropriate
 	 */
 	function testCanAnimateThumbIfAppropriate( $filename, $expected ) {
 		$this->setMwGlobals( 'wgMaxAnimatedGifArea', 9000 );
@@ -37,7 +38,7 @@ class FileTest extends MediaWikiMediaTestCase {
 		$this->setMwGlobals( 'wgThumbnailBuckets', $data['buckets'] );
 		$this->setMwGlobals( 'wgThumbnailMinimumBucketDistance', $data['minimumBucketDistance'] );
 
-		$fileMock = $this->getMockBuilder( 'File' )
+		$fileMock = $this->getMockBuilder( File::class )
 			->setConstructorArgs( [ 'fileMock', false ] )
 			->setMethods( [ 'getWidth' ] )
 			->getMockForAbstractClass();
@@ -136,11 +137,11 @@ class FileTest extends MediaWikiMediaTestCase {
 	 * @covers File::getThumbnailSource
 	 */
 	public function testGetThumbnailSource( $data ) {
-		$backendMock = $this->getMockBuilder( 'FSFileBackend' )
+		$backendMock = $this->getMockBuilder( FSFileBackend::class )
 			->setConstructorArgs( [ [ 'name' => 'backendMock', 'wikiId' => wfWikiID() ] ] )
 			->getMock();
 
-		$repoMock = $this->getMockBuilder( 'FileRepo' )
+		$repoMock = $this->getMockBuilder( FileRepo::class )
 			->setConstructorArgs( [ [ 'name' => 'repoMock', 'backend' => $backendMock ] ] )
 			->setMethods( [ 'fileExists', 'getLocalReference' ] )
 			->getMock();
@@ -155,12 +156,13 @@ class FileTest extends MediaWikiMediaTestCase {
 			->method( 'getLocalReference' )
 			->will( $this->returnValue( $fsFile ) );
 
-		$handlerMock = $this->getMock( 'BitmapHandler', [ 'supportsBucketing' ] );
+		$handlerMock = $this->getMockBuilder( BitmapHandler::class )
+			->setMethods( [ 'supportsBucketing' ] )->getMock();
 		$handlerMock->expects( $this->any() )
 			->method( 'supportsBucketing' )
 			->will( $this->returnValue( $data['supportsBucketing'] ) );
 
-		$fileMock = $this->getMockBuilder( 'File' )
+		$fileMock = $this->getMockBuilder( File::class )
 			->setConstructorArgs( [ 'fileMock', $repoMock ] )
 			->setMethods( [ 'getThumbnailBucket', 'getLocalRefPath', 'getHandler' ] )
 			->getMockForAbstractClass();
@@ -246,22 +248,23 @@ class FileTest extends MediaWikiMediaTestCase {
 	public function testGenerateBucketsIfNeeded( $data ) {
 		$this->setMwGlobals( 'wgThumbnailBuckets', $data['buckets'] );
 
-		$backendMock = $this->getMockBuilder( 'FSFileBackend' )
+		$backendMock = $this->getMockBuilder( FSFileBackend::class )
 			->setConstructorArgs( [ [ 'name' => 'backendMock', 'wikiId' => wfWikiID() ] ] )
 			->getMock();
 
-		$repoMock = $this->getMockBuilder( 'FileRepo' )
+		$repoMock = $this->getMockBuilder( FileRepo::class )
 			->setConstructorArgs( [ [ 'name' => 'repoMock', 'backend' => $backendMock ] ] )
 			->setMethods( [ 'fileExists', 'getLocalReference' ] )
 			->getMock();
 
-		$fileMock = $this->getMockBuilder( 'File' )
+		$fileMock = $this->getMockBuilder( File::class )
 			->setConstructorArgs( [ 'fileMock', $repoMock ] )
 			->setMethods( [ 'getWidth', 'getBucketThumbPath', 'makeTransformTmpFile',
 				'generateAndSaveThumb', 'getHandler' ] )
 			->getMockForAbstractClass();
 
-		$handlerMock = $this->getMock( 'JpegHandler', [ 'supportsBucketing' ] );
+		$handlerMock = $this->getMockBuilder( JpegHandler::class )
+			->setMethods( [ 'supportsBucketing' ] )->getMock();
 		$handlerMock->expects( $this->any() )
 			->method( 'supportsBucketing' )
 			->will( $this->returnValue( true ) );
@@ -270,7 +273,7 @@ class FileTest extends MediaWikiMediaTestCase {
 			->method( 'getHandler' )
 			->will( $this->returnValue( $handlerMock ) );
 
-		$reflectionMethod = new ReflectionMethod( 'File', 'generateBucketsIfNeeded' );
+		$reflectionMethod = new ReflectionMethod( File::class, 'generateBucketsIfNeeded' );
 		$reflectionMethod->setAccessible( true );
 
 		$fileMock->expects( $this->any() )