X-Git-Url: https://git.heureux-cyclage.org/?a=blobdiff_plain;f=tests%2Fphpunit%2Fincludes%2FLinkerTest.php;h=4c508e3851fd5e9daa95834468e3794cbe0e103b;hb=84fa176c9c14cca4dee674c284deb6e6796d928a;hp=f4844f89bb4ec12f96bc89ffa7933f3e094ddef0;hpb=313dde5d06c42be1eb7da9127ec92bb5d360ddab;p=lhc%2Fweb%2Fwiklou.git

diff --git a/tests/phpunit/includes/LinkerTest.php b/tests/phpunit/includes/LinkerTest.php
index f4844f89bb..4c508e3851 100644
--- a/tests/phpunit/includes/LinkerTest.php
+++ b/tests/phpunit/includes/LinkerTest.php
@@ -1,11 +1,9 @@
 <?php
 
-use MediaWiki\MediaWikiServices;
 
 /**
  * @group Database
  */
-
 class LinkerTest extends MediaWikiLangTestCase {
 
 	/**
@@ -133,7 +131,7 @@ class LinkerTest extends MediaWikiLangTestCase {
 	public function provideCasesForFormatComment() {
 		$wikiId = 'enwiki'; // $wgConf has a fake entry for this
 
-		// @codingStandardsIgnoreStart Generic.Files.LineLength
+		// phpcs:disable Generic.Files.LineLength
 		return [
 			// Linker::formatComment
 			[
@@ -257,7 +255,7 @@ class LinkerTest extends MediaWikiLangTestCase {
 				false, false, $wikiId
 			],
 		];
-		// @codingStandardsIgnoreEnd
+		// phpcs:enable
 	}
 
 	/**
@@ -289,7 +287,7 @@ class LinkerTest extends MediaWikiLangTestCase {
 	}
 
 	public static function provideCasesForFormatLinksInComment() {
-		// @codingStandardsIgnoreStart Generic.Files.LineLength
+		// phpcs:disable Generic.Files.LineLength
 		return [
 			[
 				'foo bar <a href="/wiki/Special:BlankPage" title="Special:BlankPage">Special:BlankPage</a>',
@@ -312,43 +310,43 @@ class LinkerTest extends MediaWikiLangTestCase {
 				'enwiki',
 			],
 		];
-		// @codingStandardsIgnoreEnd
+		// phpcs:enable
 	}
 
 	public static function provideLinkBeginHook() {
-		// @codingStandardsIgnoreStart Generic.Files.LineLength
+		// phpcs:disable Generic.Files.LineLength
 		return [
 			// Modify $html
 			[
-				function( $dummy, $title, &$html, &$attribs, &$query, &$options, &$ret ) {
+				function ( $dummy, $title, &$html, &$attribs, &$query, &$options, &$ret ) {
 					$html = 'foobar';
 				},
 				'<a href="/wiki/Special:BlankPage" title="Special:BlankPage">foobar</a>'
 			],
 			// Modify $attribs
 			[
-				function( $dummy, $title, &$html, &$attribs, &$query, &$options, &$ret ) {
+				function ( $dummy, $title, &$html, &$attribs, &$query, &$options, &$ret ) {
 					$attribs['bar'] = 'baz';
 				},
 				'<a href="/wiki/Special:BlankPage" title="Special:BlankPage" bar="baz">Special:BlankPage</a>'
 			],
 			// Modify $query
 			[
-				function( $dummy, $title, &$html, &$attribs, &$query, &$options, &$ret ) {
+				function ( $dummy, $title, &$html, &$attribs, &$query, &$options, &$ret ) {
 					$query['bar'] = 'baz';
 				},
 				'<a href="/w/index.php?title=Special:BlankPage&amp;bar=baz" title="Special:BlankPage">Special:BlankPage</a>'
 			],
 			// Force HTTP $options
 			[
-				function( $dummy, $title, &$html, &$attribs, &$query, &$options, &$ret ) {
+				function ( $dummy, $title, &$html, &$attribs, &$query, &$options, &$ret ) {
 					$options = [ 'http' ];
 				},
 				'<a href="http://example.org/wiki/Special:BlankPage" title="Special:BlankPage">Special:BlankPage</a>'
 			],
 			// Force 'forcearticlepath' in $options
 			[
-				function( $dummy, $title, &$html, &$attribs, &$query, &$options, &$ret ) {
+				function ( $dummy, $title, &$html, &$attribs, &$query, &$options, &$ret ) {
 					$options = [ 'forcearticlepath' ];
 					$query['foo'] = 'bar';
 				},
@@ -356,14 +354,14 @@ class LinkerTest extends MediaWikiLangTestCase {
 			],
 			// Abort early
 			[
-				function( $dummy, $title, &$html, &$attribs, &$query, &$options, &$ret ) {
+				function ( $dummy, $title, &$html, &$attribs, &$query, &$options, &$ret ) {
 					$ret = 'foobar';
 					return false;
 				},
 				'foobar'
 			],
 		];
-		// @codingStandardsIgnoreEnd
+		// phpcs:enable
 	}
 
 	/**
@@ -371,6 +369,7 @@ class LinkerTest extends MediaWikiLangTestCase {
 	 * @dataProvider provideLinkBeginHook
 	 */
 	public function testLinkBeginHook( $callback, $expected ) {
+		$this->hideDeprecated( 'LinkBegin hook (used in hook-LinkBegin-closure)' );
 		$this->setMwGlobals( [
 			'wgArticlePath' => '/wiki/$1',
 			'wgServer' => '//example.org',
@@ -418,6 +417,7 @@ class LinkerTest extends MediaWikiLangTestCase {
 	 * @dataProvider provideLinkEndHook
 	 */
 	public function testLinkEndHook( $callback, $expected ) {
+		$this->hideDeprecated( 'LinkEnd hook (used in hook-LinkEnd-closure)' );
 		$this->setMwGlobals( [
 			'wgArticlePath' => '/wiki/$1',
 		] );
@@ -428,54 +428,4 @@ class LinkerTest extends MediaWikiLangTestCase {
 		$out = Linker::link( $title );
 		$this->assertEquals( $expected, $out );
 	}
-
-	/**
-	 * @covers Linker::getLinkColour
-	 */
-	public function testGetLinkColour() {
-		$this->hideDeprecated( 'Linker::getLinkColour' );
-		$linkCache = MediaWikiServices::getInstance()->getLinkCache();
-		$foobarTitle = Title::makeTitle( NS_MAIN, 'FooBar' );
-		$redirectTitle = Title::makeTitle( NS_MAIN, 'Redirect' );
-		$userTitle = Title::makeTitle( NS_USER, 'Someuser' );
-		$linkCache->addGoodLinkObj(
-			1, // id
-			$foobarTitle,
-			10, // len
-			0 // redir
-		);
-		$linkCache->addGoodLinkObj(
-			2, // id
-			$redirectTitle,
-			10, // len
-			1 // redir
-		);
-
-		$linkCache->addGoodLinkObj(
-			3, // id
-			$userTitle,
-			10, // len
-			0 // redir
-		);
-
-		$this->assertEquals(
-			'',
-			Linker::getLinkColour( $foobarTitle, 0 )
-		);
-
-		$this->assertEquals(
-			'stub',
-			Linker::getLinkColour( $foobarTitle, 20 )
-		);
-
-		$this->assertEquals(
-			'mw-redirect',
-			Linker::getLinkColour( $redirectTitle, 0 )
-		);
-
-		$this->assertEquals(
-			'',
-			Linker::getLinkColour( $userTitle, 20 )
-		);
-	}
 }