X-Git-Url: https://git.heureux-cyclage.org/?a=blobdiff_plain;f=tests%2Fphpunit%2Fincludes%2FHtmlTest.php;h=999e0bb56c0d0a5de825d0745baf402f1d0a8d38;hb=af80076034fb734d652eb043c523c1d8df974e51;hp=156f702c07249f4443b0127414b2e8dd019643bd;hpb=0756849eb8450909d14dcb619307bdf07f0c7fcd;p=lhc%2Fweb%2Fwiklou.git

diff --git a/tests/phpunit/includes/HtmlTest.php b/tests/phpunit/includes/HtmlTest.php
index 156f702c07..4401410ef3 100644
--- a/tests/phpunit/includes/HtmlTest.php
+++ b/tests/phpunit/includes/HtmlTest.php
@@ -76,6 +76,15 @@ class HtmlTest extends MediaWikiTestCase {
 		parent::tearDown();
 	}
 
+	/**
+	 * @expectedException PHPUnit_Framework_Error_Notice
+	 * @expectedExceptionMessage given element name with space
+	 * @covers Html::openElement
+	 */
+	public function testOpenElement() {
+		Html::openElement( 'span id="x"' );
+	}
+
 	/**
 	 * @covers Html::element
 	 * @covers Html::rawElement
@@ -152,12 +161,12 @@ class HtmlTest extends MediaWikiTestCase {
 	 * @covers Html::expandAttributes
 	 */
 	public function testExpandAttributesForBooleans() {
-		$this->assertEquals(
+		$this->assertSame(
 			'',
 			Html::expandAttributes( [ 'selected' => false ] ),
 			'Boolean attributes do not generates output when value is false'
 		);
-		$this->assertEquals(
+		$this->assertSame(
 			'',
 			Html::expandAttributes( [ 'selected' => null ] ),
 			'Boolean attributes do not generates output when value is null'
@@ -203,7 +212,6 @@ class HtmlTest extends MediaWikiTestCase {
 	}
 
 	/**
-	 * Test for Html::expandAttributes()
 	 * Please note it output a string prefixed with a space!
 	 * @covers Html::expandAttributes
 	 */
@@ -308,7 +316,7 @@ class HtmlTest extends MediaWikiTestCase {
 
 	/**
 	 * How do we handle duplicate keys in HTML attributes expansion?
-	 * We could pass a "class" the values: 'GREEN' and array( 'GREEN' => false )
+	 * We could pass a "class" the values: 'GREEN' and [ 'GREEN' => false ]
 	 * The latter will take precedence.
 	 *
 	 * Feature added by r96188
@@ -421,6 +429,33 @@ class HtmlTest extends MediaWikiTestCase {
 			),
 			'Basic namespace selector with a custom label but no id attribtue for the <select>'
 		);
+
+		$this->assertEquals(
+			'<select id="namespace" name="namespace">' . "\n" .
+				'<option value="0">(Principal)</option>' . "\n" .
+				'<option value="1">Discusión</option>' . "\n" .
+				'<option value="2">Usuario</option>' . "\n" .
+				'<option value="3">Usuario discusión</option>' . "\n" .
+				'<option value="4">Wiki</option>' . "\n" .
+				'<option value="5">Wiki discusión</option>' . "\n" .
+				'<option value="6">Archivo</option>' . "\n" .
+				'<option value="7">Archivo discusión</option>' . "\n" .
+				'<option value="8">MediaWiki</option>' . "\n" .
+				'<option value="9">MediaWiki discusión</option>' . "\n" .
+				'<option value="10">Plantilla</option>' . "\n" .
+				'<option value="11">Plantilla discusión</option>' . "\n" .
+				'<option value="12">Ayuda</option>' . "\n" .
+				'<option value="13">Ayuda discusión</option>' . "\n" .
+				'<option value="14">Categoría</option>' . "\n" .
+				'<option value="15">Categoría discusión</option>' . "\n" .
+				'<option value="100">Personalizado</option>' . "\n" .
+				'<option value="101">Personalizado discusión</option>' . "\n" .
+				'</select>',
+			Html::namespaceSelector(
+				[ 'in-user-lang' => true ]
+			),
+			'Basic namespace selector in user language'
+		);
 	}
 
 	/**
@@ -446,6 +481,26 @@ class HtmlTest extends MediaWikiTestCase {
 			),
 			'Namespace selector namespace filtering.'
 		);
+		$this->assertEquals(
+			'<select id="namespace" name="namespace">' . "\n" .
+				'<option value="" selected="">todos</option>' . "\n" .
+				'<option value="2">User</option>' . "\n" .
+				'<option value="4">MyWiki</option>' . "\n" .
+				'<option value="5">MyWiki Talk</option>' . "\n" .
+				'<option value="6">File</option>' . "\n" .
+				'<option value="7">File talk</option>' . "\n" .
+				'<option value="8">MediaWiki</option>' . "\n" .
+				'<option value="9">MediaWiki talk</option>' . "\n" .
+				'<option value="10">Template</option>' . "\n" .
+				'<option value="11">Template talk</option>' . "\n" .
+				'<option value="14">Category</option>' . "\n" .
+				'<option value="15">Category talk</option>' . "\n" .
+				'</select>',
+			Html::namespaceSelector(
+				[ 'exclude' => [ 0, 1, 3, 100, 101 ], 'all' => '' ]
+			),
+			'Namespace selector namespace filtering with empty custom "all" option.'
+		);
 	}
 
 	/**