X-Git-Url: https://git.heureux-cyclage.org/?a=blobdiff_plain;f=tests%2Fphpunit%2Fincludes%2FDiffHistoryBlobTest.php;h=b75862ea0c9a53a9769fd03d9aa47b1f6dde2970;hb=26e157d31135fd4c74a7e0544722a69face4d6df;hp=e28a92cf43c1e46e9e753c0d7ccf0091a1767ea9;hpb=b51729f77074984d4db7ff12e6d864c358292ec3;p=lhc%2Fweb%2Fwiklou.git diff --git a/tests/phpunit/includes/DiffHistoryBlobTest.php b/tests/phpunit/includes/DiffHistoryBlobTest.php index e28a92cf43..b75862ea0c 100644 --- a/tests/phpunit/includes/DiffHistoryBlobTest.php +++ b/tests/phpunit/includes/DiffHistoryBlobTest.php @@ -10,13 +10,11 @@ class DiffHistoryBlobTest extends MediaWikiTestCase { if ( !function_exists( 'xdiff_string_rabdiff' ) ) { $this->markTestSkipped( 'The version of xdiff extension is lower than 1.5.0' ); - return; } } /** - * Test for DiffHistoryBlob::xdiffAdler32() * @dataProvider provideXdiffAdler32 * @covers DiffHistoryBlob::xdiffAdler32 */ @@ -28,13 +26,19 @@ class DiffHistoryBlobTest extends MediaWikiTestCase { "Hash of " . addcslashes( $input, "\0..\37!@\@\177..\377" ) ); } - public static function provideXdiffAdler32() { - return array( - array( '', 'Empty string' ), - array( "\0", 'Null' ), - array( "\0\0\0", "Several nulls" ), - array( "Hello", "An ASCII string" ), - array( str_repeat( "x", 6000 ), "A string larger than xdiff's NMAX (5552)" ) - ); + public function provideXdiffAdler32() { + // Hack non-empty early return since PHPUnit expands this provider before running + // the setUp() which marks the test as skipped. + if ( !function_exists( 'xdiff_string_rabdiff' ) ) { + return [ [ '', 'Empty string' ] ]; + } + + return [ + [ '', 'Empty string' ], + [ "\0", 'Null' ], + [ "\0\0\0", "Several nulls" ], + [ "Hello", "An ASCII string" ], + [ str_repeat( "x", 6000 ), "A string larger than xdiff's NMAX (5552)" ] + ]; } }