X-Git-Url: https://git.heureux-cyclage.org/?a=blobdiff_plain;f=resources%2Fsrc%2Fmediawiki.ui%2Fcomponents%2Fcheckbox.less;h=ac5becb8003697a7769d4bf6b97b386d246dc810;hb=aabdc342bf45961091778e15ddbd6186b001a47b;hp=506dc118edd35dcdfbdad2747e2084bf8e669742;hpb=0138ee519c972005d12c517bb3e29130fcdfa3ce;p=lhc%2Fweb%2Fwiklou.git

diff --git a/resources/src/mediawiki.ui/components/checkbox.less b/resources/src/mediawiki.ui/components/checkbox.less
index 506dc118ed..b0fbf515e6 100644
--- a/resources/src/mediawiki.ui/components/checkbox.less
+++ b/resources/src/mediawiki.ui/components/checkbox.less
@@ -5,8 +5,8 @@
 //
 // Styling checkboxes in a way that works cross browser is a tricky problem to solve.
 // In MediaWiki UI put a checkbox and label inside a mw-ui-checkbox div.
-// This renders in all browsers except IE6-8 which do not support the :checked selector;
-// these are kept backwards-compatible using the :not(#noop) selector.
+// This renders in all browsers except IE 6-8 which do not support the :checked selector;
+// these are kept backwards-compatible using the `:not( #noop )` selector.
 // You should give the checkbox and label matching "id" and "for" attributes, respectively.
 //
 // Markup:
@@ -33,13 +33,14 @@
 	vertical-align: middle;
 }
 
-@checkboxSize: 2em;
-
 // We use the not selector to cancel out styling on IE 8 and below
-.mw-ui-checkbox:not(#noop) {
+// We also disable this styling on JavaScript disabled devices. This fixes the issue with
+// Opera Mini where checking/unchecking doesn't apply styling but potentially leaves other
+// more capable browsers with unstyled checkboxes.
+.client-js .mw-ui-checkbox:not( #noop ) {
 	// Position relatively so we can make use of absolute pseudo elements
 	position: relative;
-	line-height: @checkboxSize;
+	display: table;
 
 	* {
 		// reset font sizes (see bug 72727)
@@ -51,35 +52,47 @@
 		// we hide the input element as instead we will style the label that follows
 		// we use opacity so that VoiceOver software can still identify it
 		opacity: 0;
+		// Render "on top of" the label, so that it's still clickable (T98905)
+		z-index: 1;
+		position: relative;
 		// ensure the invisible checkbox takes up the required width
 		width: @checkboxSize;
 		height: @checkboxSize;
 		// This is needed for Firefox mobile (See bug 71750 to workaround default Firefox stylesheet)
 		max-width: none;
-		margin: 0;
-		margin-right: 0.4em;
+		margin: 0 0.4em 0 0;
+		display: table-cell;
+
+		& + label {
+			display: table-cell;
+		}
 
 		// the pseudo before element of the label after the checkbox now looks like a checkbox
 		& + label::before {
 			content: '';
-			cursor: pointer;
-			.box-sizing(border-box);
+			background-color: #fff;
+			.background-image-svg( 'images/checked.svg', 'images/checked.png' );
+			background-position: center center;
+			background-origin: border-box;
+			background-repeat: no-repeat;
+			.background-size( 0, 0 );
+			.box-sizing( border-box );
 			position: absolute;
+			// align the checkbox to middle of the text
+			top: 50%;
 			left: 0;
-			border-radius: @borderRadius;
 			width: @checkboxSize;
 			height: @checkboxSize;
-			background-color: #fff;
+			margin-top: -1em;
 			border: 1px solid @colorGray7;
+			border-radius: @borderRadius;
+			line-height: @checkboxSize;
+			cursor: pointer;
 		}
 
 		// when the input is checked, style the label pseudo before element that followed as a checked checkbox
 		&:checked + label::before {
-			.background-image-svg('images/checked.svg', 'images/checked.png');
-			.background-size( @checkboxSize - 0.2em, @checkboxSize - 0.2em );
-			background-repeat: no-repeat;
-			background-position: center center;
-			background-origin: border-box;
+			.background-size( 100%, 100% );
 		}
 
 		&:active + label::before {
@@ -105,7 +118,7 @@
 
 		// disabled and checked checkboxes have a white circle
 		&:disabled:checked + label::before {
-			.background-image-svg('images/checked_disabled.svg', 'images/checked_disabled.png');
+			.background-image-svg( 'images/checked_disabled.svg', 'images/checked_disabled.png' );
 		}
 	}
 }