X-Git-Url: https://git.heureux-cyclage.org/?a=blobdiff_plain;f=resources%2Fsrc%2Fmediawiki.rcfilters%2Fui%2Fmw.rcfilters.ui.FilterMenuHeaderWidget.js;h=dceb132038d81332854d569fc8188c8fef216c46;hb=1029b36698d38ae4712749e5baaa9505f1426447;hp=1a0c5ff51cca1e994c0285a866dba48350382879;hpb=d6f84e825c5b2ea214b460c5a8b204927213e75c;p=lhc%2Fweb%2Fwiklou.git

diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterMenuHeaderWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterMenuHeaderWidget.js
index 1a0c5ff51c..dceb132038 100644
--- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterMenuHeaderWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterMenuHeaderWidget.js
@@ -41,7 +41,7 @@
 			framed: false,
 			title: mw.msg( 'rcfilters-view-tags-help-icon-tooltip' ),
 			classes: [ 'mw-rcfilters-ui-filterMenuHeaderWidget-helpIcon' ],
-			href: 'https://www.mediawiki.org/wiki/Special:MyLanguage/Help:New_filters_for_edit_review/Advanced_filters#tags',
+			href: mw.util.getUrl( 'Special:Tags' ),
 			target: '_blank'
 		} );
 		this.helpIcon.toggle( this.model.getCurrentView() === 'tags' );
@@ -59,7 +59,6 @@
 			classes: [ 'mw-rcfilters-ui-filterMenuHeaderWidget-invertNamespacesButton' ]
 		} );
 		this.invertNamespacesButton.toggle( this.model.getCurrentView() === 'namespaces' );
-		this.updateInvertButton( this.model.areNamespacesInverted() );
 
 		// Events
 		this.backButton.connect( this, { click: 'onBackButtonClick' } );
@@ -69,8 +68,8 @@
 			.connect( this, { click: 'onInvertNamespacesButtonClick' } );
 		this.model.connect( this, {
 			highlightChange: 'onModelHighlightChange',
-			invertChange: 'onModelInvertChange',
-			update: 'onModelUpdate'
+			update: 'onModelUpdate',
+			initialize: 'onModelInitialize'
 		} );
 
 		// Initialize
@@ -112,6 +111,19 @@
 
 	/* Methods */
 
+	/**
+	 * Respond to model initialization event
+	 *
+	 * Note: need to wait for initialization before getting the invertModel
+	 * and registering its update event. Creating all the models before the UI
+	 * would help with that.
+	 */
+	mw.rcfilters.ui.FilterMenuHeaderWidget.prototype.onModelInitialize = function () {
+		this.invertModel = this.model.getInvertModel();
+		this.updateInvertButton();
+		this.invertModel.connect( this, { update: 'updateInvertButton' } );
+	};
+
 	/**
 	 * Respond to model update event
 	 */
@@ -134,24 +146,13 @@
 		this.highlightButton.setActive( highlightEnabled );
 	};
 
-	/**
-	 * Respond to model invert change event
-	 *
-	 * @param {boolean} isInverted Namespaces selection is inverted
-	 */
-	mw.rcfilters.ui.FilterMenuHeaderWidget.prototype.onModelInvertChange = function ( isInverted ) {
-		this.updateInvertButton( isInverted );
-	};
-
 	/**
 	 * Update the state of the invert button
-	 *
-	 * @param {boolean} isInverted Namespaces selection is inverted
 	 */
-	mw.rcfilters.ui.FilterMenuHeaderWidget.prototype.updateInvertButton = function ( isInverted ) {
-		this.invertNamespacesButton.setActive( isInverted );
+	mw.rcfilters.ui.FilterMenuHeaderWidget.prototype.updateInvertButton = function () {
+		this.invertNamespacesButton.setActive( this.invertModel.isSelected() );
 		this.invertNamespacesButton.setLabel(
-			isInverted ?
+			this.invertModel.isSelected() ?
 				mw.msg( 'rcfilters-exclude-button-on' ) :
 				mw.msg( 'rcfilters-exclude-button-off' )
 		);