X-Git-Url: https://git.heureux-cyclage.org/?a=blobdiff_plain;f=maintenance%2FrunJobs.php;h=80a227810e66722fdff898d1195f5ef6672317b4;hb=86a180097bbe38cc314798b48a5a8b8e70566273;hp=fdc141bb3b21b3cfbdb966337e2b03369c6cd051;hpb=de995ae048eae818873ed2b2a7e6c3ed6dc8259a;p=lhc%2Fweb%2Fwiklou.git

diff --git a/maintenance/runJobs.php b/maintenance/runJobs.php
index fdc141bb3b..80a227810e 100644
--- a/maintenance/runJobs.php
+++ b/maintenance/runJobs.php
@@ -1,8 +1,8 @@
 <?php
 /**
- * This script starts pending jobs.
+ * Run pending jobs.
  *
- * Usage:
+ * Options:
  *  --maxjobs <num> (default 10000)
  *  --type <job_cmd>
  *
@@ -21,11 +21,17 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  * http://www.gnu.org/copyleft/gpl.html
  *
+ * @file
  * @ingroup Maintenance
  */
 
-require_once( dirname( __FILE__ ) . '/Maintenance.php' );
+require_once( __DIR__ . '/Maintenance.php' );
 
+/**
+ * Maintenance script that runs pending jobs.
+ *
+ * @ingroup Maintenance
+ */
 class RunJobs extends Maintenance {
 	public function __construct() {
 		parent::__construct();
@@ -46,6 +52,7 @@ class RunJobs extends Maintenance {
 
 	public function execute() {
 		global $wgTitle;
+
 		if ( $this->hasOption( 'procs' ) ) {
 			$procs = intval( $this->getOption( 'procs' ) );
 			if ( $procs < 1 || $procs > 1000 ) {
@@ -64,26 +71,17 @@ class RunJobs extends Maintenance {
 		$dbw = wfGetDB( DB_MASTER );
 		$n = 0;
 
-		if ( $type === false ) {
-			$conds = Job::defaultQueueConditions( );
-		} else {
-			$conds = array( 'job_cmd' => $type );
-		}
-
-		while ( $dbw->selectField( 'job', 'job_id', $conds, 'runJobs.php' ) ) {
-			$offset = 0;
-			for ( ; ; ) {
-				$job = !$type ? Job::pop( $offset ) : Job::pop_type( $type );
-
-				if ( !$job ) {
-					break;
-				}
-
-				wfWaitForSlaves();
+		$group = JobQueueGroup::singleton();
+		do {
+			$job = ( $type === false )
+				? $group->pop() // job from any queue
+				: $group->get( $type )->pop(); // job from a single queue
+			if ( $job ) { // found a job
+				// Perform the job (logging success/failure and runtime)...
 				$t = microtime( true );
-				$offset = $job->id;
 				$this->runJobsLog( $job->toString() . " STARTING" );
 				$status = $job->run();
+				$group->ack( $job ); // done
 				$t = microtime( true ) - $t;
 				$timeMs = intval( $t * 1000 );
 				if ( !$status ) {
@@ -91,15 +89,17 @@ class RunJobs extends Maintenance {
 				} else {
 					$this->runJobsLog( $job->toString() . " t=$timeMs good" );
 				}
-
-				if ( $maxJobs && ++$n > $maxJobs ) {
+				// Break out if we hit the job count or wall time limits...
+				if ( $maxJobs && ++$n >= $maxJobs ) {
 					break 2;
 				}
-				if ( $maxTime && time() - $startTime > $maxTime ) {
+				if ( $maxTime && ( time() - $startTime ) > $maxTime ) {
 					break 2;
 				}
+				// Don't let any slaves/backups fall behind...
+				$group->get( $type )->waitForBackups();
 			}
-		}
+		} while ( $job ); // stop when there are no jobs
 	}
 
 	/**