X-Git-Url: https://git.heureux-cyclage.org/?a=blobdiff_plain;f=maintenance%2FpopulateRevisionSha1.php;h=fb97e910f8e01c029cb016e611eccf9b10c1b862;hb=52f95595e05e489403f06e287fb9970bcd40c82d;hp=3aff77ed91e4c293d5d198cb76aae6aace40f5e2;hpb=4dc3ac1c375b3d2eb6172dfef8fdebe71b8c5f43;p=lhc%2Fweb%2Fwiklou.git diff --git a/maintenance/populateRevisionSha1.php b/maintenance/populateRevisionSha1.php index 3aff77ed91..fb97e910f8 100644 --- a/maintenance/populateRevisionSha1.php +++ b/maintenance/populateRevisionSha1.php @@ -118,7 +118,7 @@ class PopulateRevisionSha1 extends LoggedUpdateMaintenance { $count = 0; $db = $this->getDB( DB_MASTER ); $res = $db->select( 'archive', '*', - array( 'ar_rev_id IS NULL', 'ar_sha1' => '' ), __METHOD__ ); + [ 'ar_rev_id IS NULL', 'ar_sha1' => '' ], __METHOD__ ); $updateSize = 0; $this->beginTransaction( $db, __METHOD__ ); @@ -156,17 +156,17 @@ class PopulateRevisionSha1 extends LoggedUpdateMaintenance { } catch ( Exception $e ) { $this->output( "Data of revision with {$idCol}={$row->$idCol} unavailable!\n" ); - return false; // bug 22624? + return false; // T24624? } if ( !is_string( $text ) ) { - # This should not happen, but sometimes does (bug 20757) + # This should not happen, but sometimes does (T22757) $this->output( "Data of revision with {$idCol}={$row->$idCol} unavailable!\n" ); return false; } else { $db->update( $table, - array( "{$prefix}_sha1" => Revision::base36Sha1( $text ) ), - array( $idCol => $row->$idCol ), + [ "{$prefix}_sha1" => Revision::base36Sha1( $text ) ], + [ $idCol => $row->$idCol ], __METHOD__ ); @@ -185,11 +185,11 @@ class PopulateRevisionSha1 extends LoggedUpdateMaintenance { } catch ( Exception $e ) { $this->output( "Text of revision with timestamp {$row->ar_timestamp} unavailable!\n" ); - return false; // bug 22624? + return false; // T24624? } $text = $rev->getSerializedData(); if ( !is_string( $text ) ) { - # This should not happen, but sometimes does (bug 20757) + # This should not happen, but sometimes does (T22757) $this->output( "Data of revision with timestamp {$row->ar_timestamp} unavailable!\n" ); return false; @@ -197,13 +197,13 @@ class PopulateRevisionSha1 extends LoggedUpdateMaintenance { # Archive table as no PK, but (NS,title,time) should be near unique. # Any duplicates on those should also have duplicated text anyway. $db->update( 'archive', - array( 'ar_sha1' => Revision::base36Sha1( $text ) ), - array( + [ 'ar_sha1' => Revision::base36Sha1( $text ) ], + [ 'ar_namespace' => $row->ar_namespace, 'ar_title' => $row->ar_title, 'ar_timestamp' => $row->ar_timestamp, 'ar_len' => $row->ar_len // extra sanity - ), + ], __METHOD__ );