X-Git-Url: https://git.heureux-cyclage.org/?a=blobdiff_plain;f=maintenance%2Forphans.php;h=e36c5b67dd544ae398c38510cba762a4c4c653ea;hb=02aacff54cdb4440defaad9cb31368a92344d6f6;hp=3c5566f615f488700cd78f458ebaa871095c25fb;hpb=1e296da3d7da4bf095ae228d7f5890f7ef520873;p=lhc%2Fweb%2Fwiklou.git

diff --git a/maintenance/orphans.php b/maintenance/orphans.php
index 3c5566f615..e36c5b67dd 100644
--- a/maintenance/orphans.php
+++ b/maintenance/orphans.php
@@ -30,6 +30,8 @@
 
 require_once __DIR__ . '/Maintenance.php';
 
+use Wikimedia\Rdbms\IMaintainableDatabase;
+
 /**
  * Maintenance script that looks for 'orphan' revisions hooked to pages which
  * don't exist and 'childless' pages with no revisions.
@@ -39,10 +41,11 @@ require_once __DIR__ . '/Maintenance.php';
 class Orphans extends Maintenance {
 	public function __construct() {
 		parent::__construct();
-		$this->mDescription = "Look for 'orphan' revisions hooked to pages which don't exist\n" .
+		$this->addDescription( "Look for 'orphan' revisions hooked to pages which don't exist\n" .
 			"and 'childless' pages with no revisions\n" .
 			"Then, kill the poor widows and orphans\n" .
-			"Man this is depressing";
+			"Man this is depressing"
+		);
 		$this->addOption( 'fix', 'Actually fix broken entries' );
 	}
 
@@ -55,15 +58,15 @@ class Orphans extends Maintenance {
 
 	/**
 	 * Lock the appropriate tables for the script
-	 * @param DatabaseBase $db
-	 * @param string $extraTable The name of any extra tables to lock (eg: text)
+	 * @param IMaintainableDatabase $db
+	 * @param string[] $extraTable The name of any extra tables to lock (eg: text)
 	 */
-	private function lockTables( $db, $extraTable = array() ) {
-		$tbls = array( 'page', 'revision', 'redirect' );
+	private function lockTables( $db, $extraTable = [] ) {
+		$tbls = [ 'page', 'revision', 'redirect' ];
 		if ( $extraTable ) {
 			$tbls = array_merge( $tbls, $extraTable );
 		}
-		$db->lockTables( array(), $tbls, __METHOD__, false );
+		$db->lockTables( [], $tbls, __METHOD__, false );
 	}
 
 	/**
@@ -107,7 +110,7 @@ class Orphans extends Maintenance {
 					$wgContLang->truncate( $row->rev_user_text, 17 ),
 					$comment ) );
 				if ( $fix ) {
-					$dbw->delete( 'revision', array( 'rev_id' => $row->rev_id ) );
+					$dbw->delete( 'revision', [ 'rev_id' => $row->rev_id ] );
 				}
 			}
 			if ( !$fix ) {
@@ -155,7 +158,7 @@ class Orphans extends Maintenance {
 					$row->page_namespace,
 					$row->page_title );
 				if ( $fix ) {
-					$dbw->delete( 'page', array( 'page_id' => $row->page_id ) );
+					$dbw->delete( 'page', [ 'page_id' => $row->page_id ] );
 				}
 			}
 			if ( !$fix ) {
@@ -180,7 +183,7 @@ class Orphans extends Maintenance {
 		$revision = $dbw->tableName( 'revision' );
 
 		if ( $fix ) {
-			$this->lockTables( $dbw, array( 'user', 'text' ) );
+			$this->lockTables( $dbw, [ 'user', 'text' ] );
 		}
 
 		$this->output( "\nChecking for pages whose page_latest links are incorrect... "
@@ -214,9 +217,9 @@ class Orphans extends Maintenance {
 						$maxId = $dbw->selectField(
 							'revision',
 							'rev_id',
-							array(
+							[
 								'rev_page' => $row->page_id,
-								'rev_timestamp' => $row2->max_timestamp ) );
+								'rev_timestamp' => $row2->max_timestamp ] );
 						$this->output( "... updating to revision $maxId\n" );
 						$maxRev = Revision::newFromId( $maxId );
 						$title = Title::makeTitle( $row->page_namespace, $row->page_title );