X-Git-Url: https://git.heureux-cyclage.org/?a=blobdiff_plain;f=maintenance%2FdeleteDefaultMessages.php;h=a1c0f616b0e0a68a28f79c8e04264db0bda6b398;hb=5e843cca772f67faaacc8967a48d8bf964b5ef41;hp=7d8c80e497cd6c7a728848c38fbe82f8d835a867;hpb=75da5baa3f353a326edaf9ee4e0bbaed097f725a;p=lhc%2Fweb%2Fwiklou.git diff --git a/maintenance/deleteDefaultMessages.php b/maintenance/deleteDefaultMessages.php index 7d8c80e497..a1c0f616b0 100644 --- a/maintenance/deleteDefaultMessages.php +++ b/maintenance/deleteDefaultMessages.php @@ -34,7 +34,7 @@ class DeleteDefaultMessages extends Maintenance { public function __construct() { parent::__construct(); $this->mDescription = "Deletes all pages in the MediaWiki namespace" . - " which were last edited by \"MediaWiki default\""; + " which were last edited by \"MediaWiki default\""; } public function execute() { @@ -54,6 +54,7 @@ class DeleteDefaultMessages extends Maintenance { if ( $dbr->numRows( $res ) == 0 ) { # No more messages left $this->output( "done.\n" ); + return; } @@ -75,10 +76,9 @@ class DeleteDefaultMessages extends Maintenance { $dbw->ping(); $title = Title::makeTitle( $row->page_namespace, $row->page_title ); $page = WikiPage::factory( $title ); - $dbw->begin( __METHOD__ ); $error = ''; // Passed by ref - $page->doDeleteArticle( 'No longer required', false, 0, false, $error, $user ); - $dbw->commit( __METHOD__ ); + // FIXME: Deletion failures should be reported, not silently ignored. + $page->doDeleteArticle( 'No longer required', false, 0, true, $error, $user ); } $this->output( "done!\n", 'msg' );