X-Git-Url: https://git.heureux-cyclage.org/?a=blobdiff_plain;f=includes%2Fspecials%2FSpecialWantedfiles.php;h=74d5e5d3469ee96db7b37674ebdddc6aa7564385;hb=5fa4cdf860c79b32ab6ef034c6d9420c2727f695;hp=a718aa817aa6b7868bf25db0c38d46f7427c99e0;hpb=6a35b1f5003fbe1bc6565436e0b250d4b02e0a2c;p=lhc%2Fweb%2Fwiklou.git diff --git a/includes/specials/SpecialWantedfiles.php b/includes/specials/SpecialWantedfiles.php index a718aa817a..2ebbc2d86c 100644 --- a/includes/specials/SpecialWantedfiles.php +++ b/includes/specials/SpecialWantedfiles.php @@ -74,6 +74,7 @@ class WantedFilesPage extends WantedQueryPage { * In its own function to allow subclasses to override. * @see SpecialWantedFilesGUOverride in GlobalUsage extension. * @since 1.24 + * @return bool */ protected function likelyToHaveFalsePositives() { return RepoGroup::singleton()->hasForeignRepos(); @@ -83,7 +84,7 @@ class WantedFilesPage extends WantedQueryPage { * KLUGE: The results may contain false positives for files * that exist e.g. in a shared repo. Setting this at least * keeps them from showing up as redlinks in the output, even - * if it doesn't fix the real problem (bug 6220). + * if it doesn't fix the real problem (T8220). * * @note could also have existing links here from broken file * redirects. @@ -99,6 +100,7 @@ class WantedFilesPage extends WantedQueryPage { * Use wfFindFile so we still think file namespace pages without * files are missing, but valid file redirects and foreign files are ok. * + * @param Title $title * @return bool */ protected function existenceCheck( Title $title ) { @@ -106,43 +108,43 @@ class WantedFilesPage extends WantedQueryPage { } function getQueryInfo() { - return array( - 'tables' => array( + return [ + 'tables' => [ 'imagelinks', 'page', 'redirect', 'img1' => 'image', 'img2' => 'image', - ), - 'fields' => array( + ], + 'fields' => [ 'namespace' => NS_FILE, 'title' => 'il_to', 'value' => 'COUNT(*)' - ), - 'conds' => array( + ], + 'conds' => [ 'img1.img_name' => null, // We also need to exclude file redirects 'img2.img_name' => null, - ), - 'options' => array( 'GROUP BY' => 'il_to' ), - 'join_conds' => array( - 'img1' => array( 'LEFT JOIN', + ], + 'options' => [ 'GROUP BY' => 'il_to' ], + 'join_conds' => [ + 'img1' => [ 'LEFT JOIN', 'il_to = img1.img_name' - ), - 'page' => array( 'LEFT JOIN', array( + ], + 'page' => [ 'LEFT JOIN', [ 'il_to = page_title', 'page_namespace' => NS_FILE, - ) ), - 'redirect' => array( 'LEFT JOIN', array( + ] ], + 'redirect' => [ 'LEFT JOIN', [ 'page_id = rd_from', 'rd_namespace' => NS_FILE, 'rd_interwiki' => '' - ) ), - 'img2' => array( 'LEFT JOIN', + ] ], + 'img2' => [ 'LEFT JOIN', 'rd_title = img2.img_name' - ) - ) - ); + ] + ] + ]; } protected function getGroupName() {