X-Git-Url: https://git.heureux-cyclage.org/?a=blobdiff_plain;f=includes%2Fspecials%2FSpecialUncategorizedpages.php;h=30b33cc6973222eefc9d563d10e5b906d06b6a2a;hb=8a43c5afdf0736f5c60ec587da5c230cf53a8ab1;hp=bfcb58f63503c9a2eb4a5e74ba2a59965ad99239;hpb=c0f872ddf7ac1ebe791933a1423c629eee9ee521;p=lhc%2Fweb%2Fwiklou.git diff --git a/includes/specials/SpecialUncategorizedpages.php b/includes/specials/SpecialUncategorizedpages.php index bfcb58f635..30b33cc697 100644 --- a/includes/specials/SpecialUncategorizedpages.php +++ b/includes/specials/SpecialUncategorizedpages.php @@ -25,8 +25,8 @@ * A special page looking for page without any category. * * @ingroup SpecialPage + * @todo FIXME: Make $requestedNamespace selectable, unify all subclasses into one */ -// @todo FIXME: Make $requestedNamespace selectable, unify all subclasses into one class UncategorizedPagesPage extends PageQueryPage { protected $requestedNamespace = false; @@ -47,27 +47,36 @@ class UncategorizedPagesPage extends PageQueryPage { } function getQueryInfo() { - return array( - 'tables' => array( 'page', 'categorylinks' ), - 'fields' => array( 'namespace' => 'page_namespace', - 'title' => 'page_title', - 'value' => 'page_title' ), + return [ + 'tables' => [ 'page', 'categorylinks' ], + 'fields' => [ + 'namespace' => 'page_namespace', + 'title' => 'page_title', + 'value' => 'page_title' + ], // default for page_namespace is all content namespaces (if requestedNamespace is false) // otherwise, page_namespace is requestedNamespace - 'conds' => array( 'cl_from IS NULL', - 'page_namespace' => ( $this->requestedNamespace !== false ? $this->requestedNamespace : MWNamespace::getContentNamespaces() ), - 'page_is_redirect' => 0 ), - 'join_conds' => array( 'categorylinks' => array( - 'LEFT JOIN', 'cl_from = page_id' ) ) - ); + 'conds' => [ + 'cl_from IS NULL', + 'page_namespace' => $this->requestedNamespace !== false + ? $this->requestedNamespace + : MWNamespace::getContentNamespaces(), + 'page_is_redirect' => 0 + ], + 'join_conds' => [ + 'categorylinks' => [ 'LEFT JOIN', 'cl_from = page_id' ] + ] + ]; } function getOrderFields() { // For some crazy reason ordering by a constant // causes a filesort - if( $this->requestedNamespace === false && count( MWNamespace::getContentNamespaces() ) > 1 ) - return array( 'page_namespace', 'page_title' ); - return array( 'page_title' ); + if ( $this->requestedNamespace === false && count( MWNamespace::getContentNamespaces() ) > 1 ) { + return [ 'page_namespace', 'page_title' ]; + } + + return [ 'page_title' ]; } protected function getGroupName() {