X-Git-Url: https://git.heureux-cyclage.org/?a=blobdiff_plain;f=includes%2Fspecials%2FSpecialPageLanguage.php;h=55ae69262156720e5a560f97dfe88df26617f81f;hb=6f19bac69546b8a5cc06f91a81e364bf905dee7f;hp=38093be41754e2e5d55693ceacfb142ceb2b9fa6;hpb=480ab87dbc2974ad9465af2808f21bf83397142e;p=lhc%2Fweb%2Fwiklou.git

diff --git a/includes/specials/SpecialPageLanguage.php b/includes/specials/SpecialPageLanguage.php
index 38093be417..55ae692621 100644
--- a/includes/specials/SpecialPageLanguage.php
+++ b/includes/specials/SpecialPageLanguage.php
@@ -50,44 +50,44 @@ class SpecialPageLanguage extends FormSpecialPage {
 		// Get default from the subpage of Special page
 		$defaultName = $this->par;
 
-		$page = array();
-		$page['pagename'] = array(
+		$page = [];
+		$page['pagename'] = [
 			'type' => 'title',
 			'label-message' => 'pagelang-name',
 			'default' => $defaultName,
 			'autofocus' => $defaultName === null,
 			'exists' => true,
-		);
+		];
 
 		// Options for whether to use the default language or select language
-		$selectoptions = array(
+		$selectoptions = [
 			(string)$this->msg( 'pagelang-use-default' )->escaped() => 1,
 			(string)$this->msg( 'pagelang-select-lang' )->escaped() => 2,
-		);
-		$page['selectoptions'] = array(
+		];
+		$page['selectoptions'] = [
 			'id' => 'mw-pl-options',
 			'type' => 'radio',
 			'options' => $selectoptions,
 			'default' => 1
-		);
+		];
 
 		// Building a language selector
 		$userLang = $this->getLanguage()->getCode();
 		$languages = Language::fetchLanguageNames( $userLang, 'mwfile' );
 		ksort( $languages );
-		$options = array();
+		$options = [];
 		foreach ( $languages as $code => $name ) {
 			$options["$code - $name"] = $code;
 		}
 
-		$page['language'] = array(
+		$page['language'] = [
 			'id' => 'mw-pl-languageselector',
 			'cssclass' => 'mw-languageselector',
 			'type' => 'select',
 			'options' => $options,
 			'label-message' => 'pagelang-language',
 			'default' => $this->getConfig()->get( 'LanguageCode' ),
-		);
+		];
 
 		return $page;
 	}
@@ -104,92 +104,130 @@ class SpecialPageLanguage extends FormSpecialPage {
 	}
 
 	public function alterForm( HTMLForm $form ) {
-		Hooks::run( 'LanguageSelector', array( $this->getOutput(), 'mw-languageselector' ) );
+		Hooks::run( 'LanguageSelector', [ $this->getOutput(), 'mw-languageselector' ] );
 		$form->setSubmitTextMsg( 'pagelang-submit' );
 	}
 
 	/**
 	 *
 	 * @param array $data
-	 * @return bool
+	 * @return Status
 	 */
 	public function onSubmit( array $data ) {
-		$title = Title::newFromText( $data['pagename'] );
+		$pageName = $data['pagename'];
 
-		// Check if title is valid
-		if ( !$title ) {
-			return false;
+		// Check if user wants to use default language
+		if ( $data['selectoptions'] == 1 ) {
+			$newLanguage = 'default';
+		} else {
+			$newLanguage = $data['language'];
 		}
 
+		try {
+			$title = Title::newFromTextThrow( $pageName );
+		} catch ( MalformedTitleException $ex ) {
+			return Status::newFatal( $ex->getMessageObject() );
+		}
+
+		// Url to redirect to after the operation
+		$this->goToUrl = $title->getFullURL();
+
+		return self::changePageLanguage( $this->getContext(), $title, $newLanguage );
+	}
+
+	/**
+	 * @param IContextSource $context
+	 * @param Title $title
+	 * @param string $newLanguage Language code
+	 * @param array $tags Change tags to apply to the log entry
+	 * @return Status
+	 */
+	public static function changePageLanguage( IContextSource $context, Title $title,
+		$newLanguage, array $tags = [] ) {
 		// Get the default language for the wiki
-		// Returns the default since the page is not loaded from DB
-		$defLang = $title->getPageLanguage()->getCode();
+		$defLang = $context->getConfig()->get( 'LanguageCode' );
 
 		$pageId = $title->getArticleID();
 
 		// Check if article exists
 		if ( !$pageId ) {
-			return false;
+			return Status::newFatal(
+				'pagelang-nonexistent-page',
+				wfEscapeWikiText( $title->getPrefixedText() )
+			);
 		}
 
 		// Load the page language from DB
 		$dbw = wfGetDB( DB_MASTER );
-		$langOld = $dbw->selectField(
+		$oldLanguage = $dbw->selectField(
 			'page',
 			'page_lang',
-			array( 'page_id' => $pageId ),
+			[ 'page_id' => $pageId ],
 			__METHOD__
 		);
 
-		// Url to redirect to after the operation
-		$this->goToUrl = $title->getFullURL();
-
-		// Check if user wants to use default language
-		if ( $data['selectoptions'] == 1 ) {
-			$langNew = null;
-		} else {
-			$langNew = $data['language'];
+		// Check if user wants to use the default language
+		if ( $newLanguage === 'default' ) {
+			$newLanguage = null;
 		}
 
 		// No change in language
-		if ( $langNew === $langOld ) {
-			return false;
+		if ( $newLanguage === $oldLanguage ) {
+			// Check if old language does not exist
+			if ( !$oldLanguage ) {
+				return Status::newFatal(
+					'pagelang-unchanged-language-default',
+					wfEscapeWikiText( $title->getPrefixedText() )
+				);
+			}
+			return Status::newFatal(
+				'pagelang-unchanged-language',
+				wfEscapeWikiText( $title->getPrefixedText() ),
+				$oldLanguage
+			);
 		}
 
 		// Hardcoded [def] if the language is set to null
-		$logOld = $langOld ? $langOld : $defLang . '[def]';
-		$logNew = $langNew ? $langNew : $defLang . '[def]';
+		$logOld = $oldLanguage ? $oldLanguage : $defLang . '[def]';
+		$logNew = $newLanguage ? $newLanguage : $defLang . '[def]';
 
 		// Writing new page language to database
-		$dbw = wfGetDB( DB_MASTER );
 		$dbw->update(
 			'page',
-			array( 'page_lang' => $langNew ),
-			array(
+			[ 'page_lang' => $newLanguage ],
+			[
 				'page_id' => $pageId,
-				'page_lang' => $langOld
-			),
+				'page_lang' => $oldLanguage
+			],
 			__METHOD__
 		);
 
 		if ( !$dbw->affectedRows() ) {
-			return false;
+			return Status::newFatal( 'pagelang-db-failed' );
 		}
 
 		// Logging change of language
-		$logParams = array(
+		$logParams = [
 			'4::oldlanguage' => $logOld,
 			'5::newlanguage' => $logNew
-		);
+		];
 		$entry = new ManualLogEntry( 'pagelang', 'pagelang' );
-		$entry->setPerformer( $this->getUser() );
+		$entry->setPerformer( $context->getUser() );
 		$entry->setTarget( $title );
 		$entry->setParameters( $logParams );
+		$entry->setTags( $tags );
 
 		$logid = $entry->insert();
 		$entry->publish( $logid );
 
-		return true;
+		// Force re-render so that language-based content (parser functions etc.) gets updated
+		$title->invalidateCache();
+
+		return Status::newGood( (object)[
+			'oldLanguage' => $logOld,
+			'newLanguage' => $logNew,
+			'logId' => $logid,
+		] );
 	}
 
 	public function onSuccess() {