X-Git-Url: https://git.heureux-cyclage.org/?a=blobdiff_plain;f=includes%2Finstaller%2FSqliteInstaller.php;h=351b022329dabcdd24345a22aa93bce9ac331ae7;hb=894b5da4df996d4fd64494a89194a5efa6471483;hp=50a7181864b3cfe601a06bf0a509a726e031e071;hpb=8734fe02b84c0fdd6fa53454b23ce9239b50dc75;p=lhc%2Fweb%2Fwiklou.git diff --git a/includes/installer/SqliteInstaller.php b/includes/installer/SqliteInstaller.php index 50a7181864..351b022329 100644 --- a/includes/installer/SqliteInstaller.php +++ b/includes/installer/SqliteInstaller.php @@ -50,7 +50,7 @@ class SqliteInstaller extends DatabaseInstaller { /** * - * @return Status: + * @return Status */ public function checkPrerequisites() { $result = Status::newGood(); @@ -63,6 +63,7 @@ class SqliteInstaller extends DatabaseInstaller { if ( DatabaseSqlite::getFulltextSearchModule() != 'FTS3' ) { $result->warning( 'config-no-fts3' ); } + return $result; } @@ -73,6 +74,7 @@ class SqliteInstaller extends DatabaseInstaller { DIRECTORY_SEPARATOR, dirname( $_SERVER['DOCUMENT_ROOT'] ) . '/data' ); + return array( 'wgSQLiteDataDir' => $path ); } else { return array(); @@ -80,14 +82,23 @@ class SqliteInstaller extends DatabaseInstaller { } public function getConnectForm() { - return $this->getTextBox( 'wgSQLiteDataDir', 'config-sqlite-dir', array(), $this->parent->getHelpBox( 'config-sqlite-dir-help' ) ) . - $this->getTextBox( 'wgDBname', 'config-db-name', array(), $this->parent->getHelpBox( 'config-sqlite-name-help' ) ); + return $this->getTextBox( + 'wgSQLiteDataDir', + 'config-sqlite-dir', array(), + $this->parent->getHelpBox( 'config-sqlite-dir-help' ) + ) . + $this->getTextBox( + 'wgDBname', + 'config-db-name', + array(), + $this->parent->getHelpBox( 'config-sqlite-name-help' ) + ); } /** * Safe wrapper for PHP's realpath() that fails gracefully if it's unable to canonicalize the path. * - * @param $path string + * @param string $path * * @return string */ @@ -96,6 +107,7 @@ class SqliteInstaller extends DatabaseInstaller { if ( !$result ) { return $path; } + return $result; } @@ -115,12 +127,13 @@ class SqliteInstaller extends DatabaseInstaller { } # Table prefix is not used on SQLite, keep it empty $this->setVar( 'wgDBprefix', '' ); + return $result; } /** - * @param $dir - * @param $create bool + * @param string $dir + * @param bool $create * @return Status */ private static function dataDirOKmaybeCreate( $dir, $create = false ) { @@ -128,9 +141,16 @@ class SqliteInstaller extends DatabaseInstaller { if ( !is_writable( dirname( $dir ) ) ) { $webserverGroup = Installer::maybeGetWebserverPrimaryGroup(); if ( $webserverGroup !== null ) { - return Status::newFatal( 'config-sqlite-parent-unwritable-group', $dir, dirname( $dir ), basename( $dir ), $webserverGroup ); + return Status::newFatal( + 'config-sqlite-parent-unwritable-group', + $dir, dirname( $dir ), basename( $dir ), + $webserverGroup + ); } else { - return Status::newFatal( 'config-sqlite-parent-unwritable-nogroup', $dir, dirname( $dir ), basename( $dir ) ); + return Status::newFatal( + 'config-sqlite-parent-unwritable-nogroup', + $dir, dirname( $dir ), basename( $dir ) + ); } } @@ -173,6 +193,7 @@ class SqliteInstaller extends DatabaseInstaller { } catch ( DBConnectionError $e ) { $status->fatal( 'config-sqlite-connection-error', $e->getMessage() ); } + return $status; } @@ -220,6 +241,7 @@ class SqliteInstaller extends DatabaseInstaller { $this->setVar( 'wgDBuser', '' ); $this->setVar( 'wgDBpassword', '' ); $this->setupSchemaVars(); + return $this->getConnection(); } @@ -228,11 +250,12 @@ class SqliteInstaller extends DatabaseInstaller { */ public function createTables() { $status = parent::createTables(); + return $this->setupSearchIndex( $status ); } /** - * @param $status Status + * @param Status $status * @return Status */ public function setupSearchIndex( &$status ) { @@ -246,6 +269,7 @@ class SqliteInstaller extends DatabaseInstaller { } elseif ( !$fts3tTable && $module == 'FTS3' ) { $this->db->sourceFile( "$IP/maintenance/sqlite/archives/searchindex-fts3.sql" ); } + return $status; } @@ -254,8 +278,8 @@ class SqliteInstaller extends DatabaseInstaller { */ public function getLocalSettings() { $dir = LocalSettingsGenerator::escapePhpString( $this->getVar( 'wgSQLiteDataDir' ) ); - return -"# SQLite-specific settings + + return "# SQLite-specific settings \$wgSQLiteDataDir = \"{$dir}\";"; } }