X-Git-Url: https://git.heureux-cyclage.org/?a=blobdiff_plain;f=includes%2Fdb%2FDatabaseMysqlBase.php;h=7b903d68266d3a2399e6eaaba27bbc5ed26c4358;hb=b29425e0b4bd90588fee46efafb58b5f41729033;hp=f02aa93a41c328a2b079d1276634809f9f6e611e;hpb=8fe5a94aa059bf93ba1b00fde84ae6b1edf831fd;p=lhc%2Fweb%2Fwiklou.git diff --git a/includes/db/DatabaseMysqlBase.php b/includes/db/DatabaseMysqlBase.php index f02aa93a41..7b903d6826 100644 --- a/includes/db/DatabaseMysqlBase.php +++ b/includes/db/DatabaseMysqlBase.php @@ -126,19 +126,25 @@ abstract class DatabaseMysqlBase extends DatabaseBase { $this->reportConnectionError( "Error setting character set" ); } + // Abstract over any insane MySQL defaults + $set = array( 'group_concat_max_len = 262144' ); // Set SQL mode, default is turning them all off, can be overridden or skipped with null if ( is_string( $wgSQLMode ) ) { - $mode = $this->addQuotes( $wgSQLMode ); + $set[] = 'sql_mode = ' . $this->addQuotes( $wgSQLMode ); + } + + if ( $set ) { // Use doQuery() to avoid opening implicit transactions (DBO_TRX) - $success = $this->doQuery( "SET sql_mode = $mode", __METHOD__ ); + $success = $this->doQuery( 'SET ' . implode( ', ', $set ), __METHOD__ ); if ( !$success ) { wfLogDBError( - "Error setting sql_mode to $mode on server {db_server}", + 'Error setting MySQL variables on server {db_server} (check $wgSQLMode)', $this->getLogContext( array( 'method' => __METHOD__, ) ) ); - $this->reportConnectionError( "Error setting sql_mode to $mode" ); + $this->reportConnectionError( + 'Error setting MySQL variables on server {db_server} (check $wgSQLMode)' ); } }