X-Git-Url: https://git.heureux-cyclage.org/?a=blobdiff_plain;f=includes%2Fapi%2FApiFormatWddx.php;h=c18353fe456f50f8c2e97fee3157425dafe8f122;hb=2ec08fa5f0ba0d80aaa2f160cb323b0b784219f3;hp=ba90c2603ad9be85d8a2a2215ae949111a7ee3d4;hpb=db6b2cb3c252479ed6e9cf80100c3802528bd45f;p=lhc%2Fweb%2Fwiklou.git

diff --git a/includes/api/ApiFormatWddx.php b/includes/api/ApiFormatWddx.php
index ba90c2603a..c18353fe45 100644
--- a/includes/api/ApiFormatWddx.php
+++ b/includes/api/ApiFormatWddx.php
@@ -38,31 +38,73 @@ class ApiFormatWddx extends ApiFormatBase {
 	public function execute() {
 		$this->markDeprecated();
 
-		// Some versions of PHP have a broken wddx_serialize_value, see
-		// PHP bug 45314. Test encoding an affected character (U+00A0)
-		// to avoid this.
-		$expected =
-			"<wddxPacket version='1.0'><header/><data><string>\xc2\xa0</string></data></wddxPacket>";
-		if ( function_exists( 'wddx_serialize_value' )
-			&& !$this->getIsHtml()
-			&& wddx_serialize_value( "\xc2\xa0" ) == $expected
-		) {
-			$this->printText( wddx_serialize_value( $this->getResultData() ) );
+		$data = $this->getResult()->getResultData( null, array(
+			'BC' => array(),
+			'Types' => array( 'AssocAsObject' => true ),
+			'Strip' => 'all',
+		) );
+
+		if ( !$this->getIsHtml() && !static::useSlowPrinter() ) {
+			$txt = wddx_serialize_value( $data );
+			$txt = str_replace(
+				'<struct><var name=\'php_class_name\'><string>stdClass</string></var>',
+				'<struct>',
+				$txt
+			);
+			$this->printText( $txt );
 		} else {
 			// Don't do newlines and indentation if we weren't asked
 			// for pretty output
 			$nl = ( $this->getIsHtml() ? "\n" : '' );
-			$indstr = ' ';
+			$indstr = ( $this->getIsHtml() ? ' ' : '' );
 			$this->printText( "<?xml version=\"1.0\"?>$nl" );
 			$this->printText( "<wddxPacket version=\"1.0\">$nl" );
-			$this->printText( "$indstr<header/>$nl" );
+			$this->printText( "$indstr<header />$nl" );
 			$this->printText( "$indstr<data>$nl" );
-			$this->slowWddxPrinter( $this->getResultData(), 4 );
+			$this->slowWddxPrinter( $data, 4 );
 			$this->printText( "$indstr</data>$nl" );
 			$this->printText( "</wddxPacket>$nl" );
 		}
 	}
 
+	public static function useSlowPrinter() {
+		if ( !function_exists( 'wddx_serialize_value' ) ) {
+			return true;
+		}
+
+		// Some versions of PHP have a broken wddx_serialize_value, see
+		// PHP bug 45314. Test encoding an affected character (U+00A0)
+		// to avoid this.
+		$expected =
+			"<wddxPacket version='1.0'><header/><data><string>\xc2\xa0</string></data></wddxPacket>";
+		if ( wddx_serialize_value( "\xc2\xa0" ) !== $expected ) {
+			return true;
+		}
+
+		// Some versions of HHVM don't correctly encode ampersands.
+		$expected =
+			"<wddxPacket version='1.0'><header/><data><string>&amp;</string></data></wddxPacket>";
+		if ( wddx_serialize_value( '&' ) !== $expected ) {
+			return true;
+		}
+
+		// Some versions of HHVM don't correctly encode empty arrays as subvalues.
+		$expected =
+			"<wddxPacket version='1.0'><header/><data><array length='1'><array length='0'></array></array></data></wddxPacket>";
+		if ( wddx_serialize_value( array( array() ) ) !== $expected ) {
+			return true;
+		}
+
+		// Some versions of HHVM don't correctly encode associative arrays with numeric keys.
+		$expected =
+			"<wddxPacket version='1.0'><header/><data><struct><var name='2'><number>1</number></var></struct></data></wddxPacket>";
+		if ( wddx_serialize_value( array( 2 => 1 ) ) !== $expected ) {
+			return true;
+		}
+
+		return false;
+	}
+
 	/**
 	 * Recursively go through the object and output its data in WDDX format.
 	 * @param mixed $elemValue
@@ -72,44 +114,49 @@ class ApiFormatWddx extends ApiFormatBase {
 		$indstr = ( $this->getIsHtml() ? str_repeat( ' ', $indent ) : '' );
 		$indstr2 = ( $this->getIsHtml() ? str_repeat( ' ', $indent + 2 ) : '' );
 		$nl = ( $this->getIsHtml() ? "\n" : '' );
+
 		if ( is_array( $elemValue ) ) {
-			// Check whether we've got an associative array (<struct>)
-			// or a regular array (<array>)
 			$cnt = count( $elemValue );
-			if ( $cnt == 0 || array_keys( $elemValue ) === range( 0, $cnt - 1 ) ) {
-				// Regular array
-				$this->printText( $indstr . Xml::element( 'array', array(
-					'length' => $cnt ), null ) . $nl );
-				foreach ( $elemValue as $subElemValue ) {
-					$this->slowWddxPrinter( $subElemValue, $indent + 2 );
-				}
-				$this->printText( "$indstr</array>$nl" );
-			} else {
-				// Associative array (<struct>)
-				$this->printText( "$indstr<struct>$nl" );
-				foreach ( $elemValue as $subElemName => $subElemValue ) {
-					$this->printText( $indstr2 . Xml::element( 'var', array(
-						'name' => $subElemName
-					), null ) . $nl );
-					$this->slowWddxPrinter( $subElemValue, $indent + 4 );
-					$this->printText( "$indstr2</var>$nl" );
-				}
-				$this->printText( "$indstr</struct>$nl" );
+			if ( $cnt != 0 && array_keys( $elemValue ) !== range( 0, $cnt - 1 ) ) {
+				$elemValue = (object)$elemValue;
+			}
+		}
+
+		if ( is_array( $elemValue ) ) {
+			// Regular array
+			$this->printText( $indstr . Xml::element( 'array', array(
+				'length' => count( $elemValue ) ), null ) . $nl );
+			foreach ( $elemValue as $subElemValue ) {
+				$this->slowWddxPrinter( $subElemValue, $indent + 2 );
+			}
+			$this->printText( "$indstr</array>$nl" );
+		} elseif ( is_object( $elemValue ) ) {
+			// Associative array (<struct>)
+			$this->printText( "$indstr<struct>$nl" );
+			foreach ( $elemValue as $subElemName => $subElemValue ) {
+				$this->printText( $indstr2 . Xml::element( 'var', array(
+					'name' => $subElemName
+				), null ) . $nl );
+				$this->slowWddxPrinter( $subElemValue, $indent + 4 );
+				$this->printText( "$indstr2</var>$nl" );
 			}
+			$this->printText( "$indstr</struct>$nl" );
 		} elseif ( is_int( $elemValue ) || is_float( $elemValue ) ) {
 			$this->printText( $indstr . Xml::element( 'number', null, $elemValue ) . $nl );
 		} elseif ( is_string( $elemValue ) ) {
-			$this->printText( $indstr . Xml::element( 'string', null, $elemValue ) . $nl );
+			$this->printText( $indstr . Xml::element( 'string', null, $elemValue, false ) . $nl );
 		} elseif ( is_bool( $elemValue ) ) {
 			$this->printText( $indstr . Xml::element( 'boolean',
 				array( 'value' => $elemValue ? 'true' : 'false' ) ) . $nl
 			);
+		} elseif ( $elemValue === null ) {
+			$this->printText( $indstr . Xml::element( 'null', array() ) . $nl );
 		} else {
 			ApiBase::dieDebug( __METHOD__, 'Unknown type ' . gettype( $elemValue ) );
 		}
 	}
 
-	public function getDescription() {
-		return 'DEPRECATED! Output data in WDDX format' . parent::getDescription();
+	public function isDeprecated() {
+		return true;
 	}
 }