X-Git-Url: https://git.heureux-cyclage.org/?a=blobdiff_plain;f=includes%2FSpecialShortpages.php;h=72b093e0c7499f5094ad92195baee19bec497a92;hb=72a4abe588a7511ed5a92a5e30f889c60d824c1a;hp=f99642831d9b34584e46e9de03dcc67bc3ed6d6f;hpb=991f79858740fd389f943cd58e9553c2dd6df2d0;p=lhc%2Fweb%2Fwiklou.git

diff --git a/includes/SpecialShortpages.php b/includes/SpecialShortpages.php
index f99642831d..72b093e0c7 100644
--- a/includes/SpecialShortpages.php
+++ b/includes/SpecialShortpages.php
@@ -1,20 +1,13 @@
 <?php
 /**
  *
- * @package MediaWiki
- * @subpackage SpecialPage
+ * @addtogroup SpecialPage
  */
 
-/**
- *
- */
-require_once("QueryPage.php");
-
 /**
  * SpecialShortpages extends QueryPage. It is used to return the shortest
  * pages in the database.
- * @package MediaWiki
- * @subpackage SpecialPage
+ * @addtogroup SpecialPage
  */
 class ShortPagesPage extends QueryPage {
 
@@ -22,39 +15,66 @@ class ShortPagesPage extends QueryPage {
 		return "Shortpages";
 	}
 
+	/**
+	 * This query is indexed as of 1.5
+	 */
 	function isExpensive() {
 		return true;
 	}
-	function isSyndicated() { return false; }
+
+	function isSyndicated() {
+		return false;
+	}
 
 	function getSQL() {
-		$dbr =& wfGetDB( DB_SLAVE );
+		$dbr = wfGetDB( DB_SLAVE );
 		$page = $dbr->tableName( 'page' );
-		$text = $dbr->tableName( 'text' );
 		$name = $dbr->addQuotes( $this->getName() );
-		
-		# FIXME: Not only is this teh suck, it will fail
-		# if we compress revisions on save as it will return
-		# the compressed size.
+
+		$forceindex = $dbr->useIndexClause("page_len");
 		return
 			"SELECT $name as type,
-					page_namespace as namespace,
+				page_namespace as namespace,
 			        page_title as title,
-			        LENGTH(old_text) AS value
-			FROM $page, $text
-			WHERE page_namespace=".NS_MAIN." AND page_is_redirect=0
-			  AND page_latest=old_id";
+			        page_len AS value
+			FROM $page $forceindex
+			WHERE page_namespace=".NS_MAIN." AND page_is_redirect=0";
+	}
+
+	function preprocessResults( &$db, &$res ) {
+		# There's no point doing a batch check if we aren't caching results;
+		# the page must exist for it to have been pulled out of the table
+		if( $this->isCached() ) {
+			$batch = new LinkBatch();
+			while( $row = $db->fetchObject( $res ) )
+				$batch->addObj( Title::makeTitleSafe( $row->namespace, $row->title ) );
+			$batch->execute();
+			if( $db->numRows( $res ) > 0 )
+				$db->dataSeek( $res, 0 );
+		}
 	}
-	
+
 	function sortDescending() {
 		return false;
 	}
 
 	function formatResult( $skin, $result ) {
 		global $wgLang, $wgContLang;
-		$nb = wfMsg( "nbytes", $wgLang->formatNum( $result->value ) );
-		$link = $skin->makeKnownLink( $result->title, $wgContLang->convert( $result->title ) );
-		return "{$link} ({$nb})";
+		$dm = $wgContLang->getDirMark();
+		
+		$title = Title::makeTitleSafe( $result->namespace, $result->title );
+		if ( !$title ) {
+			return '<!-- Invalid title ' .  htmlspecialchars( "{$result->namespace}:{$result->title}" ). '-->';
+		}
+		$hlink = $skin->makeKnownLinkObj( $title, wfMsgHtml( 'hist' ), 'action=history' );
+		$plink = $this->isCached()
+					? $skin->makeLinkObj( $title )
+					: $skin->makeKnownLinkObj( $title );
+		$size = wfMsgExt( 'nbytes', array( 'parsemag', 'escape' ), $wgLang->formatNum( htmlspecialchars( $result->value ) ) );
+		
+		return $title->exists()
+				? "({$hlink}) {$dm}{$plink} {$dm}[{$size}]"
+				: "<s>({$hlink}) {$dm}{$plink} {$dm}[{$size}]</s>";
 	}
 }