X-Git-Url: https://git.heureux-cyclage.org/?a=blobdiff_plain;f=includes%2FOutputPage.php;h=d652be89fe4308213dc6fd23f838a2d5d52bbeaa;hb=6111daf9ef32bd56cd3e56c97b5b12626d568837;hp=6f62b11b1567393702b0161a57cd3fb9ac4ad05b;hpb=1343d55200ff15e6b692771a26d88959392b3fe3;p=lhc%2Fweb%2Fwiklou.git diff --git a/includes/OutputPage.php b/includes/OutputPage.php index 6f62b11b15..d652be89fe 100644 --- a/includes/OutputPage.php +++ b/includes/OutputPage.php @@ -23,7 +23,7 @@ class OutputPage { var $mLastModified = '', $mETag = false; var $mCategoryLinks = array(), $mCategories = array(), $mLanguageLinks = array(); - var $mScripts = '', $mLinkColours, $mPageLinkTitle = '', $mHeadItems = array(); + var $mScripts = '', $mInlineStyles = '', $mLinkColours, $mPageLinkTitle = '', $mHeadItems = array(); var $mModules = array(), $mModuleScripts = array(), $mModuleStyles = array(), $mModuleMessages = array(); var $mResourceLoader; var $mInlineMsg = array(); @@ -48,6 +48,7 @@ class OutputPage { var $mPageTitleActionText = ''; var $mParseWarnings = array(); var $mSquidMaxage = 0; + var $mPreventClickjacking = true; var $mRevisionId = null; protected $mTitle = null; @@ -232,7 +233,7 @@ class OutputPage { * @return Array of module names */ public function getModules() { - return $this->mModules; + return array_values( array_unique( $this->mModules ) ); } /** @@ -251,7 +252,7 @@ class OutputPage { * @return array of module names */ public function getModuleScripts() { - return $this->mModuleScripts; + return array_values( array_unique( $this->mModuleScripts ) ); } /** @@ -271,7 +272,7 @@ class OutputPage { * @return Array of module names */ public function getModuleStyles() { - return $this->mModuleStyles; + return array_values( array_unique( $this->mModuleStyles ) ); } /** @@ -291,7 +292,7 @@ class OutputPage { * @return Array of module names */ public function getModuleMessages() { - return $this->mModuleMessages; + return array_values( array_unique( $this->mModuleMessages ) ); } /** @@ -999,14 +1000,6 @@ class OutputPage { $this->mDebugtext .= $text; } - /** - * @deprecated use parserOptions() instead - */ - public function setParserOptions( $options ) { - wfDeprecated( __METHOD__ ); - return $this->parserOptions( $options ); - } - /** * Get/set the ParserOptions object to use for wikitext parsing * @@ -1117,43 +1110,6 @@ class OutputPage { wfProfileOut( __METHOD__ ); } - /** - * Add wikitext to the buffer, assuming that this is the primary text for a page view - * Saves the text into the parser cache if possible. - * - * @param $text String: wikitext - * @param $article Article object - * @param $cache Boolean - * @deprecated Use Article::outputWikitext - */ - public function addPrimaryWikiText( $text, $article, $cache = true ) { - global $wgParser; - - wfDeprecated( __METHOD__ ); - - $popts = $this->parserOptions(); - $popts->setTidy( true ); - $parserOutput = $wgParser->parse( - $text, $article->mTitle, - $popts, true, true, $this->mRevisionId - ); - $popts->setTidy( false ); - if ( $cache && $article && $parserOutput->isCacheable() ) { - $parserCache = ParserCache::singleton(); - $parserCache->save( $parserOutput, $article, $popts ); - } - - $this->addParserOutput( $parserOutput ); - } - - /** - * @deprecated use addWikiTextTidy() - */ - public function addSecondaryWikiText( $text, $linestart = true ) { - wfDeprecated( __METHOD__ ); - $this->addWikiTextTitleTidy( $text, $this->getTitle(), $linestart ); - } - /** * Add a ParserOutput object, but without Html * @@ -1226,24 +1182,44 @@ class OutputPage { * @param $interface Boolean: use interface language ($wgLang instead of * $wgContLang) while parsing language sensitive magic * words like GRAMMAR and PLURAL + * @param $language Language object: target language object, will override + * $interface * @return String: HTML */ - public function parse( $text, $linestart = true, $interface = false ) { + public function parse( $text, $linestart = true, $interface = false, $language = null ) { + // Check one for one common cause for parser state resetting + $callers = wfGetAllCallers( 10 ); + if ( strpos( $callers, 'Parser::extensionSubstitution' ) !== false ) { + throw new MWException( "wfMsg* function with parsing cannot be used " . + "inside a tag hook. Should use parser->recursiveTagParse() instead" ); + } + global $wgParser; + if( is_null( $this->getTitle() ) ) { throw new MWException( 'Empty $mTitle in ' . __METHOD__ ); } + $popts = $this->parserOptions(); if ( $interface ) { $popts->setInterfaceMessage( true ); } + if ( $language !== null ) { + $oldLang = $popts->setTargetLanguage( $language ); + } + $parserOutput = $wgParser->parse( $text, $this->getTitle(), $popts, $linestart, true, $this->mRevisionId ); + if ( $interface ) { $popts->setInterfaceMessage( false ); } + if ( $language !== null ) { + $popts->setTargetLanguage( $oldLang ); + } + return $parserOutput->getText(); } @@ -1268,24 +1244,6 @@ class OutputPage { return $parsed; } - /** - * @deprecated - * - * @param $article Article - * @return Boolean: true if successful, else false. - */ - public function tryParserCache( &$article ) { - wfDeprecated( __METHOD__ ); - $parserOutput = ParserCache::singleton()->get( $article, $article->getParserOptions() ); - - if ( $parserOutput !== false ) { - $this->addParserOutput( $parserOutput ); - return true; - } else { - return false; - } - } - /** * Set the value of the "s-maxage" part of the "Cache-control" HTTP header * @@ -1442,6 +1400,41 @@ class OutputPage { } } + /** + * Set a flag which will cause an X-Frame-Options header appropriate for + * edit pages to be sent. The header value is controlled by + * $wgEditPageFrameOptions. + * + * This is the default for special pages. If you display a CSRF-protected + * form on an ordinary view page, then you need to call this function. + */ + public function preventClickjacking( $enable = true ) { + $this->mPreventClickjacking = $enable; + } + + /** + * Turn off frame-breaking. Alias for $this->preventClickjacking(false). + * This can be called from pages which do not contain any CSRF-protected + * HTML form. + */ + public function allowClickjacking() { + $this->mPreventClickjacking = false; + } + + /** + * Get the X-Frame-Options header value (without the name part), or false + * if there isn't one. This is used by Skin to determine whether to enable + * JavaScript frame-breaking, for clients that don't support X-Frame-Options. + */ + public function getFrameOptions() { + global $wgBreakFrames, $wgEditPageFrameOptions; + if ( $wgBreakFrames ) { + return 'DENY'; + } elseif ( $this->mPreventClickjacking && $wgEditPageFrameOptions ) { + return $wgEditPageFrameOptions; + } + } + /** * Send cache control HTTP headers */ @@ -1578,7 +1571,6 @@ class OutputPage { global $wgLanguageCode, $wgDebugRedirects, $wgMimeType; global $wgUseAjax, $wgAjaxWatch; global $wgEnableMWSuggest, $wgUniversalEditButton; - global $wgArticle; if( $this->mDoNothing ) { return; @@ -1617,8 +1609,7 @@ class OutputPage { $sk = $wgUser->getSkin(); // Add base resources - $this->addModules( array( 'mediawiki.legacy.wikibits' ) ); - $this->addModules( array( 'mediawiki.util' ) ); + $this->addModules( array( 'mediawiki.legacy.wikibits', 'mediawiki.util' ) ); // Add various resources if required if ( $wgUseAjax ) { @@ -1627,7 +1618,7 @@ class OutputPage { wfRunHooks( 'AjaxAddScript', array( &$this ) ); if( $wgAjaxWatch && $wgUser->isLoggedIn() ) { - $this->addModules( 'mediawiki.legacy.ajaxwatch' ); + $this->addModules( 'mediawiki.action.watch.ajax' ); } if ( $wgEnableMWSuggest && !$wgUser->getOption( 'disablesuggest', false ) ) { @@ -1640,7 +1631,7 @@ class OutputPage { } if( $wgUniversalEditButton ) { - if( isset( $wgArticle ) && $this->getTitle() && $this->getTitle()->quickUserCan( 'edit' ) + if( $this->isArticleRelated() && $this->getTitle() && $this->getTitle()->quickUserCan( 'edit' ) && ( $this->getTitle()->exists() || $this->getTitle()->quickUserCan( 'create' ) ) ) { // Original UniversalEditButton $msg = wfMsg( 'edit' ); @@ -1666,6 +1657,12 @@ class OutputPage { $wgRequest->response()->header( "Content-type: $wgMimeType; charset={$wgOutputEncoding}" ); $wgRequest->response()->header( 'Content-language: ' . $wgLanguageCode ); + // Prevent framing, if requested + $frameOptions = $this->getFrameOptions(); + if ( $frameOptions ) { + $wgRequest->response()->header( "X-Frame-Options: $frameOptions" ); + } + if ( $this->mArticleBodyOnly ) { $this->out( $this->mBodytext ); } else { @@ -1702,17 +1699,6 @@ class OutputPage { print $outs; } - /** - * @deprecated use wfReportTime() instead. - * - * @return String - */ - public function reportTime() { - wfDeprecated( __METHOD__ ); - $time = wfReportTime(); - return $time; - } - /** * Produce a "user is blocked" page. * @@ -1803,9 +1789,7 @@ class OutputPage { $this->mRedirect = ''; $this->mBodytext = ''; - array_unshift( $params, 'parse' ); - array_unshift( $params, $msg ); - $this->addHTML( call_user_func_array( 'wfMsgExt', $params ) ); + $this->addWikiMsgArray( $msg, $params ); $this->returnToMain(); } @@ -1890,7 +1874,7 @@ class OutputPage { $this->setPageTitle( wfMsg( 'loginreqtitle' ) ); $this->setHtmlTitle( wfMsg( 'errorpagetitle' ) ); $this->setRobotPolicy( 'noindex,nofollow' ); - $this->setArticleFlag( false ); + $this->setArticleRelated( false ); $loginTitle = SpecialPage::getTitleFor( 'Userlogin' ); $loginLink = $skin->link( @@ -2050,53 +2034,6 @@ class OutputPage { $this->addModules( 'mediawiki.legacy.password' ); } - /** @deprecated */ - public function errorpage( $title, $msg ) { - wfDeprecated( __METHOD__ ); - throw new ErrorPageError( $title, $msg ); - } - - /** @deprecated */ - public function databaseError( $fname, $sql, $error, $errno ) { - throw new MWException( "OutputPage::databaseError is obsolete\n" ); - } - - /** @deprecated */ - public function fatalError( $message ) { - wfDeprecated( __METHOD__ ); - throw new FatalError( $message ); - } - - /** @deprecated */ - public function unexpectedValueError( $name, $val ) { - wfDeprecated( __METHOD__ ); - throw new FatalError( wfMsg( 'unexpected', $name, $val ) ); - } - - /** @deprecated */ - public function fileCopyError( $old, $new ) { - wfDeprecated( __METHOD__ ); - throw new FatalError( wfMsg( 'filecopyerror', $old, $new ) ); - } - - /** @deprecated */ - public function fileRenameError( $old, $new ) { - wfDeprecated( __METHOD__ ); - throw new FatalError( wfMsg( 'filerenameerror', $old, $new ) ); - } - - /** @deprecated */ - public function fileDeleteError( $name ) { - wfDeprecated( __METHOD__ ); - throw new FatalError( wfMsg( 'filedeleteerror', $name ) ); - } - - /** @deprecated */ - public function fileNotFoundError( $name ) { - wfDeprecated( __METHOD__ ); - throw new FatalError( wfMsg( 'filenotfound', $name ) ); - } - public function showFatalError( $message ) { $this->setPageTitle( wfMsg( 'internalerror' ) ); $this->setRobotPolicy( 'noindex,nofollow' ); @@ -2216,13 +2153,10 @@ class OutputPage { $ret .= Html::element( 'title', null, $this->getHTMLTitle() ) . "\n"; $ret .= implode( "\n", array( - $this->getHeadLinks(), + $this->getHeadLinks( $sk ), $this->buildCssLinks( $sk ), - $this->getHeadItems(), + $this->getHeadItems() ) ); - if ( $sk->usercss ) { - $ret .= Html::inlineStyle( $sk->usercss ); - } if ( $wgUseTrackbacks && $this->isArticleRelated() ) { $ret .= $this->getTitle()->trackbackRDF(); @@ -2294,7 +2228,7 @@ class OutputPage { */ protected function makeResourceLoaderLink( Skin $skin, $modules, $only, $useESI = false ) { global $wgUser, $wgLang, $wgLoadScript, $wgResourceLoaderUseESI, - $wgResourceLoaderInlinePrivateModules; + $wgResourceLoaderInlinePrivateModules, $wgRequest; // Lazy-load ResourceLoader // TODO: Should this be a static function of ResourceLoader instead? // TODO: Divide off modules starting with "user", and add the user parameter to them @@ -2304,6 +2238,13 @@ class OutputPage { 'skin' => $skin->getSkinName(), 'only' => $only, ); + // Propagate printable and handheld parameters if present + if ( $wgRequest->getBool( 'printable' ) ) { + $query['printable'] = 1; + } + if ( $wgRequest->getBool( 'handheld' ) ) { + $query['handheld'] = 1; + } if ( !count( $modules ) ) { return ''; @@ -2443,7 +2384,7 @@ class OutputPage { $action = $wgRequest->getVal( 'action', 'view' ); if( $this->mTitle && $this->mTitle->isJsSubpage() && $sk->userCanPreview( $action ) ) { # XXX: additional security check/prompt? - $this->addInlineScript( $wgRequest->getText( 'wpTextbox1' ) ); + $scripts .= Html::inlineScript( "\n" . $wgRequest->getText( 'wpTextbox1' ) . "\n" ) . "\n"; } else { $scripts .= $this->makeResourceLoaderLink( $sk, array( 'user', 'user.options' ), 'scripts' @@ -2502,7 +2443,7 @@ class OutputPage { /** * @return string HTML tag links to be put in the header. */ - public function getHeadLinks() { + public function getHeadLinks( Skin $sk ) { global $wgFeed; // Ideally this should happen earlier, somewhere. :P @@ -2572,7 +2513,6 @@ class OutputPage { } } } - return implode( "\n", $tags ); } @@ -2623,14 +2563,17 @@ class OutputPage { * @param $style_css Mixed: inline CSS */ public function addInlineStyle( $style_css ){ - $this->mScripts .= Html::inlineStyle( $style_css ); + $this->mInlineStyles .= Html::inlineStyle( $style_css ); } /** * Build a set of s for the stylesheets specified in the $this->styles array. * These will be applied to various media & IE conditionals. + * @param $sk Skin object */ public function buildCssLinks( $sk ) { + $ret = ''; + // Add ResourceLoader styles // Split the styles into three groups $styles = array( 'other' => array(), 'user' => array(), 'site' => array() ); $resourceLoader = $this->getResourceLoader(); @@ -2638,15 +2581,24 @@ class OutputPage { $group = $resourceLoader->getModule( $name )->getGroup(); // Modules in groups named "other" or anything different than "user" or "site" will // be placed in the "other" group - $styles[isset( $style[$group] ) ? $group : 'other'][] = $name; - } - // Add tags created using legacy methods - $tags = $this->buildCssLinksArray(); - // Add ResourceLoader module style tags - $tags[] = $this->makeResourceLoaderLink( - $sk, array_merge( $styles['other'], $styles['site'], $styles['user'] ), 'styles' + $styles[isset( $styles[$group] ) ? $group : 'other'][] = $name; + } + + // We want site and user styles to override dynamically added styles from modules, but we want + // dynamically added styles to override statically added styles from other modules. So the order + // has to be other, dynamic, site, user + // Add statically added styles for other modules + $ret .= $this->makeResourceLoaderLink( $sk, $styles['other'], 'styles' ); + // Add normal styles added through addStyle()/addInlineStyle() here + $ret .= implode( "\n", $this->buildCssLinksArray() ) . $this->mInlineStyles; + // Add marker tag to mark the place where the client-side loader should inject dynamic styles + // We use a tag with a made-up name for this because that's valid HTML + $ret .= Html::element( 'meta', array( 'name' => 'ResourceLoaderDynamicStyles', 'content' => '' ) ); + // Add site and user styles + $ret .= $this->makeResourceLoaderLink( + $sk, array_merge( $styles['site'], $styles['user'] ), 'styles' ); - return implode( "\n", $tags ); + return $ret; } public function buildCssLinksArray() { @@ -2677,7 +2629,7 @@ class OutputPage { } if( isset( $options['media'] ) ) { - $media = $this->transformCssMedia( $options['media'] ); + $media = self::transformCssMedia( $options['media'] ); if( is_null( $media ) ) { return ''; } @@ -2709,7 +2661,7 @@ class OutputPage { * @param $media String: current value of the "media" attribute * @return String: modified value of the "media" attribute */ - function transformCssMedia( $media ) { + public static function transformCssMedia( $media ) { global $wgRequest, $wgHandheldForIPhone; // Switch in on-screen display for media testing @@ -2858,7 +2810,7 @@ class OutputPage { * @param $modules Array: list of jQuery modules which should be loaded * @return Array: the list of modules which were not loaded. * @since 1.16 - * @deprecated No longer needed as of 1.17 + * @deprecated @since 1.17 */ public function includeJQuery( $modules = array() ) { return array();