X-Git-Url: https://git.heureux-cyclage.org/?a=blobdiff_plain;ds=sidebyside;f=tests%2Fphpunit%2Fincludes%2Fresourceloader%2FMessageBlobStoreTest.php;h=e094d92b9dde7611e6fa1958769da695c4f12559;hb=15c27d356b5e6760024ac0653279a76d94d78b1f;hp=e57764306e347c44657ab82ac54799e4d2771576;hpb=9fc202b69496353a1142a692be5aaf158e9ea30c;p=lhc%2Fweb%2Fwiklou.git

diff --git a/tests/phpunit/includes/resourceloader/MessageBlobStoreTest.php b/tests/phpunit/includes/resourceloader/MessageBlobStoreTest.php
index e57764306e..e094d92b9d 100644
--- a/tests/phpunit/includes/resourceloader/MessageBlobStoreTest.php
+++ b/tests/phpunit/includes/resourceloader/MessageBlobStoreTest.php
@@ -25,7 +25,7 @@ class MessageBlobStoreTest extends PHPUnit\Framework\TestCase {
 
 	public function testBlobCreation() {
 		$module = $this->makeModule( [ 'mainpage' ] );
-		$rl = new ResourceLoader();
+		$rl = new EmptyResourceLoader();
 		$rl->register( $module->getName(), $module );
 
 		$blobStore = $this->makeBlobStore( null, $rl );
@@ -34,21 +34,32 @@ class MessageBlobStoreTest extends PHPUnit\Framework\TestCase {
 		$this->assertEquals( '{"mainpage":"Main Page"}', $blob, 'Generated blob' );
 	}
 
+	public function testBlobCreation_empty() {
+		$module = $this->makeModule( [] );
+		$rl = new EmptyResourceLoader();
+		$rl->register( $module->getName(), $module );
+
+		$blobStore = $this->makeBlobStore( null, $rl );
+		$blob = $blobStore->getBlob( $module, 'en' );
+
+		$this->assertEquals( '{}', $blob, 'Generated blob' );
+	}
+
 	public function testBlobCreation_unknownMessage() {
-		$module = $this->makeModule( [ 'i-dont-exist' ] );
-		$rl = new ResourceLoader();
+		$module = $this->makeModule( [ 'i-dont-exist', 'mainpage', 'i-dont-exist2' ] );
+		$rl = new EmptyResourceLoader();
 		$rl->register( $module->getName(), $module );
 		$blobStore = $this->makeBlobStore( null, $rl );
 
-		// Generating a blob should succeed without errors,
-		// even if a message is unknown.
+		// Generating a blob should continue without errors,
+		// with keys of unknown messages excluded from the blob.
 		$blob = $blobStore->getBlob( $module, 'en' );
-		$this->assertEquals( '{"i-dont-exist":"\u29fci-dont-exist\u29fd"}', $blob, 'Generated blob' );
+		$this->assertEquals( '{"mainpage":"Main Page"}', $blob, 'Generated blob' );
 	}
 
 	public function testMessageCachingAndPurging() {
 		$module = $this->makeModule( [ 'example' ] );
-		$rl = new ResourceLoader();
+		$rl = new EmptyResourceLoader();
 		$rl->register( $module->getName(), $module );
 		$blobStore = $this->makeBlobStore( [ 'fetchMessage' ], $rl );
 
@@ -93,7 +104,7 @@ class MessageBlobStoreTest extends PHPUnit\Framework\TestCase {
 
 	public function testPurgeEverything() {
 		$module = $this->makeModule( [ 'example' ] );
-		$rl = new ResourceLoader();
+		$rl = new EmptyResourceLoader();
 		$rl->register( $module->getName(), $module );
 		$blobStore = $this->makeBlobStore( [ 'fetchMessage' ], $rl );
 		// Advance this new WANObjectCache instance to a normal state.
@@ -127,7 +138,7 @@ class MessageBlobStoreTest extends PHPUnit\Framework\TestCase {
 	public function testValidateAgainstModuleRegistry() {
 		// Arrange version 1 of a module
 		$module = $this->makeModule( [ 'foo' ] );
-		$rl = new ResourceLoader();
+		$rl = new EmptyResourceLoader();
 		$rl->register( $module->getName(), $module );
 		$blobStore = $this->makeBlobStore( [ 'fetchMessage' ], $rl );
 		$blobStore->expects( $this->once() )
@@ -146,7 +157,7 @@ class MessageBlobStoreTest extends PHPUnit\Framework\TestCase {
 		// must always match the set of message keys required by the module.
 		// We do not receive purges for this because no messages were changed.
 		$module = $this->makeModule( [ 'foo', 'bar' ] );
-		$rl = new ResourceLoader();
+		$rl = new EmptyResourceLoader();
 		$rl->register( $module->getName(), $module );
 		$blobStore = $this->makeBlobStore( [ 'fetchMessage' ], $rl );
 		$blobStore->expects( $this->exactly( 2 ) )