X-Git-Url: https://git.heureux-cyclage.org/?a=blobdiff_plain;ds=sidebyside;f=includes%2Flibs%2Frdbms%2Fdatabase%2FIDatabase.php;h=2922bce327ea0e9d422e224b5fc1f653fe9c52de;hb=27c61fb1e94da9114314468fd00bcf129ec064b6;hp=85b3481fe3e9a838bdb817754df211040b2bd643;hpb=3844fd9d639ed67cd3519eab2d7db440100cdd26;p=lhc%2Fweb%2Fwiklou.git diff --git a/includes/libs/rdbms/database/IDatabase.php b/includes/libs/rdbms/database/IDatabase.php index 85b3481fe3..2922bce327 100644 --- a/includes/libs/rdbms/database/IDatabase.php +++ b/includes/libs/rdbms/database/IDatabase.php @@ -962,11 +962,11 @@ interface IDatabase { * Example usage: * @code * $sql = $db->makeList( [ - * 'rev_user' => $id, + * 'rev_page' => $id, * $db->makeList( [ 'rev_minor' => 1, 'rev_len' < 500 ], $db::LIST_OR ] ) * ], $db::LIST_AND ); * @endcode - * This would set $sql to "rev_user = '$id' AND (rev_minor = '1' OR rev_len < '500')" + * This would set $sql to "rev_page = '$id' AND (rev_minor = '1' OR rev_len < '500')" * * @param array $a Containing the data * @param int $mode IDatabase class constant: @@ -1255,6 +1255,11 @@ interface IDatabase { * INSERT SELECT wrapper. Takes data from a SELECT query and inserts it * into another table. * + * @warning If the insert will use an auto-increment or sequence to + * determine the value of a column, this may break replication on + * databases using statement-based replication if the SELECT is not + * deterministically ordered. + * * @param string $destTable The table name to insert into * @param string|array $srcTable May be either a table name, or an array of table names * to include in a join. @@ -1771,7 +1776,7 @@ interface IDatabase { public function setSchemaVars( $vars ); /** - * Check to see if a named lock is available (non-blocking) + * Check to see if a named lock is not locked by any thread (non-blocking) * * @param string $lockName Name of lock to poll * @param string $method Name of method calling us