X-Git-Url: https://git.heureux-cyclage.org/?a=blobdiff_plain;ds=sidebyside;f=includes%2Fapi%2FApiDelete.php;h=a63dee6fc186309b62a2ed0b14d5e03bcc52f01d;hb=a15339a9b55338e72bccf033103e423eedb4c208;hp=72bbe004828923f1537b5af6491e91294903cba1;hpb=d5a7166771613dfe4ed9fb75fa5efeced6134bd1;p=lhc%2Fweb%2Fwiklou.git

diff --git a/includes/api/ApiDelete.php b/includes/api/ApiDelete.php
index 72bbe00482..a63dee6fc1 100644
--- a/includes/api/ApiDelete.php
+++ b/includes/api/ApiDelete.php
@@ -1,9 +1,5 @@
 <?php
 /**
- *
- *
- * Created on Jun 30, 2007
- *
  * Copyright © 2007 Roan Kattouw "<Firstname>.<Lastname>@gmail.com"
  *
  * This program is free software; you can redistribute it and/or modify
@@ -59,7 +55,7 @@ class ApiDelete extends ApiBase {
 
 		// If change tagging was requested, check that the user is allowed to tag,
 		// and the tags are valid
-		if ( count( $params['tags'] ) ) {
+		if ( $params['tags'] ) {
 			$tagStatus = ChangeTags::canAddTagsAccompanyingChange( $params['tags'], $user );
 			if ( !$tagStatus->isOK() ) {
 				$this->dieStatus( $tagStatus );
@@ -106,7 +102,7 @@ class ApiDelete extends ApiBase {
 	 *
 	 * @param Page|WikiPage $page Page or WikiPage object to work on
 	 * @param User $user User doing the action
-	 * @param string|null $reason Reason for the deletion. Autogenerated if null
+	 * @param string|null &$reason Reason for the deletion. Autogenerated if null
 	 * @param array $tags Tags to tag the deletion with
 	 * @return Status
 	 */
@@ -120,7 +116,8 @@ class ApiDelete extends ApiBase {
 			$hasHistory = false;
 			$reason = $page->getAutoDeleteReason( $hasHistory );
 			if ( $reason === false ) {
-				return Status::newFatal( 'cannotdelete', $title->getPrefixedText() );
+				// Should be reachable only if the page has no revisions
+				return Status::newFatal( 'cannotdelete', $title->getPrefixedText() ); // @codeCoverageIgnore
 			}
 		}
 
@@ -142,7 +139,7 @@ class ApiDelete extends ApiBase {
 	 * @param Page $page Object to work on
 	 * @param User $user User doing the action
 	 * @param string $oldimage Archive name
-	 * @param string $reason Reason for the deletion. Autogenerated if null.
+	 * @param string &$reason Reason for the deletion. Autogenerated if null.
 	 * @param bool $suppress Whether to mark all deleted versions as restricted
 	 * @param array $tags Tags to tag the deletion with
 	 * @return Status