languages: Add coverage for 'ar' and 'ml' normalize()

[lhc/web/wiklou.git] / tests / phpunit / languages / classes / LanguageArTest.php

diff --git a/tests/phpunit/languages/classes/LanguageArTest.php b/tests/phpunit/languages/classes/LanguageArTest.php
index 7b48f23..296ee60 100644 (file)
--- a/tests/phpunit/languages/classes/LanguageArTest.php
+++ b/tests/phpunit/languages/classes/LanguageArTest.php
@@ -1,52 +1,83 @@
 <?php
+
 /**
- * Based on LanguagMlTest
- * @file
+ * @covers LanguageAr
  */
-
-/** Tests for MediaWiki languages/LanguageAr.php */
 class LanguageArTest extends LanguageClassesTestCase {
+
        /**
         * @covers Language::formatNum
-        * @todo split into a test and a dataprovider
+        * @dataProvider provideFormatNum
         */
-       public function testFormatNum() {
-               $this->assertEquals( '١٬٢٣٤٬٥٦٧', $this->getLang()->formatNum( '1234567' ) );
-               $this->assertEquals( '-١٢٫٨٩', $this->getLang()->formatNum( -12.89 ) );
+       public function testFormatNum( $num, $formatted ) {
+               $this->assertEquals( $formatted, $this->getLang()->formatNum( $num ) );
+       }
+
+       public static function provideFormatNum() {
+               return [
+                       [ '1234567', '١٬٢٣٤٬٥٦٧' ],
+                       [ -12.89, '-١٢٫٨٩' ],
+               ];
+       }
+
+       /**
+        * @covers LanguageAr::normalize
+        * @covers Language::normalize
+        * @dataProvider provideNormalize
+        */
+       public function testNormalize( $input, $expected ) {
+               if ( $input === $expected ) {
+                       throw new Exception( 'Expected output must differ.' );
+               }
+
+               $this->setMwGlobals( 'wgFixArabicUnicode', true );
+               $this->assertSame( $expected, $this->getLang()->normalize( $input ), 'ar-normalised form' );
+
+               $this->setMwGlobals( 'wgFixArabicUnicode', false );
+               $this->assertSame( $input, $this->getLang()->normalize( $input ), 'regular normalised form' );
+       }
+
+       public static function provideNormalize() {
+               return [
+                       [
+                               'ﷅ',
+                               'صمم',
+                       ],
+               ];
        }
 
        /**
         * Mostly to test the raw ascii feature.
-        * @dataProvider providerSprintfDate
+        * @dataProvider provideSprintfDate
         * @covers Language::sprintfDate
         */
        public function testSprintfDate( $format, $date, $expected ) {
                $this->assertEquals( $expected, $this->getLang()->sprintfDate( $format, $date ) );
        }
 
-       public static function providerSprintfDate() {
-               return array(
-                       array(
+       public static function provideSprintfDate() {
+               return [
+                       [
                                'xg "vs" g',
                                '20120102030410',
                                'يناير vs ٣'
-                       ),
-                       array(
+                       ],
+                       [
                                'xmY',
                                '20120102030410',
                                '١٤٣٣'
-                       ),
-                       array(
+                       ],
+                       [
                                'xnxmY',
                                '20120102030410',
                                '1433'
-                       ),
-                       array(
+                       ],
+                       [
                                'xN xmj xmn xN xmY',
                                '20120102030410',
                                ' 7 2  ١٤٣٣'
-                       ),
-               );
+                       ],
+               ];
        }
 
        /**
@@ -54,7 +85,7 @@ class LanguageArTest extends LanguageClassesTestCase {
         * @covers Language::convertPlural
         */
        public function testPlural( $result, $value ) {
-               $forms = array( 'zero', 'one', 'two', 'few', 'many', 'other' );
+               $forms = [ 'zero', 'one', 'two', 'few', 'many', 'other' ];
                $this->assertEquals( $result, $this->getLang()->convertPlural( $value, $forms ) );
        }
 
@@ -67,21 +98,21 @@ class LanguageArTest extends LanguageClassesTestCase {
        }
 
        public static function providePlural() {
-               return array(
-                       array( 'zero', 0 ),
-                       array( 'one', 1 ),
-                       array( 'two', 2 ),
-                       array( 'few', 3 ),
-                       array( 'few', 9 ),
-                       array( 'few', 110 ),
-                       array( 'many', 11 ),
-                       array( 'many', 15 ),
-                       array( 'many', 99 ),
-                       array( 'many', 9999 ),
-                       array( 'other', 100 ),
-                       array( 'other', 102 ),
-                       array( 'other', 1000 ),
-                       array( 'other', 1.7 ),
-               );
+               return [
+                       [ 'zero', 0 ],
+                       [ 'one', 1 ],
+                       [ 'two', 2 ],
+                       [ 'few', 3 ],
+                       [ 'few', 9 ],
+                       [ 'few', 110 ],
+                       [ 'many', 11 ],
+                       [ 'many', 15 ],
+                       [ 'many', 99 ],
+                       [ 'many', 9999 ],
+                       [ 'other', 100 ],
+                       [ 'other', 102 ],
+                       [ 'other', 1000 ],
+                       [ 'other', 1.7 ],
+               ];
        }
 }