Merge "Remove .mw-help-field-hint and -data CSS classes from mw.legacy/shared"

[lhc/web/wiklou.git] / tests / phpunit / includes / logging / LogFormatterTest.php

diff --git a/tests/phpunit/includes/logging/LogFormatterTest.php b/tests/phpunit/includes/logging/LogFormatterTest.php
index 1816708..a21a3ff 100644 (file)
--- a/tests/phpunit/includes/logging/LogFormatterTest.php
+++ b/tests/phpunit/includes/logging/LogFormatterTest.php
@@ -35,13 +35,13 @@ class LogFormatterTest extends MediaWikiLangTestCase {
 
                global $wgLang;
 
-               $this->setMwGlobals( array(
-                       'wgLogTypes' => array( 'phpunit' ),
-                       'wgLogActionsHandlers' => array( 'phpunit/test' => 'LogFormatter',
-                               'phpunit/param' => 'LogFormatter' ),
+               $this->setMwGlobals( [
+                       'wgLogTypes' => [ 'phpunit' ],
+                       'wgLogActionsHandlers' => [ 'phpunit/test' => 'LogFormatter',
+                               'phpunit/param' => 'LogFormatter' ],
                        'wgUser' => User::newFromName( 'Testuser' ),
-                       'wgExtensionMessagesFiles' => array( 'LogTests' => __DIR__ . '/LogTests.i18n.php' ),
-               ) );
+                       'wgExtensionMessagesFiles' => [ 'LogTests' => __DIR__ . '/LogTests.i18n.php' ],
+               ] );
 
                Language::getLocalisationCache()->recache( $wgLang->getCode() );
 
@@ -79,7 +79,7 @@ class LogFormatterTest extends MediaWikiLangTestCase {
         * @covers LogFormatter::newFromEntry
         */
        public function testNormalLogParams() {
-               $entry = $this->newLogEntry( 'test', array() );
+               $entry = $this->newLogEntry( 'test', [] );
                $formatter = LogFormatter::newFromEntry( $entry );
                $formatter->setContext( $this->context );
 
@@ -101,7 +101,7 @@ class LogFormatterTest extends MediaWikiLangTestCase {
                        $this->user->getEditCount()
                );
 
-               $titleLink = Linker::link( $this->title, null, array(), array() );
+               $titleLink = Linker::link( $this->title, null, [], [] );
 
                // $paramsWithoutTools and $paramsWithTools should be only different
                // in index 0
@@ -121,8 +121,8 @@ class LogFormatterTest extends MediaWikiLangTestCase {
         * @covers LogFormatter::getActionText
         */
        public function testLogParamsTypeRaw() {
-               $params = array( '4:raw:raw' => Linker::link( $this->title, null, array(), array() ) );
-               $expected = Linker::link( $this->title, null, array(), array() );
+               $params = [ '4:raw:raw' => Linker::link( $this->title, null, [], [] ) ];
+               $expected = Linker::link( $this->title, null, [], [] );
 
                $entry = $this->newLogEntry( 'param', $params );
                $formatter = LogFormatter::newFromEntry( $entry );
@@ -138,7 +138,7 @@ class LogFormatterTest extends MediaWikiLangTestCase {
         * @covers LogFormatter::getActionText
         */
        public function testLogParamsTypeMsg() {
-               $params = array( '4:msg:msg' => 'log-description-phpunit' );
+               $params = [ '4:msg:msg' => 'log-description-phpunit' ];
                $expected = wfMessage( 'log-description-phpunit' )->text();
 
                $entry = $this->newLogEntry( 'param', $params );
@@ -155,7 +155,7 @@ class LogFormatterTest extends MediaWikiLangTestCase {
         * @covers LogFormatter::getActionText
         */
        public function testLogParamsTypeMsgContent() {
-               $params = array( '4:msg-content:msgContent' => 'log-description-phpunit' );
+               $params = [ '4:msg-content:msgContent' => 'log-description-phpunit' ];
                $expected = wfMessage( 'log-description-phpunit' )->inContentLanguage()->text();
 
                $entry = $this->newLogEntry( 'param', $params );
@@ -174,7 +174,7 @@ class LogFormatterTest extends MediaWikiLangTestCase {
        public function testLogParamsTypeNumber() {
                global $wgLang;
 
-               $params = array( '4:number:number' => 123456789 );
+               $params = [ '4:number:number' => 123456789 ];
                $expected = $wgLang->formatNum( 123456789 );
 
                $entry = $this->newLogEntry( 'param', $params );
@@ -191,7 +191,7 @@ class LogFormatterTest extends MediaWikiLangTestCase {
         * @covers LogFormatter::getActionText
         */
        public function testLogParamsTypeUserLink() {
-               $params = array( '4:user-link:userLink' => $this->user->getName() );
+               $params = [ '4:user-link:userLink' => $this->user->getName() ];
                $expected = Linker::userLink(
                        $this->user->getId(),
                        $this->user->getName()
@@ -211,8 +211,8 @@ class LogFormatterTest extends MediaWikiLangTestCase {
         * @covers LogFormatter::getActionText
         */
        public function testLogParamsTypeTitleLink() {
-               $params = array( '4:title-link:titleLink' => $this->title->getText() );
-               $expected = Linker::link( $this->title, null, array(), array() );
+               $params = [ '4:title-link:titleLink' => $this->title->getText() ];
+               $expected = Linker::link( $this->title, null, [], [] );
 
                $entry = $this->newLogEntry( 'param', $params );
                $formatter = LogFormatter::newFromEntry( $entry );
@@ -228,7 +228,7 @@ class LogFormatterTest extends MediaWikiLangTestCase {
         * @covers LogFormatter::getActionText
         */
        public function testLogParamsTypePlain() {
-               $params = array( '4:plain:plain' => 'Some plain text' );
+               $params = [ '4:plain:plain' => 'Some plain text' ];
                $expected = 'Some plain text';
 
                $entry = $this->newLogEntry( 'param', $params );
@@ -245,7 +245,7 @@ class LogFormatterTest extends MediaWikiLangTestCase {
         * @covers LogFormatter::getComment
         */
        public function testLogComment() {
-               $entry = $this->newLogEntry( 'test', array() );
+               $entry = $this->newLogEntry( 'test', [] );
                $formatter = LogFormatter::newFromEntry( $entry );
                $formatter->setContext( $this->context );
 
@@ -260,7 +260,7 @@ class LogFormatterTest extends MediaWikiLangTestCase {
         * @covers LogFormatter::formatParameterValueForApi
         */
        public function testApiParamFormatting( $key, $value, $expected ) {
-               $entry = $this->newLogEntry( 'param', array( $key => $value ) );
+               $entry = $this->newLogEntry( 'param', [ $key => $value ] );
                $formatter = LogFormatter::newFromEntry( $entry );
                $formatter->setContext( $this->context );
 
@@ -271,40 +271,40 @@ class LogFormatterTest extends MediaWikiLangTestCase {
        }
 
        public static function provideApiParamFormatting() {
-               return array(
-                       array( 0, 'value', array( 'value' ) ),
-                       array( 'named', 'value', array( 'named' => 'value' ) ),
-                       array( '::key', 'value', array( 'key' => 'value' ) ),
-                       array( '4::key', 'value', array( 'key' => 'value' ) ),
-                       array( '4:raw:key', 'value', array( 'key' => 'value' ) ),
-                       array( '4:plain:key', 'value', array( 'key' => 'value' ) ),
-                       array( '4:bool:key', '1', array( 'key' => true ) ),
-                       array( '4:bool:key', '0', array( 'key' => false ) ),
-                       array( '4:number:key', '123', array( 'key' => 123 ) ),
-                       array( '4:number:key', '123.5', array( 'key' => 123.5 ) ),
-                       array( '4:array:key', array(), array( 'key' => array( ApiResult::META_TYPE => 'array' ) ) ),
-                       array( '4:assoc:key', array(), array( 'key' => array( ApiResult::META_TYPE => 'assoc' ) ) ),
-                       array( '4:kvp:key', array(), array( 'key' => array( ApiResult::META_TYPE => 'kvp' ) ) ),
-                       array( '4:timestamp:key', '20150102030405', array( 'key' => '2015-01-02T03:04:05Z' ) ),
-                       array( '4:msg:key', 'parentheses', array(
+               return [
+                       [ 0, 'value', [ 'value' ] ],
+                       [ 'named', 'value', [ 'named' => 'value' ] ],
+                       [ '::key', 'value', [ 'key' => 'value' ] ],
+                       [ '4::key', 'value', [ 'key' => 'value' ] ],
+                       [ '4:raw:key', 'value', [ 'key' => 'value' ] ],
+                       [ '4:plain:key', 'value', [ 'key' => 'value' ] ],
+                       [ '4:bool:key', '1', [ 'key' => true ] ],
+                       [ '4:bool:key', '0', [ 'key' => false ] ],
+                       [ '4:number:key', '123', [ 'key' => 123 ] ],
+                       [ '4:number:key', '123.5', [ 'key' => 123.5 ] ],
+                       [ '4:array:key', [], [ 'key' => [ ApiResult::META_TYPE => 'array' ] ] ],
+                       [ '4:assoc:key', [], [ 'key' => [ ApiResult::META_TYPE => 'assoc' ] ] ],
+                       [ '4:kvp:key', [], [ 'key' => [ ApiResult::META_TYPE => 'kvp' ] ] ],
+                       [ '4:timestamp:key', '20150102030405', [ 'key' => '2015-01-02T03:04:05Z' ] ],
+                       [ '4:msg:key', 'parentheses', [
                                'key_key' => 'parentheses',
                                'key_text' => wfMessage( 'parentheses' )->text(),
-                       ) ),
-                       array( '4:msg-content:key', 'parentheses', array(
+                       ] ],
+                       [ '4:msg-content:key', 'parentheses', [
                                'key_key' => 'parentheses',
                                'key_text' => wfMessage( 'parentheses' )->inContentLanguage()->text(),
-                       ) ),
-                       array( '4:title:key', 'project:foo', array(
+                       ] ],
+                       [ '4:title:key', 'project:foo', [
                                'key_ns' => NS_PROJECT,
                                'key_title' => Title::newFromText( 'project:foo' )->getFullText(),
-                       ) ),
-                       array( '4:title-link:key', 'project:foo', array(
+                       ] ],
+                       [ '4:title-link:key', 'project:foo', [
                                'key_ns' => NS_PROJECT,
                                'key_title' => Title::newFromText( 'project:foo' )->getFullText(),
-                       ) ),
-                       array( '4:user:key', 'foo', array( 'key' => 'Foo' ) ),
-                       array( '4:user-link:key', 'foo', array( 'key' => 'Foo' ) ),
-               );
+                       ] ],
+                       [ '4:user:key', 'foo', [ 'key' => 'Foo' ] ],
+                       [ '4:user-link:key', 'foo', [ 'key' => 'Foo' ] ],
+               ];
        }
 
        /**
@@ -357,10 +357,10 @@ class LogFormatterTest extends MediaWikiLangTestCase {
                        $this->context->msg( 'blocklogentry', 'SomeTitle', 'duration', '(flags)' )->plain()
                        . $sep . $this->user_comment,
                        'block', 'block',
-                       array(
+                       [
                                '5::duration' => 'duration',
                                '6::flags' => 'flags',
-                       ),
+                       ],
                        $this->user_comment
                );
                # block/block - legacy
@@ -368,10 +368,10 @@ class LogFormatterTest extends MediaWikiLangTestCase {
                        $this->context->msg( 'blocklogentry', 'SomeTitle', 'duration', '(flags)' )->plain()
                        . $sep . $this->user_comment,
                        'block', 'block',
-                       array(
+                       [
                                'duration',
                                'flags',
-                       ),
+                       ],
                        $this->user_comment,
                        '',
                        true
@@ -380,7 +380,7 @@ class LogFormatterTest extends MediaWikiLangTestCase {
                $this->assertIRCComment(
                        $this->context->msg( 'unblocklogentry', 'SomeTitle' )->plain() . $sep . $this->user_comment,
                        'block', 'unblock',
-                       array(),
+                       [],
                        $this->user_comment
                );
                # block/reblock
@@ -388,10 +388,10 @@ class LogFormatterTest extends MediaWikiLangTestCase {
                        $this->context->msg( 'reblock-logentry', 'SomeTitle', 'duration', '(flags)' )->plain()
                        . $sep . $this->user_comment,
                        'block', 'reblock',
-                       array(
+                       [
                                '5::duration' => 'duration',
                                '6::flags' => 'flags',
-                       ),
+                       ],
                        $this->user_comment
                );
        }
@@ -407,7 +407,7 @@ class LogFormatterTest extends MediaWikiLangTestCase {
                $this->assertIRCComment(
                        $this->context->msg( 'deletedarticle', 'SomeTitle' )->plain() . $sep . $this->user_comment,
                        'delete', 'delete',
-                       array(),
+                       [],
                        $this->user_comment
                );
 
@@ -415,7 +415,7 @@ class LogFormatterTest extends MediaWikiLangTestCase {
                $this->assertIRCComment(
                        $this->context->msg( 'undeletedarticle', 'SomeTitle' )->plain() . $sep . $this->user_comment,
                        'delete', 'restore',
-                       array(),
+                       [],
                        $this->user_comment
                );
        }
@@ -428,22 +428,22 @@ class LogFormatterTest extends MediaWikiLangTestCase {
                $this->assertIRCComment(
                        'New user account',
                        'newusers', 'newusers',
-                       array()
+                       []
                );
                $this->assertIRCComment(
                        'New user account',
                        'newusers', 'create',
-                       array()
+                       []
                );
                $this->assertIRCComment(
                        'created new account SomeTitle',
                        'newusers', 'create2',
-                       array()
+                       []
                );
                $this->assertIRCComment(
                        'Account created automatically',
                        'newusers', 'autocreate',
-                       array()
+                       []
                );
        }
 
@@ -452,10 +452,10 @@ class LogFormatterTest extends MediaWikiLangTestCase {
         * @covers LogFormatter::getIRCActionText
         */
        public function testIrcMsgForLogTypeMove() {
-               $move_params = array(
+               $move_params = [
                        '4::target' => $this->target->getPrefixedText(),
                        '5::noredir' => 0,
-               );
+               ];
                $sep = $this->context->msg( 'colon-separator' )->text();
 
                # move/move
@@ -486,11 +486,11 @@ class LogFormatterTest extends MediaWikiLangTestCase {
                $this->assertIRCComment(
                        $this->context->msg( 'patrol-log-line', 'revision 777', '[[SomeTitle]]', '' )->plain(),
                        'patrol', 'patrol',
-                       array(
+                       [
                                '4::curid' => '777',
                                '5::previd' => '666',
                                '6::auto' => 0,
-                       )
+                       ]
                );
        }
 
@@ -499,9 +499,9 @@ class LogFormatterTest extends MediaWikiLangTestCase {
         * @covers LogFormatter::getIRCActionText
         */
        public function testIrcMsgForLogTypeProtect() {
-               $protectParams = array(
+               $protectParams = [
                        '4::description' => '[edit=sysop] (indefinite) ‎[move=sysop] (indefinite)'
-               );
+               ];
                $sep = $this->context->msg( 'colon-separator' )->text();
 
                # protect/protect
@@ -517,14 +517,16 @@ class LogFormatterTest extends MediaWikiLangTestCase {
                $this->assertIRCComment(
                        $this->context->msg( 'unprotectedarticle', 'SomeTitle' )->plain() . $sep . $this->user_comment,
                        'protect', 'unprotect',
-                       array(),
+                       [],
                        $this->user_comment
                );
 
                # protect/modify
                $this->assertIRCComment(
-                       $this->context->msg( 'modifiedarticleprotection', 'SomeTitle ' . $protectParams['4::description'] )
-                               ->plain() . $sep . $this->user_comment,
+                       $this->context->msg(
+                               'modifiedarticleprotection',
+                               'SomeTitle ' . $protectParams['4::description']
+                       )->plain() . $sep . $this->user_comment,
                        'protect', 'modify',
                        $protectParams,
                        $this->user_comment
@@ -535,9 +537,9 @@ class LogFormatterTest extends MediaWikiLangTestCase {
                        $this->context->msg( 'movedarticleprotection', 'SomeTitle', 'OldTitle' )
                                ->plain() . $sep . $this->user_comment,
                        'protect', 'move_prot',
-                       array(
+                       [
                                '4::oldtitle' => 'OldTitle'
-                       ),
+                       ],
                        $this->user_comment
                );
        }
@@ -553,7 +555,7 @@ class LogFormatterTest extends MediaWikiLangTestCase {
                $this->assertIRCComment(
                        $this->context->msg( 'uploadedimage', 'SomeTitle' )->plain() . $sep . $this->user_comment,
                        'upload', 'upload',
-                       array(),
+                       [],
                        $this->user_comment
                );
 
@@ -561,7 +563,7 @@ class LogFormatterTest extends MediaWikiLangTestCase {
                $this->assertIRCComment(
                        $this->context->msg( 'overwroteimage', 'SomeTitle' )->plain() . $sep . $this->user_comment,
                        'upload', 'overwrite',
-                       array(),
+                       [],
                        $this->user_comment
                );
        }
@@ -578,10 +580,10 @@ class LogFormatterTest extends MediaWikiLangTestCase {
                        $this->context->msg( 'pagemerge-logentry', 'SomeTitle', 'Dest', 'timestamp' )->plain()
                        . $sep . $this->user_comment,
                        'merge', 'merge',
-                       array(
+                       [
                                '4::dest' => 'Dest',
                                '5::mergepoint' => 'timestamp',
-                       ),
+                       ],
                        $this->user_comment
                );
        }
@@ -600,7 +602,7 @@ class LogFormatterTest extends MediaWikiLangTestCase {
                $this->assertIRCComment(
                        $msg,
                        'import', 'upload',
-                       array(),
+                       [],
                        $this->user_comment
                );
 
@@ -611,7 +613,7 @@ class LogFormatterTest extends MediaWikiLangTestCase {
                $this->assertIRCComment(
                        $msg,
                        'import', 'interwiki',
-                       array(),
+                       [],
                        $this->user_comment
                );
        }