*/
public function testNewInstance() {
$config = GlobalVarConfig::newInstance();
- $this->assertInstanceOf( 'GlobalVarConfig', $config );
- $this->maybeStashGlobal( 'wgBaz' );
- $GLOBALS['wgBaz'] = 'somevalue';
+ $this->assertInstanceOf( GlobalVarConfig::class, $config );
+ $this->setMwGlobals( 'wgBaz', 'somevalue' );
// Check prefix is set to 'wg'
$this->assertEquals( 'somevalue', $config->get( 'Baz' ) );
}
*/
public function testConstructor( $prefix ) {
$var = $prefix . 'GlobalVarConfigTest';
- $rand = wfRandomString();
- $this->maybeStashGlobal( $var );
- $GLOBALS[$var] = $rand;
+ $this->setMwGlobals( $var, 'testvalue' );
$config = new GlobalVarConfig( $prefix );
- $this->assertInstanceOf( 'GlobalVarConfig', $config );
- $this->assertEquals( $rand, $config->get( 'GlobalVarConfigTest' ) );
+ $this->assertInstanceOf( GlobalVarConfig::class, $config );
+ $this->assertEquals( 'testvalue', $config->get( 'GlobalVarConfigTest' ) );
}
public static function provideConstructor() {
* @covers GlobalVarConfig::hasWithPrefix
*/
public function testHas() {
- $this->maybeStashGlobal( 'wgGlobalVarConfigTestHas' );
- $GLOBALS['wgGlobalVarConfigTestHas'] = wfRandomString();
- $this->maybeStashGlobal( 'wgGlobalVarConfigTestNotHas' );
+ $this->setMwGlobals( 'wgGlobalVarConfigTestHas', 'testvalue' );
$config = new GlobalVarConfig();
$this->assertTrue( $config->has( 'GlobalVarConfigTestHas' ) );
$this->assertFalse( $config->has( 'GlobalVarConfigTestNotHas' ) );
public function testGet( $name, $prefix, $expected ) {
$config = new GlobalVarConfig( $prefix );
if ( $expected === false ) {
- $this->setExpectedException( 'ConfigException', 'GlobalVarConfig::get: undefined option:' );
+ $this->setExpectedException( ConfigException::class, 'GlobalVarConfig::get: undefined option:' );
}
$this->assertEquals( $config->get( $name ), $expected );
}
-
- private function maybeStashGlobal( $var ) {
- if ( array_key_exists( $var, $GLOBALS ) ) {
- // Will be reset after this test is over
- $this->stashMwGlobals( $var );
- }
- }
}