<?php
+use Wikimedia\TestingAccessWrapper;
+
/**
* @covers ChangesListStringOptionsFilterGroup
*/
[
'name' => 'foo',
],
- [
- 'name' => 'bar',
- 'isAllowedCallable' => function () {
- return false;
- },
- ],
[
'name' => 'baz',
],
}
public function provideNoOpModifyQuery() {
- $isAllowedFalse = [
- 'isAllowedCallable' => function () {
- return false;
- },
- ];
-
- $allDisallowedFilters = [
- [
- 'name' => 'disallowed1',
- ] + $isAllowedFalse,
-
- [
- 'name' => 'disallowed2',
- ] + $isAllowedFalse,
-
- [
- 'name' => 'disallowed3',
- ] + $isAllowedFalse,
- ];
+ $noFilters = [];
$normalFilters = [
[
return [
[
- $allDisallowedFilters,
+ $noFilters,
'disallowed1;disallowed3',
- 'The queryCallable should not be called if no filters are allowed',
+ 'The queryCallable should not be called if there are no filters',
],
[
* @dataProvider provideModifyQuery
*/
protected function modifyQueryHelper( $groupDefinition, $input ) {
- $ctx = $this->getMock( 'IContextSource' );
- $dbr = $this->getMock( 'IDatabase' );
+ $ctx = $this->createMock( 'IContextSource' );
+ $dbr = $this->createMock( 'IDatabase' );
$tables = $fields = $conds = $query_options = $join_conds = [];
$group = new ChangesListStringOptionsFilterGroup( $groupDefinition );
$group = new ChangesListStringOptionsFilterGroup( $definition );
- $specialPage = $this->getSpecialPage();
-
$this->assertArrayEquals(
[
'name' => 'some-group',
'foo-description',
],
],
- $group->getJsData( $specialPage ),
+ $group->getJsData(),
/** ordered= */ false,
/** named= */ true
);