* @group WebRequest
*/
class WebRequestTest extends MediaWikiTestCase {
- protected $oldServer;
protected function setUp() {
parent::setUp();
$this->oldServer = $_SERVER;
+ $this->oldWgRequest = $GLOBALS['wgRequest'];
+ $this->oldWgServer = $GLOBALS['wgServer'];
}
protected function tearDown() {
$_SERVER = $this->oldServer;
+ $GLOBALS['wgRequest'] = $this->oldWgRequest;
+ $GLOBALS['wgServer'] = $this->oldWgServer;
parent::tearDown();
}
];
}
- protected function mockWebRequest( $data = [] ) {
+ /**
+ * @param array $data Request data
+ * @param array $config
+ * - float 'requestTime': Mock value for `$_SERVER['REQUEST_TIME_FLOAT']`.
+ * @return WebRequest
+ */
+ protected function mockWebRequest( array $data = [], array $config = [] ) {
// Cannot use PHPUnit getMockBuilder() as it does not support
// overriding protected properties afterwards
$reflection = new ReflectionClass( WebRequest::class );
$prop->setAccessible( true );
$prop->setValue( $req, $data );
- $prop = $reflection->getProperty( 'requestTime' );
- $prop->setAccessible( true );
- $prop->setValue( $req, microtime( true ) );
+ if ( isset( $config['requestTime'] ) ) {
+ $prop = $reflection->getProperty( 'requestTime' );
+ $prop->setAccessible( true );
+ $prop->setValue( $req, $config['requestTime'] );
+ }
return $req;
}
* @covers WebRequest::getElapsedTime
*/
public function testGetElapsedTime() {
- $req = $this->mockWebRequest();
- $this->assertGreaterThanOrEqual( 0.0, $req->getElapsedTime() );
- $this->assertEquals( 0.0, $req->getElapsedTime(), '', /*delta*/ 0.2 );
+ $now = microtime( true ) - 10.0;
+ $req = $this->mockWebRequest( [], [ 'requestTime' => $now ] );
+ $this->assertGreaterThanOrEqual( 10.0, $req->getElapsedTime() );
+ // Catch common errors, but don't fail on slow hardware or VMs (T199764).
+ $this->assertEquals( 10.0, $req->getElapsedTime(), '', 60.0 );
}
/**
$this->assertSame( [ 'x' ], $req->getValueNames( [ 'y' ] ), 'Exclude keys' );
}
+ /**
+ * @covers WebRequest
+ */
+ public function testGetFullRequestURL() {
+ // Stub this for wfGetServerUrl()
+ $GLOBALS['wgServer'] = '//wiki.test';
+ $req = $this->getMock( WebRequest::class, [ 'getRequestURL', 'getProtocol' ] );
+ $req->method( 'getRequestURL' )->willReturn( '/path' );
+ $req->method( 'getProtocol' )->willReturn( 'https' );
+
+ $this->assertSame(
+ 'https://wiki.test/path',
+ $req->getFullRequestURL()
+ );
+ }
+
/**
* @dataProvider provideGetIP
* @covers WebRequest::getIP