Merge "ApiSetNotificationTimestamp: Make entirewatchlist more efficient"

[lhc/web/wiklou.git] / tests / phpunit / includes / Revision / RevisionStoreDbTestBase.php

diff --git a/tests/phpunit/includes/Revision/RevisionStoreDbTestBase.php b/tests/phpunit/includes/Revision/RevisionStoreDbTestBase.php
index 0d6a439..68632f3 100644 (file)
--- a/tests/phpunit/includes/Revision/RevisionStoreDbTestBase.php
+++ b/tests/phpunit/includes/Revision/RevisionStoreDbTestBase.php
@@ -12,7 +12,9 @@ use MediaWiki\Linker\LinkTarget;
 use MediaWiki\MediaWikiServices;
 use MediaWiki\Revision\IncompleteRevisionException;
 use MediaWiki\Revision\MutableRevisionRecord;
+use MediaWiki\Revision\RevisionArchiveRecord;
 use MediaWiki\Revision\RevisionRecord;
+use MediaWiki\Revision\RevisionSlots;
 use MediaWiki\Revision\RevisionStore;
 use MediaWiki\Revision\SlotRecord;
 use MediaWiki\Storage\BlobStoreFactory;
@@ -78,7 +80,7 @@ abstract class RevisionStoreDbTestBase extends MediaWikiTestCase {
                $this->setMwGlobals( [
                        'wgMultiContentRevisionSchemaMigrationStage' => $this->getMcrMigrationStage(),
                        'wgContentHandlerUseDB' => $this->getContentHandlerUseDB(),
-                       'wgCommentTableSchemaMigrationStage' => MIGRATION_OLD,
+                       'wgCommentTableSchemaMigrationStage' => MIGRATION_NEW,
                        'wgActorTableSchemaMigrationStage' => SCHEMA_COMPAT_OLD,
                ] );
 
@@ -100,6 +102,7 @@ abstract class RevisionStoreDbTestBase extends MediaWikiTestCase {
                $this->testPageTitle = Title::newFromText( 'UTPage-' . __CLASS__ );
                return $this->testPageTitle;
        }
+
        /**
         * @return WikiPage
         */
@@ -231,6 +234,7 @@ abstract class RevisionStoreDbTestBase extends MediaWikiTestCase {
                        MediaWikiServices::getInstance()->getCommentStore(),
                        MediaWikiServices::getInstance()->getContentModelStore(),
                        MediaWikiServices::getInstance()->getSlotRoleStore(),
+                       MediaWikiServices::getInstance()->getSlotRoleRegistry(),
                        $this->getMcrMigrationStage(),
                        MediaWikiServices::getInstance()->getActorMigration(),
                        $wikiId
@@ -1354,6 +1358,44 @@ abstract class RevisionStoreDbTestBase extends MediaWikiTestCase {
                );
        }
 
+       public function provideNonHistoryRevision() {
+               $title = Title::newFromText( __METHOD__ );
+               $rev = new MutableRevisionRecord( $title );
+               yield [ $rev ];
+
+               $user = new UserIdentityValue( 7, 'Frank', 0 );
+               $comment = CommentStoreComment::newUnsavedComment( 'Test' );
+               $row = (object)[
+                       'ar_id' => 3,
+                       'ar_rev_id' => 34567,
+                       'ar_page_id' => 5,
+                       'ar_deleted' => 0,
+                       'ar_minor_edit' => 0,
+                       'ar_timestamp' => '20180101020202',
+               ];
+               $slots = new RevisionSlots( [] );
+               $rev = new RevisionArchiveRecord( $title, $user, $comment, $row, $slots );
+               yield [ $rev ];
+       }
+
+       /**
+        * @dataProvider provideNonHistoryRevision
+        * @covers \MediaWiki\Revision\RevisionStore::getPreviousRevision
+        */
+       public function testGetPreviousRevision_bad( RevisionRecord $rev ) {
+               $store = MediaWikiServices::getInstance()->getRevisionStore();
+               $this->assertNull( $store->getPreviousRevision( $rev ) );
+       }
+
+       /**
+        * @dataProvider provideNonHistoryRevision
+        * @covers \MediaWiki\Revision\RevisionStore::getNextRevision
+        */
+       public function testGetNextRevision_bad( RevisionRecord $rev ) {
+               $store = MediaWikiServices::getInstance()->getRevisionStore();
+               $this->assertNull( $store->getNextRevision( $rev ) );
+       }
+
        /**
         * @covers \MediaWiki\Revision\RevisionStore::getTimestampFromId
         */