Merge "mediawiki.util: Remove outdated comment from unit test"

[lhc/web/wiklou.git] / maintenance / validateRegistrationFile.php

diff --git a/maintenance/validateRegistrationFile.php b/maintenance/validateRegistrationFile.php
index e764661..9cf7b2b 100644 (file)
--- a/maintenance/validateRegistrationFile.php
+++ b/maintenance/validateRegistrationFile.php
@@ -12,18 +12,39 @@ class ValidateRegistrationFile extends Maintenance {
                        $this->error( 'The JsonSchema library cannot be found, please install it through composer.', 1 );
                }
 
-               $retriever = new JsonSchema\Uri\UriRetriever();
-               $schema = $retriever->retrieve('file://' . dirname( __DIR__ ) . '/docs/extension.schema.json' );
                $path = $this->getArg( 0 );
                $data = json_decode( file_get_contents( $path ) );
                if ( !is_object( $data ) ) {
                        $this->error( "$path is not a valid JSON file.", 1 );
                }
+               if ( !isset( $data->manifest_version ) ) {
+                       $this->output( "Warning: No manifest_version set, assuming 1.\n" );
+                       // For backwards-compatability assume 1
+                       $data->manifest_version = 1;
+               }
+               $version = $data->manifest_version;
+               if ( $version !== ExtensionRegistry::MANIFEST_VERSION ) {
+                       $schemaPath = dirname( __DIR__ ) . "/docs/extension.schema.v$version.json";
+               } else {
+                       $schemaPath = dirname( __DIR__ ) . '/docs/extension.schema.json';
+               }
+
+               if ( $version < ExtensionRegistry::OLDEST_MANIFEST_VERSION
+                       || $version > ExtensionRegistry::MANIFEST_VERSION
+               ) {
+                       $this->error( "Error: $path is using a non-supported schema version, it should use "
+                               . ExtensionRegistry::MANIFEST_VERSION, 1 );
+               } elseif ( $version < ExtensionRegistry::MANIFEST_VERSION ) {
+                       $this->output( "Warning: $path is using a deprecated schema, and should be updated to "
+                               . ExtensionRegistry::MANIFEST_VERSION . "\n" );
+               }
+               $retriever = new JsonSchema\Uri\UriRetriever();
+               $schema = $retriever->retrieve( 'file://' . $schemaPath );
 
                $validator = new JsonSchema\Validator();
                $validator->check( $data, $schema );
                if ( $validator->isValid() ) {
-                       $this->output( "$path validates against the schema!\n" );
+                       $this->output( "$path validates against the version $version schema!\n" );
                } else {
                        foreach ( $validator->getErrors() as $error ) {
                                $this->output( "[{$error['property']}] {$error['message']}\n" );