Improve OutputPage::showErrorPage method documentation

[lhc/web/wiklou.git] / maintenance / update.php

diff --git a/maintenance/update.php b/maintenance/update.php
index e01406d..85364ee 100644 (file)
--- a/maintenance/update.php
+++ b/maintenance/update.php
@@ -57,25 +57,27 @@ class UpdateMediaWiki extends Maintenance {
        }
 
        function compatChecks() {
-               $test = new PhpXmlBugTester();
-               if ( !$test->ok ) {
+               // Avoid syntax error in PHP4
+               $minimumPcreVersion = constant( 'Installer::MINIMUM_PCRE_VERSION' );
+
+               list( $pcreVersion ) = explode( ' ', PCRE_VERSION, 2 );
+               if ( version_compare( $pcreVersion, $minimumPcreVersion, '<' ) ) {
                        $this->error(
-                               "Your system has a combination of PHP and libxml2 versions which is buggy\n" .
-                               "and can cause hidden data corruption in MediaWiki and other web apps.\n" .
-                               "Upgrade to PHP 5.2.9 or later and libxml2 2.7.3 or later!\n" .
-                               "ABORTING (see http://bugs.php.net/bug.php?id=45996).\n",
+                               "PCRE $minimumPcreVersion or later is required.\n" .
+                               "Your PHP binary is linked with PCRE $pcreVersion.\n\n" .
+                               "More information:\n" .
+                               "https://www.mediawiki.org/wiki/Manual:Errors_and_symptoms/PCRE\n\n" .
+                               "ABORTING.\n",
                                true );
                }
 
-               $test = new PhpRefCallBugTester;
-               $test->execute();
+               $test = new PhpXmlBugTester();
                if ( !$test->ok ) {
-                       $ver = phpversion();
                        $this->error(
-                               "PHP $ver is not compatible with MediaWiki due to a bug involving\n" .
-                               "reference parameters to __call. Upgrade to PHP 5.3.2 or higher, or \n" .
-                               "downgrade to PHP 5.3.0 to fix this.\n" .
-                               "ABORTING (see http://bugs.php.net/bug.php?id=50394 for details)\n",
+                               "Your system has a combination of PHP and libxml2 versions that is buggy\n" .
+                               "and can cause hidden data corruption in MediaWiki and other web apps.\n" .
+                               "Upgrade to libxml2 2.7.3 or later.\n" .
+                               "ABORTING (see https://bugs.php.net/bug.php?id=45996).\n",
                                true );
                }
        }
@@ -170,8 +172,8 @@ class UpdateMediaWiki extends Maintenance {
                }
                $time2 = new MWTimestamp();
 
-               $this->output( "\nDone.\n" );
-               $this->output( "\nThe job took " . $time2->diff( $time1 )->format( "%i:%S" ) . ".\n" );
+               $timeDiff = $time2->diff( $time1 );
+               $this->output( "\nDone in " . $timeDiff->format( "%i:%S" ) . ".\n" );
        }
 
        function afterFinalSetup() {