* Will throw exceptions on SQL errors
* @param array|string $files
* @throws MWException
- * @return string|bool true if no error or error string in case of errors
+ * @return bool True if no error or error string in case of errors
*/
public static function checkSqlSyntax( $files ) {
if ( !Sqlite::isPresent() ) {
throw new MWException( "Can't check SQL syntax: SQLite not found" );
}
if ( !is_array( $files ) ) {
- $files = array( $files );
+ $files = [ $files ];
}
- $allowedTypes = array_flip( array(
+ $allowedTypes = array_flip( [
'integer',
'real',
'text',
'blob', // NULL type is omitted intentionally
- ) );
+ ] );
- $db = new DatabaseSqliteStandalone( ':memory:' );
+ $db = DatabaseSqlite::newStandaloneInstance( ':memory:' );
try {
foreach ( $files as $file ) {
$err = $db->sourceFile( $file );
foreach ( $columns as $col ) {
if ( !isset( $allowedTypes[strtolower( $col->type )] ) ) {
$db->close();
+
return "Table {$table->name} has column {$col->name} with non-native type '{$col->type}'";
}
}
return $e->getMessage();
}
$db->close();
+
return true;
}
-};
+}