No space within the ?: operator

[lhc/web/wiklou.git] / maintenance / sql.php

diff --git a/maintenance/sql.php b/maintenance/sql.php
index 5cad5a7..afa3ef7 100644 (file)
--- a/maintenance/sql.php
+++ b/maintenance/sql.php
@@ -53,7 +53,8 @@ class MwSql extends Maintenance {
                                $index = DB_SLAVE;
                        } else {
                                $index = null;
-                               for ( $i = 0; $i < $lb->getServerCount(); ++$i ) {
+                               $serverCount = $lb->getServerCount();
+                               for ( $i = 0; $i < $serverCount; ++$i ) {
                                        if ( $lb->getServerName( $i ) === $server ) {
                                                $index = $i;
                                                break;
@@ -87,12 +88,12 @@ class MwSql extends Maintenance {
                }
 
                $useReadline = function_exists( 'readline_add_history' )
-                               && Maintenance::posix_isatty( 0 /*STDIN*/ );
+                       && Maintenance::posix_isatty( 0 /*STDIN*/ );
 
                if ( $useReadline ) {
                        global $IP;
                        $historyFile = isset( $_ENV['HOME'] ) ?
-                                       "{$_ENV['HOME']}/.mwsql_history" : "$IP/maintenance/.mwsql_history";
+                               "{$_ENV['HOME']}/.mwsql_history" : "$IP/maintenance/.mwsql_history";
                        readline_read_history( $historyFile );
                }
 
@@ -125,7 +126,7 @@ class MwSql extends Maintenance {
                                $prompt = $newPrompt;
                                $wholeLine = '';
                        } catch ( DBQueryError $e ) {
-                               $doDie = ! Maintenance::posix_isatty( 0 );
+                               $doDie = !Maintenance::posix_isatty( 0 );
                                $this->error( $e, $doDie );
                        }
                }
@@ -134,8 +135,8 @@ class MwSql extends Maintenance {
 
        /**
         * Print the results, callback for $db->sourceStream()
-        * @param $res ResultWrapper The results object
-        * @param $db DatabaseBase object
+        * @param ResultWrapper $res The results object
+        * @param DatabaseBase $db
         */
        public function sqlPrintResult( $res, $db ) {
                if ( !$res ) {