<?php
-/*
- * Makes the required database updates for rev_len
- * to be of any use. It can be used for some simple tracking
- * and to find new page edits by users.
+/**
+ * Populates the rev_len field for old revisions created before MW 1.10.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* @ingroup Maintenance
*/
-require_once( dirname(__FILE__) . '/Maintenance.php' );
+require_once( dirname( __FILE__ ) . '/Maintenance.php' );
-class PopulateRevisionLength extends Maintenance {
+class PopulateRevisionLength extends LoggedUpdateMaintenance {
public function __construct() {
parent::__construct();
- $this->mDescription = "Populates rev_len";
+ $this->mDescription = "Populates the rev_len field";
$this->setBatchSize( 200 );
}
- public function execute() {
- $db = wfGetDB( DB_MASTER );
+ protected function getUpdateKey() {
+ return 'populate rev_len';
+ }
+
+ protected function updateSkippedMessage() {
+ return 'rev_len column of revision table already populated.';
+ }
+
+ public function doDBUpdates() {
+ $db = $this->getDB( DB_MASTER );
if ( !$db->tableExists( 'revision' ) ) {
$this->error( "revision table does not exist", true );
}
$this->output( "Populating rev_len column\n" );
- $start = $db->selectField( 'revision', 'MIN(rev_id)', false, __FUNCTION__ );
- $end = $db->selectField( 'revision', 'MAX(rev_id)', false, __FUNCTION__ );
- if( is_null( $start ) || is_null( $end ) ){
+
+ $start = $db->selectField( 'revision', 'MIN(rev_id)', false, __METHOD__ );
+ $end = $db->selectField( 'revision', 'MAX(rev_id)', false, __METHOD__ );
+ if ( !$start || !$end ) {
$this->output( "...revision table seems to be empty.\n" );
- $db->insert( 'updatelog',
- array( 'ul_key' => 'populate rev_len' ),
- __METHOD__,
- 'IGNORE' );
- return;
+ return true;
}
+
# Do remaining chunks
$blockStart = intval( $start );
$blockEnd = intval( $start ) + $this->mBatchSize - 1;
$count = 0;
- while( $blockStart <= $end ) {
+ $missing = 0;
+ while ( $blockStart <= $end ) {
$this->output( "...doing rev_id from $blockStart to $blockEnd\n" );
$res = $db->select( 'revision',
- Revision::selectFields(),
- array( "rev_id >= $blockStart",
+ Revision::selectFields(),
+ array( "rev_id >= $blockStart",
"rev_id <= $blockEnd",
"rev_len IS NULL" ),
- __METHOD__ );
+ __METHOD__ );
# Go through and update rev_len from these rows.
- foreach( $res as $row ) {
+ foreach ( $res as $row ) {
$rev = new Revision( $row );
$text = $rev->getRawText();
- # Update the row...
- $db->update( 'revision',
- array( 'rev_len' => strlen( $text ) ),
- array( 'rev_id' => $row->rev_id ),
- __METHOD__ );
- $count++;
+ if ( !is_string( $text ) ) {
+ # This should not happen, but sometimes does (bug 20757)
+ $this->output( "Text of revision {$row->rev_id} unavailable!\n" );
+ $missing++;
+ }
+ else {
+ # Update the row...
+ $db->update( 'revision',
+ array( 'rev_len' => strlen( $text ) ),
+ array( 'rev_id' => $row->rev_id ),
+ __METHOD__ );
+ $count++;
+ }
}
$blockStart += $this->mBatchSize;
$blockEnd += $this->mBatchSize;
- wfWaitForSlaves( 5 );
- }
- $logged = $db->insert( 'updatelog',
- array( 'ul_key' => 'populate rev_len' ),
- __METHOD__,
- 'IGNORE' );
- if( $logged ) {
- $this->output( "rev_len population complete ... {$count} rows changed\n" );
- return true;
- } else {
- $this->output( "Could not insert rev_len population row.\n" );
- return false;
+ wfWaitForSlaves();
}
+
+ $this->output( "rev_len population complete ... {$count} rows changed ({$missing} missing)\n" );
+ return true;
}
}
$maintClass = "PopulateRevisionLength";
-require_once( DO_MAINTENANCE );
+require_once( RUN_MAINTENANCE_IF_MAIN );