Merge "rm unused $egWBRemoteTitleNormalization var from MediaWikiSite.php"

[lhc/web/wiklou.git] / maintenance / populateParentId.php

diff --git a/maintenance/populateParentId.php b/maintenance/populateParentId.php
index 45255b0..e81d4ff 100644 (file)
--- a/maintenance/populateParentId.php
+++ b/maintenance/populateParentId.php
@@ -1,5 +1,5 @@
 <?php
-/*
+/**
  * Makes the required database updates for rev_parent_id
  * to be of any use. It can be used for some simple tracking
  * and to find new page edits by users.
@@ -19,33 +19,44 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  * http://www.gnu.org/copyleft/gpl.html
  *
+ * @file
  * @ingroup Maintenance
  */
 
-require_once( dirname( __FILE__ ) . '/Maintenance.php' );
+require_once( __DIR__ . '/Maintenance.php' );
 
-class PopulateParentId extends Maintenance {
+/**
+ * Maintenance script that makes the required database updates for rev_parent_id
+ * to be of any use.
+ *
+ * @ingroup Maintenance
+ */
+class PopulateParentId extends LoggedUpdateMaintenance {
        public function __construct() {
                parent::__construct();
                $this->mDescription = "Populates rev_parent_id";
-               $this->setBatchSize( 200 );
        }
 
-       public function execute() {
+       protected function getUpdateKey() {
+               return 'populate rev_parent_id';
+       }
+
+       protected function updateSkippedMessage() {
+               return 'rev_parent_id column of revision table already populated.';
+       }
+
+       protected function doDBUpdates() {
                $db = wfGetDB( DB_MASTER );
                if ( !$db->tableExists( 'revision' ) ) {
-                       $this->error( "revision table does not exist", true );
+                       $this->error( "revision table does not exist" );
+                       return false;
                }
                $this->output( "Populating rev_parent_id column\n" );
                $start = $db->selectField( 'revision', 'MIN(rev_id)', false, __FUNCTION__ );
                $end = $db->selectField( 'revision', 'MAX(rev_id)', false, __FUNCTION__ );
                if ( is_null( $start ) || is_null( $end ) ) {
-                       $this->output( "...revision table seems to be empty.\n" );
-                       $db->insert( 'updatelog',
-                               array( 'ul_key' => 'populate rev_parent_id' ),
-                               __METHOD__,
-                               'IGNORE' );
-                       return;
+                       $this->output( "...revision table seems to be empty, nothing to do.\n" );
+                       return true;
                }
                # Do remaining chunk
                $blockStart = intval( $start );
@@ -57,7 +68,7 @@ class PopulateParentId extends Maintenance {
                        $cond = "rev_id BETWEEN $blockStart AND $blockEnd";
                        $res = $db->select( 'revision',
                                array( 'rev_id', 'rev_page', 'rev_timestamp', 'rev_parent_id' ),
-                               $cond, __METHOD__ );
+                               array( $cond, 'rev_parent_id' => null ), __METHOD__ );
                        # Go through and update rev_parent_id from these rows.
                        # Assume that the previous revision of the title was
                        # the original previous revision of the title when the
@@ -98,21 +109,12 @@ class PopulateParentId extends Maintenance {
                        }
                        $blockStart += $this->mBatchSize;
                        $blockEnd += $this->mBatchSize;
-                       wfWaitForSlaves( 5 );
-               }
-               $logged = $db->insert( 'updatelog',
-                       array( 'ul_key' => 'populate rev_parent_id' ),
-                       __METHOD__,
-                       'IGNORE' );
-               if ( $logged ) {
-                       $this->output( "rev_parent_id population complete ... {$count} rows [{$changed} changed]\n" );
-                       return true;
-               } else {
-                       $this->output( "Could not insert rev_parent_id population row.\n" );
-                       return false;
+                       wfWaitForSlaves();
                }
+               $this->output( "rev_parent_id population complete ... {$count} rows [{$changed} changed]\n" );
+               return true;
        }
 }
 
 $maintClass = "PopulateParentId";
-require_once( DO_MAINTENANCE );
+require_once( RUN_MAINTENANCE_IF_MAIN );