resources: Deprecate the 'jquery.badge' module

[lhc/web/wiklou.git] / maintenance / populateParentId.php

diff --git a/maintenance/populateParentId.php b/maintenance/populateParentId.php
index 950a282..457033a 100644 (file)
--- a/maintenance/populateParentId.php
+++ b/maintenance/populateParentId.php
@@ -23,7 +23,7 @@
  * @ingroup Maintenance
  */
 
-require_once( __DIR__ . '/Maintenance.php' );
+require_once __DIR__ . '/Maintenance.php';
 
 /**
  * Maintenance script that makes the required database updates for rev_parent_id
@@ -34,7 +34,7 @@ require_once( __DIR__ . '/Maintenance.php' );
 class PopulateParentId extends LoggedUpdateMaintenance {
        public function __construct() {
                parent::__construct();
-               $this->mDescription = "Populates rev_parent_id";
+               $this->addDescription( 'Populates rev_parent_id' );
        }
 
        protected function getUpdateKey() {
@@ -46,9 +46,10 @@ class PopulateParentId extends LoggedUpdateMaintenance {
        }
 
        protected function doDBUpdates() {
-               $db = wfGetDB( DB_MASTER );
+               $db = $this->getDB( DB_MASTER );
                if ( !$db->tableExists( 'revision' ) ) {
                        $this->error( "revision table does not exist" );
+
                        return false;
                }
                $this->output( "Populating rev_parent_id column\n" );
@@ -56,6 +57,7 @@ class PopulateParentId extends LoggedUpdateMaintenance {
                $end = $db->selectField( 'revision', 'MAX(rev_id)', false, __FUNCTION__ );
                if ( is_null( $start ) || is_null( $end ) ) {
                        $this->output( "...revision table seems to be empty, nothing to do.\n" );
+
                        return true;
                }
                # Do remaining chunk
@@ -67,8 +69,8 @@ class PopulateParentId extends LoggedUpdateMaintenance {
                        $this->output( "...doing rev_id from $blockStart to $blockEnd\n" );
                        $cond = "rev_id BETWEEN $blockStart AND $blockEnd";
                        $res = $db->select( 'revision',
-                               array( 'rev_id', 'rev_page', 'rev_timestamp', 'rev_parent_id' ),
-                               array( $cond, 'rev_parent_id' => null ), __METHOD__ );
+                               [ 'rev_id', 'rev_page', 'rev_timestamp', 'rev_parent_id' ],
+                               [ $cond, 'rev_parent_id' => null ], __METHOD__ );
                        # Go through and update rev_parent_id from these rows.
                        # Assume that the previous revision of the title was
                        # the original previous revision of the title when the
@@ -78,23 +80,29 @@ class PopulateParentId extends LoggedUpdateMaintenance {
                                # with a smaller rev ID. The highest ID "wins". This avoids loops
                                # as timestamp can only decrease and never loops with IDs (from parent to parent)
                                $previousID = $db->selectField( 'revision', 'rev_id',
-                                       array( 'rev_page' => $row->rev_page, 'rev_timestamp' => $row->rev_timestamp,
-                                               "rev_id < " . intval( $row->rev_id ) ),
+                                       [ 'rev_page' => $row->rev_page, 'rev_timestamp' => $row->rev_timestamp,
+                                               "rev_id < " . intval( $row->rev_id ) ],
                                        __METHOD__,
-                                       array( 'ORDER BY' => 'rev_id DESC' ) );
-                               # If there are none, check the the highest ID with a lower timestamp
+                                       [ 'ORDER BY' => 'rev_id DESC' ] );
+                               # If there are none, check the highest ID with a lower timestamp
                                if ( !$previousID ) {
                                        # Get the highest older timestamp
-                                       $lastTimestamp = $db->selectField( 'revision', 'rev_timestamp',
-                                               array( 'rev_page' => $row->rev_page, "rev_timestamp < " . $db->addQuotes( $row->rev_timestamp ) ),
+                                       $lastTimestamp = $db->selectField(
+                                               'revision',
+                                               'rev_timestamp',
+                                               [
+                                                       'rev_page' => $row->rev_page,
+                                                       "rev_timestamp < " . $db->addQuotes( $row->rev_timestamp )
+                                               ],
                                                __METHOD__,
-                                               array( 'ORDER BY' => 'rev_timestamp DESC' ) );
+                                               [ 'ORDER BY' => 'rev_timestamp DESC' ]
+                                       );
                                        # If there is one, let the highest rev ID win
                                        if ( $lastTimestamp ) {
                                                $previousID = $db->selectField( 'revision', 'rev_id',
-                                                       array( 'rev_page' => $row->rev_page, 'rev_timestamp' => $lastTimestamp ),
+                                                       [ 'rev_page' => $row->rev_page, 'rev_timestamp' => $lastTimestamp ],
                                                        __METHOD__,
-                                                       array( 'ORDER BY' => 'rev_id DESC' ) );
+                                                       [ 'ORDER BY' => 'rev_id DESC' ] );
                                        }
                                }
                                $previousID = intval( $previousID );
@@ -103,8 +111,8 @@ class PopulateParentId extends LoggedUpdateMaintenance {
                                }
                                # Update the row...
                                $db->update( 'revision',
-                                       array( 'rev_parent_id' => $previousID ),
-                                       array( 'rev_id' => $row->rev_id ),
+                                       [ 'rev_parent_id' => $previousID ],
+                                       [ 'rev_id' => $row->rev_id ],
                                        __METHOD__ );
                                $count++;
                        }
@@ -113,6 +121,7 @@ class PopulateParentId extends LoggedUpdateMaintenance {
                        wfWaitForSlaves();
                }
                $this->output( "rev_parent_id population complete ... {$count} rows [{$changed} changed]\n" );
+
                return true;
        }
 }