Fix syntax error from r55287
[lhc/web/wiklou.git] / maintenance / parserTests.inc
index e08a5d2..ab05cca 100644 (file)
 /**
  * @todo Make this more independent of the configuration (and if possible the database)
  * @todo document
- * @addtogroup Maintenance
+ * @file
+ * @ingroup Maintenance
  */
 
 /** */
-$options = array( 'quick', 'color', 'quiet', 'help', 'show-output', 'record' );
-$optionsWithArgs = array( 'regex' );
+$options = array( 'quick', 'color', 'quiet', 'help', 'show-output', 'record'. 'run-disabled' );
+$optionsWithArgs = array( 'regex', 'seed', 'setversion' );
 
-require_once( 'commandLine.inc' );
+require_once( dirname(__FILE__) . '/commandLine.inc' );
 require_once( "$IP/maintenance/parserTestsParserHook.php" );
 require_once( "$IP/maintenance/parserTestsStaticParserHook.php" );
 require_once( "$IP/maintenance/parserTestsParserTime.php" );
 
 /**
- * @addtogroup Maintenance
+ * @ingroup Maintenance
  */
 class ParserTest {
        /**
@@ -46,6 +47,25 @@ class ParserTest {
         */
        private $showOutput;
 
+       /**
+        * boolean $useTemporaryTables Use temporary tables for the temporary database
+        */
+       private $useTemporaryTables = true;
+
+       /**
+        * boolean $databaseSetupDone True if the database has been set up
+        */
+       private $databaseSetupDone = false;
+
+       /**
+        * string $oldTablePrefix Original table prefix
+        */
+       private $oldTablePrefix;
+
+       private $maxFuzzTestLength = 300;
+       private $fuzzSeed = 0;
+       private $memoryLimit = 50;
+
        /**
         * Sets terminal colorization and diff/quick modes depending on OS and
         * command-line options (--color and --quick).
@@ -82,6 +102,10 @@ class ParserTest {
 
 
                if (isset($options['regex'])) {
+                       if ( isset( $options['record'] ) ) {
+                               echo "Warning: --record cannot be used with --regex, disabling --record\n";
+                               unset( $options['record'] );
+                       }
                        $this->regex = $options['regex'];
                } else {
                        # Matches anything
@@ -89,14 +113,22 @@ class ParserTest {
                }
 
                if( isset( $options['record'] ) ) {
-                       $this->recorder = new DbTestRecorder( $this->term );
+                       $this->recorder = new DbTestRecorder( $this );
                } elseif( isset( $options['compare'] ) ) {
-                       $this->recorder = new DbTestPreviewer( $this->term );
+                       $this->recorder = new DbTestPreviewer( $this );
+               } elseif( isset( $options['upload'] ) ) {
+                       $this->recorder = new RemoteTestRecorder( $this );
                } else {
-                       $this->recorder = new TestRecorder( $this->term );
+                       $this->recorder = new TestRecorder( $this );
                }
                $this->keepUploads = isset( $options['keep-uploads'] );
 
+               if ( isset( $options['seed'] ) ) {
+                       $this->fuzzSeed = intval( $options['seed'] ) - 1;
+               }
+
+               $this->runDisabled = isset( $options['run-disabled'] );
+
                $this->hooks = array();
                $this->functionHooks = array();
        }
@@ -113,6 +145,119 @@ class ParserTest {
                }
        }
 
+       /**
+        * Run a fuzz test series
+        * Draw input from a set of test files
+        */
+       function fuzzTest( $filenames ) {
+               $dict = $this->getFuzzInput( $filenames );
+               $dictSize = strlen( $dict );
+               $logMaxLength = log( $this->maxFuzzTestLength );
+               $this->setupDatabase();
+               ini_set( 'memory_limit', $this->memoryLimit * 1048576 );
+
+               $numTotal = 0;
+               $numSuccess = 0;
+               $user = new User;
+               $opts = ParserOptions::newFromUser( $user );
+               $title = Title::makeTitle( NS_MAIN, 'Parser_test' );
+
+               while ( true ) {
+                       // Generate test input
+                       mt_srand( ++$this->fuzzSeed );
+                       $totalLength = mt_rand( 1, $this->maxFuzzTestLength );
+                       $input = '';
+                       while ( strlen( $input ) < $totalLength ) {
+                               $logHairLength = mt_rand( 0, 1000000 ) / 1000000 * $logMaxLength;
+                               $hairLength = min( intval( exp( $logHairLength ) ), $dictSize );
+                               $offset = mt_rand( 0, $dictSize - $hairLength );
+                               $input .= substr( $dict, $offset, $hairLength );
+                       }
+
+                       $this->setupGlobals();
+                       $parser = $this->getParser();
+                       // Run the test
+                       try {
+                               $parser->parse( $input, $title, $opts );
+                               $fail = false;
+                       } catch ( Exception $exception ) {
+                               $fail = true;
+                       }
+
+                       if ( $fail ) {
+                               echo "Test failed with seed {$this->fuzzSeed}\n";
+                               echo "Input:\n";
+                               var_dump( $input );
+                               echo "\n\n";
+                               echo "$exception\n";
+                       } else {
+                               $numSuccess++;
+                       }
+                       $numTotal++;
+                       $this->teardownGlobals();
+                       $parser->__destruct();
+
+                       if ( $numTotal % 100 == 0 ) {
+                               $usage = intval( memory_get_usage( true ) / $this->memoryLimit / 1048576 * 100 );
+                               echo "{$this->fuzzSeed}: $numSuccess/$numTotal (mem: $usage%)\n";
+                               if ( $usage > 90 ) {
+                                       echo "Out of memory:\n";
+                                       $memStats = $this->getMemoryBreakdown();
+                                       foreach ( $memStats as $name => $usage ) {
+                                               echo "$name: $usage\n";
+                                       }
+                                       $this->abort();
+                               }
+                       }
+               }
+       }
+
+       /**
+        * Get an input dictionary from a set of parser test files
+        */
+       function getFuzzInput( $filenames ) {
+               $dict = '';
+               foreach( $filenames as $filename ) {
+                       $contents = file_get_contents( $filename );
+                       preg_match_all( '/!!\s*input\n(.*?)\n!!\s*result/s', $contents, $matches );
+                       foreach ( $matches[1] as $match ) {
+                               $dict .= $match . "\n";
+                       }
+               }
+               return $dict;
+       }
+
+       /**
+        * Get a memory usage breakdown
+        */
+       function getMemoryBreakdown() {
+               $memStats = array();
+               foreach ( $GLOBALS as $name => $value ) {
+                       $memStats['$'.$name] = strlen( serialize( $value ) );
+               }
+               $classes = get_declared_classes();
+               foreach ( $classes as $class ) {
+                       $rc = new ReflectionClass( $class );
+                       $props = $rc->getStaticProperties();
+                       $memStats[$class] = strlen( serialize( $props ) );
+                       $methods = $rc->getMethods();
+                       foreach ( $methods as $method ) {
+                               $memStats[$class] += strlen( serialize( $method->getStaticVariables() ) );
+                       }
+               }
+               $functions = get_defined_functions();
+               foreach ( $functions['user'] as $function ) {
+                       $rf = new ReflectionFunction( $function );
+                       $memStats["$function()"] = strlen( serialize( $rf->getStaticVariables() ) );
+               }
+               asort( $memStats );
+               return $memStats;
+       }
+
+       function abort() {
+               $this->abort();
+       }
+
        /**
         * Run a series of tests listed in the given text files.
         * Each test consists of a brief description, wikitext input,
@@ -126,10 +271,12 @@ class ParserTest {
         */
        public function runTestsFromFiles( $filenames ) {
                $this->recorder->start();
+               $this->setupDatabase();
                $ok = true;
                foreach( $filenames as $filename ) {
                        $ok = $this->runFile( $filename ) && $ok;
                }
+               $this->teardownDatabase();
                $this->recorder->report();
                $this->recorder->end();
                return $ok;
@@ -138,7 +285,7 @@ class ParserTest {
        private function runFile( $filename ) {
                $infile = fopen( $filename, 'rt' );
                if( !$infile ) {
-                       wfDie( "Couldn't open $filename\n" );
+                       wfDie( "Couldn't open file '$filename'\n" );
                } else {
                        global $IP;
                        $relative = wfRelativePath( $filename, $IP );
@@ -210,8 +357,11 @@ class ParserTest {
                                        else {
                                                $data['options'] = $this->chomp( $data['options'] );
                                        }
-                                       if (preg_match('/\\bdisabled\\b/i', $data['options'])
-                                               || !preg_match("/{$this->regex}/i", $data['test'])) {
+                                       if (!isset( $data['config'] ) )
+                                               $data['config'] = '';
+                                       
+                                       if ( (preg_match('/\\bdisabled\\b/i', $data['options'])
+                                               || !preg_match("/{$this->regex}/i", $data['test'])) && !$this->runDisabled ) {
                                                # disabled test
                                                $data = array();
                                                $section = null;
@@ -221,7 +371,9 @@ class ParserTest {
                                                $this->chomp( $data['test'] ),
                                                $this->chomp( $data['input'] ),
                                                $this->chomp( $data['result'] ),
-                                               $this->chomp( $data['options'] ) );
+                                               $this->chomp( $data['options'] ),
+                                               $this->chomp( $data['config']   )
+                                               );
                                        $ok = $ok && $result;
                                        $this->recorder->record( $this->chomp( $data['test'] ), $result );
                                        $data = array();
@@ -244,6 +396,24 @@ class ParserTest {
                return $ok;
        }
 
+       /**
+        * Get a Parser object
+        */
+       function getParser() {
+               global $wgParserConf;
+               $class = $wgParserConf['class'];
+               $parser = new $class( $wgParserConf );
+               foreach( $this->hooks as $tag => $callback ) {
+                       $parser->setHook( $tag, $callback );
+               }
+               foreach( $this->functionHooks as $tag => $bits ) {
+                       list( $callback, $flags ) = $bits;
+                       $parser->setFunctionHook( $tag, $callback, $flags );
+               }
+               wfRunHooks( 'ParserTestParser', array( &$parser ) );
+               return $parser;
+       }
+
        /**
         * Run a given wikitext input through a freshly-constructed wiki parser,
         * and compare the output against the expected results.
@@ -253,67 +423,65 @@ class ParserTest {
         * @param string $result Result to output
         * @return bool
         */
-       private function runTest( $desc, $input, $result, $opts ) {
-               global $wgParserConf;
+       private function runTest( $desc, $input, $result, $opts, $config ) {
                if( $this->showProgress ) {
                        $this->showTesting( $desc );
                }
 
-               $this->setupGlobals($opts);
+               $opts = $this->parseOptions( $opts );
+               $this->setupGlobals($opts, $config);
 
                $user = new User();
                $options = ParserOptions::newFromUser( $user );
 
-               if (preg_match('/\\bmath\\b/i', $opts)) {
+               if ( isset( $opts['math'] ) ) {
                        # XXX this should probably be done by the ParserOptions
                        $options->setUseTex(true);
                }
 
                $m = array();
-               if (preg_match('/title=\[\[(.*)\]\]/', $opts, $m)) {
-                       $titleText = $m[1];
+               if (isset( $opts['title'] ) ) {
+                       $titleText = $opts['title'];
                }
                else {
                        $titleText = 'Parser test';
                }
 
-               $noxml = (bool)preg_match( '~\\b noxml \\b~x', $opts );
-
-               $class = $wgParserConf['class'];
-               $parser = new $class( $wgParserConf );
-               foreach( $this->hooks as $tag => $callback ) {
-                       $parser->setHook( $tag, $callback );
-               }
-               foreach( $this->functionHooks as $tag => $bits ) {
-                       list( $callback, $flags ) = $bits;
-                       $parser->setFunctionHook( $tag, $callback, $flags );
-               }
-               wfRunHooks( 'ParserTestParser', array( &$parser ) );
-
-               $title =& Title::makeTitle( NS_MAIN, $titleText );
+               $noxml = isset( $opts['noxml'] );
+               $local = isset( $opts['local'] );
+               $parser = $this->getParser();
+               $title = Title::newFromText( $titleText );
 
                $matches = array();
-               if (preg_match('/\\bpst\\b/i', $opts)) {
+               if( isset( $opts['pst'] ) ) {
                        $out = $parser->preSaveTransform( $input, $title, $user, $options );
-               } elseif (preg_match('/\\bmsg\\b/i', $opts)) {
+               } elseif( isset( $opts['msg'] ) ) {
                        $out = $parser->transformMsg( $input, $options );
-               } elseif( preg_match( '/\\bsection=([\w-]+)\b/i', $opts, $matches ) ) {
-                       $section = $matches[1];
+               } elseif( isset( $opts['section'] ) ) {
+                       $section = $opts['section'];
                        $out = $parser->getSection( $input, $section );
-               } elseif( preg_match( '/\\breplace=([\w-]+),"(.*?)"/i', $opts, $matches ) ) {
-                       $section = $matches[1];
-                       $replace = $matches[2];
+               } elseif( isset( $opts['replace'] ) ) {
+                       $section = $opts['replace'][0];
+                       $replace = $opts['replace'][1];
                        $out = $parser->replaceSection( $input, $section, $replace );
+               } elseif( isset( $opts['comment'] ) ) {
+                       $linker = $user->getSkin();
+                       $out = $linker->formatComment( $input, $title, $local );
                } else {
                        $output = $parser->parse( $input, $title, $options, true, true, 1337 );
                        $out = $output->getText();
 
-                       if (preg_match('/\\bill\\b/i', $opts)) {
+                       if (isset( $opts['ill'] ) ) {
                                $out = $this->tidy( implode( ' ', $output->getLanguageLinks() ) );
-                       } else if (preg_match('/\\bcat\\b/i', $opts)) {
+                       } elseif( isset( $opts['cat'] ) ) {
                                global $wgOut;
                                $wgOut->addCategoryLinks($output->getCategories());
-                               $out = $this->tidy( implode( ' ', $wgOut->getCategoryLinks() ) );
+                               $cats = $wgOut->getCategoryLinks();
+                               if ( isset( $cats['normal'] ) ) {
+                                       $out = $this->tidy( implode( ' ', $cats['normal'] ) );
+                               } else {
+                                       $out = '';
+                               }
                        }
 
                        $result = $this->tidy($result);
@@ -331,41 +499,103 @@ class ParserTest {
 
        /**
         * Use a regex to find out the value of an option
-        * @param $regex A regex, the first group will be the value returned
-        * @param $opts Options line to look in
-        * @param $defaults Default value returned if the regex does not match
+        * @param $key name of option val to retrieve
+        * @param $opts Options array to look in
+        * @param $defaults Default value returned if not found
         */
-       private static function getOptionValue( $regex, $opts, $default ) {
-               $m = array();
-               if( preg_match( $regex, $opts, $m ) ) {
-                       return $m[1];
+       private static function getOptionValue( $key, $opts, $default ) {
+               $key = strtolower( $key );
+               if( isset( $opts[$key] ) ) {
+                       return $opts[$key];
                } else {
                        return $default;
                }
        }
+       
+       private function parseOptions( $instring ) {
+               $opts = array();
+               $lines = explode( "\n", $instring );
+               // foo
+               // foo=bar
+               // foo="bar baz"
+               // foo=[[bar baz]]
+               // foo=bar,"baz quux"
+               $regex = '/\b
+                       ([\w-]+)                                                # Key
+                       \b
+                       (?:\s*
+                               =                                               # First sub-value
+                               \s*
+                               (
+                                       "
+                                               [^"]*                   # Quoted val
+                                       "
+                               |
+                                       \[\[
+                                               [^]]*                   # Link target
+                                       \]\]
+                               |
+                                       [\w-]+                          # Plain word
+                               )
+                               (?:\s*
+                                       ,                                       # Sub-vals 1..N
+                                       \s*
+                                       (
+                                               "[^"]*"                 # Quoted val
+                                       |
+                                               \[\[[^]]*\]\]   # Link target
+                                       |
+                                               [\w-]+                  # Plain word
+                                       )
+                               )*
+                       )?
+                       /x';
+
+               if( preg_match_all( $regex, $instring, $matches, PREG_SET_ORDER ) ) {
+                       foreach( $matches as $bits ) {
+                               $match = array_shift( $bits );
+                               $key = strtolower( array_shift( $bits ) );
+                               if( count( $bits ) == 0 ) {
+                                       $opts[$key] = true;
+                               } elseif( count( $bits ) == 1 ) {
+                                       $opts[$key] = $this->cleanupOption( array_shift( $bits ) );
+                               } else {
+                                       // Array!
+                                       $opts[$key] = array_map( array( $this, 'cleanupOption' ), $bits );
+                               }
+                       }
+               }
+               return $opts;
+       }
+       
+       private function cleanupOption( $opt ) {
+               if( substr( $opt, 0, 1 ) == '"' ) {
+                       return substr( $opt, 1, -1 );
+               }
+               if( substr( $opt, 0, 2 ) == '[[' ) {
+                       return substr( $opt, 2, -2 );
+               }
+               return $opt;
+       }
 
        /**
         * Set up the global variables for a consistent environment for each test.
         * Ideally this should replace the global configuration entirely.
         */
-       private function setupGlobals($opts = '') {
-               # Save the prefixed / quoted table names for later use when we make the temporaries.
-               $db = wfGetDB( DB_SLAVE );
-               $this->oldTableNames = array();
-               foreach( $this->listTables() as $table ) {
-                       $this->oldTableNames[$table] = $db->tableName( $table );
-               }
+       private function setupGlobals($opts = '', $config = '') {
                if( !isset( $this->uploadDir ) ) {
                        $this->uploadDir = $this->setupUploadDir();
                }
 
                # Find out values for some special options.
                $lang =
-                       self::getOptionValue( '/language=([a-z]+(?:_[a-z]+)?)/', $opts, 'en' );
+                       self::getOptionValue( 'language', $opts, 'en' );
                $variant =
-                       self::getOptionValue( '/variant=([a-z]+(?:-[a-z]+)?)/', $opts, false );
+                       self::getOptionValue( 'variant', $opts, false );
                $maxtoclevel =
-                       self::getOptionValue( '/wgMaxTocLevel=(\d+)/', $opts, 999 );
+                       self::getOptionValue( 'wgMaxTocLevel', $opts, 999 );
+               $linkHolderBatchSize = 
+                       self::getOptionValue( 'wgLinkHolderBatchSize', $opts, 1000 );
 
                $settings = array(
                        'wgServer' => 'http://localhost',
@@ -388,13 +618,14 @@ class ParserTest {
                        'wgLanguageCode' => $lang,
                        'wgContLanguageCode' => $lang,
                        'wgDBprefix' => 'parsertest_',
-                       'wgRawHtml' => preg_match('/\\brawhtml\\b/i', $opts),
+                       'wgRawHtml' => isset( $opts['rawhtml'] ),
                        'wgLang' => null,
                        'wgContLang' => null,
-                       'wgNamespacesWithSubpages' => array( 0 => preg_match('/\\bsubpage\\b/i', $opts)),
+                       'wgNamespacesWithSubpages' => array( 0 => isset( $opts['subpage'] ) ),
                        'wgMaxTocLevel' => $maxtoclevel,
                        'wgCapitalLinks' => true,
                        'wgNoFollowLinks' => true,
+                       'wgNoFollowDomainExceptions' => array(),
                        'wgThumbnailScriptPath' => false,
                        'wgUseTeX' => false,
                        'wgLocaltimezone' => 'UTC',
@@ -402,7 +633,34 @@ class ParserTest {
                        'wgUseTidy' => false,
                        'wgDefaultLanguageVariant' => $variant,
                        'wgVariantArticlePath' => false,
+                       'wgGroupPermissions' => array( '*' => array(
+                               'createaccount' => true,
+                               'read'          => true,
+                               'edit'          => true,
+                               'createpage'    => true,
+                               'createtalk'    => true,
+                       ) ),
+                       'wgNamespaceProtection' => array( NS_MEDIAWIKI => 'editinterface' ),
+                       'wgDefaultExternalStore' => array(),
+                       'wgForeignFileRepos' => array(),
+                       'wgLinkHolderBatchSize' => $linkHolderBatchSize,
+                       'wgEnforceHtmlIds' => true,
+                       'wgExternalLinkTarget' => false,
+                       'wgAlwaysUseTidy' => false,
+                       'wgHtml5' => true,
+                       'wgWellFormedXml' => true,
                        );
+
+               if ($config) {
+                       $configLines = explode( "\n", $config );
+                       
+                       foreach( $configLines as $line ) {
+                               list( $var, $value ) = explode( '=', $line, 2 );
+                               
+                               $settings[$var] = eval("return $value;" );
+                       }
+               }
+               
                $this->savedGlobals = array();
                foreach( $settings as $var => $val ) {
                        $this->savedGlobals[$var] = $GLOBALS[$var];
@@ -411,10 +669,9 @@ class ParserTest {
                $langObj = Language::factory( $lang );
                $GLOBALS['wgLang'] = $langObj;
                $GLOBALS['wgContLang'] = $langObj;
+               $GLOBALS['wgMemc'] = new FakeMemCachedClient;
 
-               $GLOBALS['wgLoadBalancer']->loadMasterPos();
                //$GLOBALS['wgMessageCache'] = new MessageCache( new BagOStuff(), false, 0, $GLOBALS['wgDBname'] );
-               $this->setupDatabase();
 
                global $wgUser;
                $wgUser = new User();
@@ -431,7 +688,7 @@ class ParserTest {
                        'categorylinks', 'templatelinks', 'externallinks', 'langlinks',
                        'site_stats', 'hitcounter',     'ipblocks', 'image', 'oldimage',
                        'recentchanges', 'watchlist', 'math', 'interwiki',
-                       'querycache', 'objectcache', 'job', 'redirect', 'querycachetwo',
+                       'querycache', 'objectcache', 'job', 'l10n_cache', 'redirect', 'querycachetwo',
                        'archive', 'user_groups', 'page_props', 'category'
                );
 
@@ -452,97 +709,161 @@ class ParserTest {
         * the db will be visible to later tests in the run.
         */
        private function setupDatabase() {
-               static $setupDB = false;
-               global $wgDBprefix;
+               global $wgDBprefix, $wgDBtype;
+               if ( $this->databaseSetupDone ) {
+                       return;
+               }
+               if ( $wgDBprefix === 'parsertest_' ) {
+                       throw new MWException( 'setupDatabase should be called before setupGlobals' );
+               }
+               $this->databaseSetupDone = true;
+               $this->oldTablePrefix = $wgDBprefix;
+
+               # CREATE TEMPORARY TABLE breaks if there is more than one server
+               # FIXME: r40209 makes temporary tables break even with just one server
+               # FIXME: (bug 15892); disabling the feature entirely as a temporary fix
+               if ( true || wfGetLB()->getServerCount() != 1 ) {
+                       $this->useTemporaryTables = false;
+               }
 
-               # Make sure we don't mess with the live DB
-               if (!$setupDB && $wgDBprefix === 'parsertest_') {
-                       # oh teh horror
-                       $GLOBALS['wgLoadBalancer'] = LoadBalancer::newFromParams( $GLOBALS['wgDBservers'] );
-                       $db = wfGetDB( DB_MASTER );
+               $temporary = $this->useTemporaryTables ? 'TEMPORARY' : '';
 
-                       $tables = $this->listTables();
+               $db = wfGetDB( DB_MASTER );
+               $tables = $this->listTables();
 
-                       if (!(strcmp($db->getServerVersion(), '4.1') < 0 and stristr($db->getSoftwareLink(), 'MySQL'))) {
-                               # Database that supports CREATE TABLE ... LIKE
-                               global $wgDBtype;
-                               if( $wgDBtype == 'postgres' ) {
-                                       $def = 'INCLUDING DEFAULTS';
-                               } else {
-                                       $def = '';
-                               }
-                               foreach ($tables as $tbl) {
-                                       $newTableName = $db->tableName( $tbl );
-                                       $tableName = $this->oldTableNames[$tbl];
-                                       $db->query("CREATE TEMPORARY TABLE $newTableName (LIKE $tableName $def)");
-                               }
+               if ( !( $wgDBtype == 'mysql' && strcmp( $db->getServerVersion(), '4.1' ) < 0 ) ) {
+                       # Database that supports CREATE TABLE ... LIKE
+                       
+                       if( $wgDBtype == 'postgres' ) {
+                               $def = 'INCLUDING DEFAULTS';
+                               $temporary = 'TEMPORARY';
                        } else {
-                               # Hack for MySQL versions < 4.1, which don't support
-                               # "CREATE TABLE ... LIKE". Note that
-                               # "CREATE TEMPORARY TABLE ... SELECT * FROM ... LIMIT 0"
-                               # would not create the indexes we need....
-                               foreach ($tables as $tbl) {
-                                       $res = $db->query("SHOW CREATE TABLE {$this->oldTableNames[$tbl]}");
-                                       $row = $db->fetchRow($res);
-                                       $create = $row[1];
-                                       $create_tmp = preg_replace('/CREATE TABLE `(.*?)`/', 'CREATE TEMPORARY TABLE `'
-                                               . $wgDBprefix . $tbl .'`', $create);
-                                       if ($create === $create_tmp) {
-                                               # Couldn't do replacement
-                                               wfDie("could not create temporary table $tbl");
-                                       }
-                                       $db->query($create_tmp);
+                               $def = '';
+                       }
+                       foreach ( $tables as $tbl ) {
+                               # Clean up from previous aborted run.  So that table escaping
+                               # works correctly across DB engines, we need to change the pre-
+                               # fix back and forth so tableName() works right.
+                               $this->changePrefix( $this->oldTablePrefix );
+                               $oldTableName = $db->tableName( $tbl );
+                               $this->changePrefix( 'parsertest_' );
+                               $newTableName = $db->tableName( $tbl );
+
+                               if ( $db->tableExists( $tbl ) && $wgDBtype != 'postgres' ) {
+                                       $db->query( "DROP TABLE $newTableName" );
                                }
-
+                               # Create new table
+                               $db->query( "CREATE $temporary TABLE $newTableName (LIKE $oldTableName $def)" );
+                       }
+               } else {
+                       # Hack for MySQL versions < 4.1, which don't support
+                       # "CREATE TABLE ... LIKE". Note that
+                       # "CREATE TEMPORARY TABLE ... SELECT * FROM ... LIMIT 0"
+                       # would not create the indexes we need....
+                       #
+                       # Note that we don't bother changing around the prefixes here be-
+                       # cause we know we're using MySQL anyway.
+                       foreach ($tables as $tbl) {
+                               $oldTableName = $db->tableName( $tbl );
+                               $res = $db->query("SHOW CREATE TABLE $oldTableName");
+                               $row = $db->fetchRow($res);
+                               $create = $row[1];
+                               $create_tmp = preg_replace('/CREATE TABLE `(.*?)`/', 
+                                       "CREATE $temporary TABLE `parsertest_$tbl`", $create);
+                               if ($create === $create_tmp) {
+                                       # Couldn't do replacement
+                                       wfDie("could not create temporary table $tbl");
+                               }
+                               $db->query($create_tmp);
                        }
-
-                       # Hack: insert a few Wikipedia in-project interwiki prefixes,
-                       # for testing inter-language links
-                       $db->insert( 'interwiki', array(
-                               array( 'iw_prefix' => 'Wikipedia',
-                                      'iw_url'    => 'http://en.wikipedia.org/wiki/$1',
-                                      'iw_local'  => 0 ),
-                               array( 'iw_prefix' => 'MeatBall',
-                                      'iw_url'    => 'http://www.usemod.com/cgi-bin/mb.pl?$1',
-                                      'iw_local'  => 0 ),
-                               array( 'iw_prefix' => 'zh',
-                                      'iw_url'    => 'http://zh.wikipedia.org/wiki/$1',
-                                      'iw_local'  => 1 ),
-                               array( 'iw_prefix' => 'es',
-                                      'iw_url'    => 'http://es.wikipedia.org/wiki/$1',
-                                      'iw_local'  => 1 ),
-                               array( 'iw_prefix' => 'fr',
-                                      'iw_url'    => 'http://fr.wikipedia.org/wiki/$1',
-                                      'iw_local'  => 1 ),
-                               array( 'iw_prefix' => 'ru',
-                                      'iw_url'    => 'http://ru.wikipedia.org/wiki/$1',
-                                      'iw_local'  => 1 ),
-                               ) );
-
-                       # Hack: Insert an image to work with
-                       $db->insert( 'image', array(
-                               'img_name'        => 'Foobar.jpg',
-                               'img_size'        => 12345,
-                               'img_description' => 'Some lame file',
-                               'img_user'        => 1,
-                               'img_user_text'   => 'WikiSysop',
-                               'img_timestamp'   => $db->timestamp( '20010115123500' ),
-                               'img_width'       => 1941,
-                               'img_height'      => 220,
-                               'img_bits'        => 24,
-                               'img_media_type'  => MEDIATYPE_BITMAP,
-                               'img_major_mime'  => "image",
-                               'img_minor_mime'  => "jpeg",
-                               'img_metadata'    => serialize( array() ),
-                               ) );
-
-                       # Update certain things in site_stats
-                       $db->insert( 'site_stats', array( 'ss_row_id' => 1, 'ss_images' => 1, 'ss_good_articles' => 1 ) );
-
-                       $setupDB = true;
                }
+
+               $this->changePrefix( 'parsertest_' );
+
+               # Hack: insert a few Wikipedia in-project interwiki prefixes,
+               # for testing inter-language links
+               $db->insert( 'interwiki', array(
+                       array( 'iw_prefix' => 'wikipedia',
+                                  'iw_url'    => 'http://en.wikipedia.org/wiki/$1',
+                                  'iw_local'  => 0 ),
+                       array( 'iw_prefix' => 'meatball',
+                                  'iw_url'    => 'http://www.usemod.com/cgi-bin/mb.pl?$1',
+                                  'iw_local'  => 0 ),
+                       array( 'iw_prefix' => 'zh',
+                                  'iw_url'    => 'http://zh.wikipedia.org/wiki/$1',
+                                  'iw_local'  => 1 ),
+                       array( 'iw_prefix' => 'es',
+                                  'iw_url'    => 'http://es.wikipedia.org/wiki/$1',
+                                  'iw_local'  => 1 ),
+                       array( 'iw_prefix' => 'fr',
+                                  'iw_url'    => 'http://fr.wikipedia.org/wiki/$1',
+                                  'iw_local'  => 1 ),
+                       array( 'iw_prefix' => 'ru',
+                                  'iw_url'    => 'http://ru.wikipedia.org/wiki/$1',
+                                  'iw_local'  => 1 ),
+                       ) );
+
+               # Hack: Insert an image to work with
+               $db->insert( 'image', array(
+                       'img_name'        => 'Foobar.jpg',
+                       'img_size'        => 12345,
+                       'img_description' => 'Some lame file',
+                       'img_user'        => 1,
+                       'img_user_text'   => 'WikiSysop',
+                       'img_timestamp'   => $db->timestamp( '20010115123500' ),
+                       'img_width'       => 1941,
+                       'img_height'      => 220,
+                       'img_bits'        => 24,
+                       'img_media_type'  => MEDIATYPE_BITMAP,
+                       'img_major_mime'  => "image",
+                       'img_minor_mime'  => "jpeg",
+                       'img_metadata'    => serialize( array() ),
+                       ) );
+
+               # Update certain things in site_stats
+               $db->insert( 'site_stats', array( 'ss_row_id' => 1, 'ss_images' => 1, 'ss_good_articles' => 1 ) );
+
+               # Reinitialise the LocalisationCache to match the database state
+               Language::getLocalisationCache()->unloadAll();
        }
 
+       /**
+        * Change the table prefix on all open DB connections/
+        */
+       protected function changePrefix( $prefix ) {
+               global $wgDBprefix;
+               wfGetLBFactory()->forEachLB( array( $this, 'changeLBPrefix' ), array( $prefix ) );
+               $wgDBprefix = $prefix;
+       }
+
+       public function changeLBPrefix( $lb, $prefix ) {
+               $lb->forEachOpenConnection( array( $this, 'changeDBPrefix' ), array( $prefix ) );
+       }
+
+       public function changeDBPrefix( $db, $prefix ) {
+               $db->tablePrefix( $prefix );
+       }
+
+       private function teardownDatabase() {
+               global $wgDBprefix;
+               if ( !$this->databaseSetupDone ) {
+                       return;
+               }
+               $this->changePrefix( $this->oldTablePrefix );
+               $this->databaseSetupDone = false;
+               if ( $this->useTemporaryTables ) {
+                       # Don't need to do anything
+                       return;
+               }
+
+               /*
+               $tables = $this->listTables();
+               $db = wfGetDB( DB_MASTER );
+               foreach ( $tables as $table ) {
+                       $db->query( "DROP TABLE `parsertest_$table`" );
+               }*/
+       }
+       
        /**
         * Create a dummy uploads directory which will contain a couple
         * of files in order to pass existence tests.
@@ -560,9 +881,11 @@ class ParserTest {
                }
 
                wfDebug( "Creating upload directory $dir\n" );
-               mkdir( $dir );
-               mkdir( $dir . '/3' );
-               mkdir( $dir . '/3/3a' );
+               if ( file_exists( $dir ) ) {
+                       wfDebug( "Already exists!\n" );
+                       return $dir;
+               }
+               wfMkdirParents( $dir . '/3/3a' );
                copy( "$IP/skins/monobook/headbg.jpg", "$dir/3/3a/Foobar.jpg" );
                return $dir;
        }
@@ -573,6 +896,7 @@ class ParserTest {
         */
        private function teardownGlobals() {
                RepoGroup::destroySingleton();
+               LinkCache::singleton()->clear();
                foreach( $this->savedGlobals as $var => $val ) {
                        $GLOBALS[$var] = $val;
                }
@@ -786,6 +1110,7 @@ class ParserTest {
         */
        private function requireHook( $name ) {
                global $wgParser;
+               $wgParser->firstCallInit( ); //make sure hooks are loaded.
                if( isset( $wgParser->mTagHooks[$name] ) ) {
                        $this->hooks[$name] = $wgParser->mTagHooks[$name];
                } else {
@@ -801,6 +1126,7 @@ class ParserTest {
         */
        private function requireFunctionHook( $name ) {
                global $wgParser;
+               $wgParser->firstCallInit( ); //make sure hooks are loaded.
                if( isset( $wgParser->mFunctionHooks[$name] ) ) {
                        $this->functionHooks[$name] = $wgParser->mFunctionHooks[$name];
                } else {
@@ -911,8 +1237,12 @@ class DummyTermColorer {
 }
 
 class TestRecorder {
-       function __construct( $term ) {
-               $this->term = $term;
+       var $parent;
+       var $term;
+
+       function __construct( $parent ) {
+               $this->parent = $parent;
+               $this->term = $parent->term;
        }
 
        function start() {
@@ -951,14 +1281,21 @@ class TestRecorder {
        }
 }
 
-class DbTestRecorder extends TestRecorder  {
+class DbTestPreviewer extends TestRecorder  {
+       protected $lb;      ///< Database load balancer
        protected $db;      ///< Database connection to the main DB
        protected $curRun;  ///< run ID number for the current run
        protected $prevRun; ///< run ID number for the previous run, if any
+       protected $results; ///< Result array
 
-       function __construct( $term ) {
-               parent::__construct( $term );
-               $this->db = wfGetDB( DB_MASTER );
+       /**
+        * This should be called before the table prefix is changed
+        */
+       function __construct( $parent ) {
+               parent::__construct( $parent );
+               $this->lb = wfGetLBFactory()->newMainLB();
+               // This connection will have the wiki's table prefix, not parsertest_
+               $this->db = $this->lb->getConnection( DB_MASTER );
        }
 
        /**
@@ -966,81 +1303,84 @@ class DbTestRecorder extends TestRecorder  {
         * and all that fun stuff
         */
        function start() {
-               global $wgDBtype;
+               global $wgDBtype, $wgDBprefix;
                parent::start();
 
-               $this->db->begin();
-
-               if( ! $this->db->tableExists( 'testrun' ) or ! $this->db->tableExists( 'testitem') ) {
-                       print "WARNING> `testrun` table not found in database. Trying to create table.\n";
-            if ($wgDBtype === 'postgres')
-                               dbsource( dirname(__FILE__) . '/testRunner.postgres.sql',  $this->db );
-                       else
-                               dbsource( dirname(__FILE__) . '/testRunner.sql',  $this->db );
-                       echo "OK, resuming.\n";
+               if( ! $this->db->tableExists( 'testrun' ) 
+                       or ! $this->db->tableExists( 'testitem' ) ) 
+               {
+                       print "WARNING> `testrun` table not found in database.\n";
+                       $this->prevRun = false;
+               } else {
+                       // We'll make comparisons against the previous run later...
+                       $this->prevRun = $this->db->selectField( 'testrun', 'MAX(tr_id)' );
                }
-
-               // We'll make comparisons against the previous run later...
-               $this->prevRun = $this->db->selectField( 'testrun', 'MAX(tr_id)' );
-
-               $this->db->insert( 'testrun',
-                       array(
-                               'tr_date'        => $this->db->timestamp(),
-                               'tr_mw_version'  => SpecialVersion::getVersion(),
-                               'tr_php_version' => phpversion(),
-                               'tr_db_version'  => $this->db->getServerVersion(),
-                               'tr_uname'       => php_uname()
-                       ),
-                       __METHOD__ );
-                       if ($wgDBtype === 'postgres')
-                               $this->curRun = $this->db->currentSequenceValue('testrun_id_seq');
-                       else
-                               $this->curRun = $this->db->insertId();
+               $this->results = array();
        }
 
-       /**
-        * Record an individual test item's success or failure to the db
-        * @param string $test
-        * @param bool $result
-        */
        function record( $test, $result ) {
                parent::record( $test, $result );
-               $this->db->insert( 'testitem',
-                       array(
-                               'ti_run'     => $this->curRun,
-                               'ti_name'    => $test,
-                               'ti_success' => $result ? 1 : 0,
-                       ),
-                       __METHOD__ );
-       }
-
-       /**
-        * Commit transaction and clean up for result recording
-        */
-       function end() {
-               $this->db->commit();
-               parent::end();
+               $this->results[$test] = $result;
        }
 
        function report() {
                if( $this->prevRun ) {
+                       // f = fail, p = pass, n = nonexistent
+                       // codes show before then after
                        $table = array(
-                               array( 'previously failing test(s) now PASSING! :)', 0, 1 ),
-                               array( 'previously PASSING test(s) removed o_O', 1, null ),
-                               array( 'new PASSING test(s) :)', null, 1 ),
-
-                               array( 'previously passing test(s) now FAILING! :(', 1, 0 ),
-                               array( 'previously FAILING test(s) removed O_o', 0, null ),
-                               array( 'new FAILING test(s) :(', null, 0 ),
-                               array( 'still FAILING test(s) :(', 0, 0 ),
+                               'fp' => 'previously failing test(s) now PASSING! :)',
+                               'pn' => 'previously PASSING test(s) removed o_O',
+                               'np' => 'new PASSING test(s) :)',
+
+                               'pf' => 'previously passing test(s) now FAILING! :(',
+                               'fn' => 'previously FAILING test(s) removed O_o',
+                               'nf' => 'new FAILING test(s) :(',
+                               'ff' => 'still FAILING test(s) :(',
                        );
-                       foreach( $table as $criteria ) {
-                               list( $label, $before, $after ) = $criteria;
-                               $differences = $this->compareResult( $before, $after );
-                               if( $differences ) {
-                                       $count = count($differences);
+
+                       $prevResults = array();
+
+                       $res = $this->db->select( 'testitem', array( 'ti_name', 'ti_success' ),
+                               array( 'ti_run' => $this->prevRun ), __METHOD__ );
+                       foreach ( $res as $row ) {
+                               if ( !$this->parent->regex 
+                                       || preg_match( "/{$this->parent->regex}/i", $row->ti_name ) )
+                               {
+                                       $prevResults[$row->ti_name] = $row->ti_success;
+                               }
+                       }
+
+                       $combined = array_keys( $this->results + $prevResults );
+
+                       # Determine breakdown by change type
+                       $breakdown = array();
+                       foreach ( $combined as $test ) {
+                               if ( !isset( $prevResults[$test] ) ) {
+                                       $before = 'n';
+                               } elseif ( $prevResults[$test] == 1 ) {
+                                       $before = 'p';
+                               } else /* if ( $prevResults[$test] == 0 )*/ {
+                                       $before = 'f';
+                               }
+                               if ( !isset( $this->results[$test] ) ) {
+                                       $after = 'n';
+                               } elseif ( $this->results[$test] == 1 ) {
+                                       $after = 'p';
+                               } else /*if ( $this->results[$test] == 0 ) */ {
+                                       $after = 'f';
+                               }
+                               $code = $before . $after;
+                               if ( isset( $table[$code] ) ) {
+                                       $breakdown[$code][$test] = $this->getTestStatusInfo( $test, $after );
+                               }
+                       }
+
+                       # Write out results
+                       foreach ( $table as $code => $label ) {
+                               if( !empty( $breakdown[$code] ) ) {
+                                       $count = count($breakdown[$code]);
                                        printf( "\n%4d %s\n", $count, $label );
-                                       foreach ($differences as $differing_test_name => $statusInfo) {
+                                       foreach ($breakdown[$code] as $differing_test_name => $statusInfo) {
                                                print "      * $differing_test_name  [$statusInfo]\n";
                                        }
                                }
@@ -1052,54 +1392,15 @@ class DbTestRecorder extends TestRecorder  {
                parent::report();
        }
 
-       /**
-        ** Returns an array of the test names with changed results, based on the specified
-        ** before/after criteria.
-        */
-       private function compareResult( $before, $after ) {
-               $testitem = $this->db->tableName( 'testitem' );
-               $prevRun = intval( $this->prevRun );
-               $curRun = intval( $this->curRun );
-               $prevStatus = $this->condition( $before );
-               $curStatus = $this->condition( $after );
-
-               // note: requires mysql >= ver 4.1 for subselects
-               if( is_null( $after ) ) {
-                       $sql = "
-                               select prev.ti_name as t from $testitem as prev
-                                       where prev.ti_run=$prevRun and
-                                               prev.ti_success $prevStatus and
-                                               (select current.ti_success from $testitem as current
-                                                       where current.ti_run=$curRun
-                                                               and prev.ti_name=current.ti_name) $curStatus";
-               } else {
-                       $sql = "
-                               select current.ti_name as t from $testitem as current 
-                                       where current.ti_run=$curRun and
-                                               current.ti_success $curStatus and
-                                               (select prev.ti_success from $testitem as prev
-                                                       where prev.ti_run=$prevRun
-                                                               and prev.ti_name=current.ti_name) $prevStatus";
-               }
-               $result = $this->db->query( $sql, __METHOD__ );
-               $retval = array();
-               while ($row = $this->db->fetchObject( $result )) {
-                       $testname = $row->t;
-                       $retval[$testname] = $this->getTestStatusInfo( $testname, $after, $curRun );
-               }
-               $this->db->freeResult( $result );
-               return $retval;
-       }
-
        /**
         ** Returns a string giving information about when a test last had a status change.
         ** Could help to track down when regressions were introduced, as distinct from tests
         ** which have never passed (which are more change requests than regressions).
         */
-       private function getTestStatusInfo($testname, $after, $curRun) {
+       private function getTestStatusInfo($testname, $after) {
 
                // If we're looking at a test that has just been removed, then say when it first appeared.
-               if ( is_null( $after ) ) {
+               if ( $after == 'n' ) {
                        $changedRun = $this->db->selectField ( 'testitem',
                                                                                                   'MIN(ti_run)',
                                                                                                   array( 'ti_name' => $testname ),
@@ -1115,18 +1416,18 @@ class DbTestRecorder extends TestRecorder  {
 
                // Otherwise, this test has previous recorded results.
                // See when this test last had a different result to what we're seeing now.
-               $changedRun = $this->db->selectField ( 'testitem',
-                                                                                          'MAX(ti_run)',
-                                                                                          array( 
-                                                                                              'ti_name'    => $testname,
-                                                                                              'ti_success' => ($after ? "0" : "1"),
-                                                                                              "ti_run != " . $this->db->addQuotes ( $curRun )
-                                                                                               ), 
-                                                                                               __METHOD__ );
+               $conds = array( 
+                       'ti_name'    => $testname,
+                       'ti_success' => ($after == 'f' ? "1" : "0") );
+               if ( $this->curRun ) {
+                       $conds[] = "ti_run != " . $this->db->addQuotes ( $this->curRun );
+               }
+
+               $changedRun = $this->db->selectField ( 'testitem', 'MAX(ti_run)', $conds, __METHOD__ );
 
                // If no record of ever having had a different result.
                if ( is_null ( $changedRun ) ) {
-                       if ($after == "0") {
+                       if ($after == "f") {
                                return "Has never passed";
                        } else {
                                return "Has never failed";
@@ -1147,33 +1448,167 @@ class DbTestRecorder extends TestRecorder  {
                                                                                array( "LIMIT" => 1, "ORDER BY" => 'tr_id' )
                                                                         );
 
-               return ( $after == "0" ? "Introduced" : "Fixed" ) . " between "
+               if ( $post ) {
+                       $postDate = date( "d-M-Y H:i:s",  strtotime ( $post->tr_date  ) ) . ", {$post->tr_mw_version}";
+               } else {
+                       $postDate = 'now';
+               }
+               return ( $after == "f" ? "Introduced" : "Fixed" ) . " between "
                                . date( "d-M-Y H:i:s",  strtotime ( $pre->tr_date ) ) .  ", " . $pre->tr_mw_version
-                               . " and "
-                               . date( "d-M-Y H:i:s",  strtotime ( $post->tr_date  ) ) .  ", " . $post->tr_mw_version ;
+                               . " and $postDate";
+
        }
 
        /**
-        ** Helper function for compareResult() database querying.
+        * Commit transaction and clean up for result recording
         */
-       private function condition( $value ) {
-               if( is_null( $value ) ) {
-                       return 'IS NULL';
-               } else {
-                       return '=' . intval( $value );
-               }
+       function end() {
+               $this->lb->commitMasterChanges();
+               $this->lb->closeAll();
+               parent::end();
        }
 
 }
 
-class DbTestPreviewer extends DbTestRecorder  {
+class DbTestRecorder extends DbTestPreviewer  {
        /**
-        * Commit transaction and clean up for result recording
+        * Set up result recording; insert a record for the run with the date
+        * and all that fun stuff
         */
-       function end() {
-               $this->db->rollback();
-               TestRecorder::end();
+       function start() {
+               global $wgDBtype, $wgDBprefix, $options;
+               $this->db->begin();
+
+               if( ! $this->db->tableExists( 'testrun' ) 
+                       or ! $this->db->tableExists( 'testitem' ) ) 
+               {
+                       print "WARNING> `testrun` table not found in database. Trying to create table.\n";
+                       if ($wgDBtype === 'postgres')
+                               $this->db->sourceFile( dirname(__FILE__) . '/testRunner.postgres.sql' );
+                       else
+                               $this->db->sourceFile( dirname(__FILE__) . '/testRunner.sql' );
+                       echo "OK, resuming.\n";
+               }
+               
+               parent::start();
+
+               $this->db->insert( 'testrun',
+                       array(
+                               'tr_date'        => $this->db->timestamp(),
+                               'tr_mw_version'  => isset( $options['setversion'] ) ?
+                                       $options['setversion'] : SpecialVersion::getVersion(),
+                               'tr_php_version' => phpversion(),
+                               'tr_db_version'  => $this->db->getServerVersion(),
+                               'tr_uname'       => php_uname()
+                       ),
+                       __METHOD__ );
+                       if ($wgDBtype === 'postgres')
+                               $this->curRun = $this->db->currentSequenceValue('testrun_id_seq');
+                       else
+                               $this->curRun = $this->db->insertId();
+       }
+
+       /**
+        * Record an individual test item's success or failure to the db
+        * @param string $test
+        * @param bool $result
+        */
+       function record( $test, $result ) {
+               parent::record( $test, $result );
+               $this->db->insert( 'testitem',
+                       array(
+                               'ti_run'     => $this->curRun,
+                               'ti_name'    => $test,
+                               'ti_success' => $result ? 1 : 0,
+                       ),
+                       __METHOD__ );
        }
 }
 
-?>
+class RemoteTestRecorder extends TestRecorder {
+       function start() {
+               parent::start();
+               $this->results = array();
+               $this->ping( 'running' );
+       }
+       
+       function record( $test, $result ) {
+               parent::record( $test, $result );
+               $this->results[$test] = (bool)$result;
+       }
+       
+       function end() {
+               $this->ping( 'complete', $this->results );
+               parent::end();
+       }
+       
+       /**
+        * Inform a CodeReview instance that we've started or completed a test run...
+        * @param $remote array: info on remote target
+        * @param $status string: "running" - tell it we've started
+        *                        "complete" - provide test results array
+        *                        "abort" - something went horribly awry
+        * @param $data array of test name => true/false
+        */
+       function ping( $status, $results=false ) {
+               global $wgParserTestRemote, $IP;
+               
+               $remote = $wgParserTestRemote;
+               $revId = SpecialVersion::getSvnRevision( $IP );
+               $jsonResults = json_encode( $results );
+               
+               if( !$remote ) {
+                       print "Can't do remote upload without configuring \$wgParserTestRemote!\n";
+                       exit( 1 );
+               }
+               
+               // Generate a hash MAC to validate our credentials
+               $message = array(
+                       $remote['repo'],
+                       $remote['suite'],
+                       $revId,
+                       $status,
+               );
+               if( $status == "complete" ) {
+                       $message[] = $jsonResults;
+               }
+               $hmac = hash_hmac( "sha1", implode( "|", $message ), $remote['secret'] );
+               
+               $postData = array(
+                       'action' => 'codetestupload',
+                       'format' => 'json',
+                       'repo'   => $remote['repo'],
+                       'suite'  => $remote['suite'],
+                       'rev'    => $revId,
+                       'status' => $status,
+                       'hmac'   => $hmac,
+               );
+               if( $status == "complete" ) {
+                       $postData['results'] = $jsonResults;
+               }
+               $response = $this->post( $remote['api-url'], $postData );
+               
+               if( $response === false ) {
+                       print "CodeReview info upload failed to reach server.\n";
+                       exit( 1 );
+               }
+               $responseData = json_decode( $response, true );
+               if( !is_array( $responseData ) ) {
+                       print "CodeReview API response not recognized...\n";
+                       wfDebug( "Unrecognized CodeReview API response: $response\n" );
+                       exit( 1 );
+               }
+               if( isset( $responseData['error'] ) ) {
+                       $code = $responseData['error']['code'];
+                       $info = $responseData['error']['info'];
+                       print "CodeReview info upload failed: $code $info\n";
+                       exit( 1 );
+               }
+       }
+       
+       function post( $url, $data ) {
+               // @fixme: for whatever reason, I get a 417 fail when using CURL's multipart form submit.
+               // If we do form URL encoding ourselves, though, it should work.
+               return Http::post( $url, array( 'postdata' => wfArrayToCGI( $data ) ) );
+       }
+}