class CheckSyntax extends Maintenance {
// List of files we're going to check
- private $mFiles = array(), $mFailures = array(), $mWarnings = array();
- private $mIgnorePaths = array(), $mNoStyleCheckPaths = array();
+ private $mFiles = [], $mFailures = [], $mWarnings = [];
+ private $mIgnorePaths = [], $mNoStyleCheckPaths = [];
public function __construct() {
parent::__construct();
- $this->mDescription = "Check syntax for all PHP files in MediaWiki";
+ $this->addDescription( 'Check syntax for all PHP files in MediaWiki' );
$this->addOption( 'with-extensions', 'Also recurse the extensions folder' );
$this->addOption(
'path',
public function execute() {
$this->buildFileList();
- // ParseKit is broken on PHP 5.3+, disabled until this is fixed
- $useParseKit = function_exists( 'parsekit_compile_file' )
- && version_compare( PHP_VERSION, '5.3', '<' );
-
- $str = 'Checking syntax (using ' . ( $useParseKit ?
- 'parsekit' : ' php -l, this can take a long time' ) . ")\n";
- $this->output( $str );
+ $this->output( "Checking syntax (using php -l, this can take a long time)\n" );
foreach ( $this->mFiles as $f ) {
- if ( $useParseKit ) {
- $this->checkFileWithParsekit( $f );
- } else {
- $this->checkFileWithCli( $f );
- }
+ $this->checkFileWithCli( $f );
if ( !$this->hasOption( 'syntax-only' ) ) {
$this->checkForMistakes( $f );
}
private function buildFileList() {
global $IP;
- $this->mIgnorePaths = array(
- // Compat stuff, explodes on PHP 5.3
- "includes/NamespaceCompat.php$",
- );
+ $this->mIgnorePaths = [
+ ];
- $this->mNoStyleCheckPaths = array(
+ $this->mNoStyleCheckPaths = [
// Third-party code we don't care about
"/activemq_stomp/",
"EmailPage/PHPMailer",
"QPoll/Excel/",
"/geshi/",
"/smarty/",
- );
+ ];
if ( $this->hasOption( 'path' ) ) {
$path = $this->getOption( 'path' );
// Only check files in these directories.
// Don't just put $IP, because the recursive dir thingie goes into all subdirs
- $dirs = array(
+ $dirs = [
$IP . '/includes',
$IP . '/mw-config',
$IP . '/languages',
$IP . '/maintenance',
$IP . '/skins',
- );
+ ];
if ( $this->hasOption( 'with-extensions' ) ) {
$dirs[] = $IP . '/extensions';
}
$wgMaxShellMemory = $oldMaxShellMemory;
- $arr = array();
+ $arr = [];
$filename = strtok( $output, "\n" );
while ( $filename !== false ) {
if ( $filename !== '' ) {
return false;
}
foreach ( $this->mIgnorePaths as $regex ) {
- $m = array();
+ $m = [];
if ( preg_match( "~{$regex}~", $file, $m ) ) {
return false;
}
}
}
- /**
- * Check a file for syntax errors using Parsekit. Shamelessly stolen
- * from tools/lint.php by TimStarling
- * @param string $file Path to a file to check for syntax errors
- * @return bool
- */
- private function checkFileWithParsekit( $file ) {
- static $okErrors = array(
- 'Redefining already defined constructor',
- 'Assigning the return value of new by reference is deprecated',
- );
- $errors = array();
- parsekit_compile_file( $file, $errors, PARSEKIT_SIMPLE );
- $ret = true;
- if ( $errors ) {
- foreach ( $errors as $error ) {
- foreach ( $okErrors as $okError ) {
- if ( substr( $error['errstr'], 0, strlen( $okError ) ) == $okError ) {
- continue 2;
- }
- }
- $ret = false;
- $this->output( "Error in $file line {$error['lineno']}: {$error['errstr']}\n" );
- $this->mFailures[$file] = $errors;
- }
- }
-
- return $ret;
- }
-
/**
* Check a file for syntax errors using php -l
* @param string $file Path to a file to check for syntax errors
*/
private function checkForMistakes( $file ) {
foreach ( $this->mNoStyleCheckPaths as $regex ) {
- $m = array();
+ $m = [];
if ( preg_match( "~{$regex}~", $file, $m ) ) {
return;
}
}
if ( !isset( $this->mWarnings[$file] ) ) {
- $this->mWarnings[$file] = array();
+ $this->mWarnings[$file] = [];
}
$this->mWarnings[$file][] = $desc;
$this->output( "Warning in file $file: $desc found.\n" );
}
if ( !isset( $this->mWarnings[$file] ) ) {
- $this->mWarnings[$file] = array();
+ $this->mWarnings[$file] = [];
}
$this->mWarnings[$file][] = $desc;
$this->output( "Warning in file $file: $desc found.\n" );