Merge "TableDiffFormatter: Don't repeatedly call array_shift()"

[lhc/web/wiklou.git] / includes / title / MediaWikiPageLinkRenderer.php

diff --git a/includes/title/MediaWikiPageLinkRenderer.php b/includes/title/MediaWikiPageLinkRenderer.php
index 07060b2..b458578 100644 (file)
--- a/includes/title/MediaWikiPageLinkRenderer.php
+++ b/includes/title/MediaWikiPageLinkRenderer.php
@@ -67,7 +67,7 @@ class MediaWikiPageLinkRenderer implements PageLinkRenderer {
         *
         * @return string
         */
-       public function getPageUrl( LinkTarget $page, $params = array() ) {
+       public function getPageUrl( LinkTarget $page, $params = [] ) {
                // TODO: move the code from Linker::linkUrl here!
                // The below is just a rough estimation!
 
@@ -106,11 +106,8 @@ class MediaWikiPageLinkRenderer implements PageLinkRenderer {
                // TODO: move the logic implemented by Linker here,
                // using $this->formatter and $this->baseUrl, and
                // re-implement Linker to use a HtmlPageLinkRenderer.
-               if ( $linkTarget instanceof Title ) {
-                       $title = $linkTarget;
-               } else {
-                       $title = Title::newFromLinkTarget( $linkTarget );
-               }
+
+               $title = Title::newFromLinkTarget( $linkTarget );
                $link = Linker::link( $title, htmlspecialchars( $text ) );
 
                return $link;