Followup r80122, protected, just incase it's needed..
[lhc/web/wiklou.git] / includes / specials / SpecialUndelete.php
index f713fe4..e613725 100644 (file)
@@ -1,25 +1,29 @@
 <?php
-
 /**
- * Special page allowing users with the appropriate permissions to view
- * and restore deleted content
+ * Implements Special:Undelete
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ * http://www.gnu.org/copyleft/gpl.html
  *
  * @file
  * @ingroup SpecialPage
  */
 
-/**
- * Constructor
- */
-function wfSpecialUndelete( $par ) {
-       global $wgRequest;
-
-       $form = new UndeleteForm( $wgRequest, $par );
-       $form->execute();
-}
-
 /**
  * Used to show archived pages and eventually restore them.
+ *
  * @ingroup SpecialPage
  */
 class PageArchive {
@@ -28,7 +32,7 @@ class PageArchive {
 
        function __construct( $title ) {
                if( is_null( $title ) ) {
-                       throw new MWException( 'Archiver() given a null title.');
+                       throw new MWException( __METHOD__ . ' given a null title.' );
                }
                $this->title = $title;
        }
@@ -50,6 +54,7 @@ class PageArchive {
         * given title prefix.
         * Returns result wrapper with (ar_namespace, ar_title, count) fields.
         *
+        * @param $prefix String: title prefix
         * @return ResultWrapper
         */
        public static function listPagesByPrefix( $prefix ) {
@@ -58,16 +63,15 @@ class PageArchive {
                $title = Title::newFromText( $prefix );
                if( $title ) {
                        $ns = $title->getNamespace();
-                       $encPrefix = $dbr->escapeLike( $title->getDBkey() );
+                       $prefix = $title->getDBkey();
                } else {
                        // Prolly won't work too good
                        // @todo handle bare namespace names cleanly?
                        $ns = 0;
-                       $encPrefix = $dbr->escapeLike( $prefix );
                }
                $conds = array(
                        'ar_namespace' => $ns,
-                       "ar_title LIKE '$encPrefix%'",
+                       'ar_title' . $dbr->buildLike( $prefix, $dbr->anyString() ),
                );
                return self::listPages( $dbr, $conds );
        }
@@ -154,7 +158,8 @@ class PageArchive {
         * Fetch (and decompress if necessary) the stored text for the deleted
         * revision of the page with the given timestamp.
         *
-        * @return string
+        * @param $timestamp String
+        * @return String
         * @deprecated Use getRevision() for more flexible information
         */
        function getRevisionText( $timestamp ) {
@@ -165,7 +170,8 @@ class PageArchive {
        /**
         * Return a Revision object containing data for the deleted revision.
         * Note that the result *may* or *may not* have a null page ID.
-        * @param string $timestamp
+        *
+        * @param $timestamp String
         * @return Revision
         */
        function getRevision( $timestamp ) {
@@ -201,7 +207,7 @@ class PageArchive {
         * May produce unexpected results in case of history merges or other
         * unusual time issues.
         *
-        * @param string $timestamp
+        * @param $timestamp String
         * @return Revision or null
         */
        function getPreviousRevision( $timestamp ) {
@@ -249,6 +255,9 @@ class PageArchive {
 
        /**
         * Get the text from an archive row containing ar_text, ar_flags and ar_text_id
+        *
+        * @param $row Object: database row
+        * @return Revision
         */
        function getTextFromRow( $row ) {
                if( is_null( $row->ar_text_id ) ) {
@@ -273,7 +282,7 @@ class PageArchive {
         *
         * If there are no archived revisions for the page, returns NULL.
         *
-        * @return string
+        * @return String
         */
        function getLastRevisionText() {
                $dbr = wfGetDB( DB_SLAVE );
@@ -281,18 +290,19 @@ class PageArchive {
                        array( 'ar_text', 'ar_flags', 'ar_text_id' ),
                        array( 'ar_namespace' => $this->title->getNamespace(),
                               'ar_title' => $this->title->getDBkey() ),
-                       'PageArchive::getLastRevisionText',
+                       __METHOD__,
                        array( 'ORDER BY' => 'ar_timestamp DESC' ) );
                if( $row ) {
                        return $this->getTextFromRow( $row );
                } else {
-                       return NULL;
+                       return null;
                }
        }
 
        /**
         * Quick check if any archived revisions are present for the page.
-        * @return bool
+        *
+        * @return Boolean
         */
        function isDeleted() {
                $dbr = wfGetDB( DB_SLAVE );
@@ -307,10 +317,10 @@ class PageArchive {
         * Once restored, the items will be removed from the archive tables.
         * The deletion log will be updated with an undeletion notice.
         *
-        * @param array $timestamps Pass an empty array to restore all revisions, otherwise list the ones to undelete.
-        * @param string $comment
-        * @param array $fileVersions
-        * @param bool $unsuppress
+        * @param $timestamps Array: pass an empty array to restore all revisions, otherwise list the ones to undelete.
+        * @param $comment String
+        * @param $fileVersions Array
+        * @param $unsuppress Boolean
         *
         * @return array(number of file revisions restored, number of image revisions restored, log message)
         * on success, false on failure
@@ -359,7 +369,7 @@ class PageArchive {
                }
 
                if( trim( $comment ) != '' )
-                       $reason .= ": {$comment}";
+                       $reason .= wfMsgForContent( 'colon-separator' ) . $comment;
                $log->addEntry( 'restore', $this->title, $reason );
 
                return array($textRestored, $filesRestored, $reason);
@@ -370,12 +380,11 @@ class PageArchive {
         * to the cur/old tables. If the page currently exists, all revisions will
         * be stuffed into old, otherwise the most recent will go into cur.
         *
-        * @param array $timestamps Pass an empty array to restore all revisions, otherwise list the ones to undelete.
-        * @param string $comment
-        * @param array $fileVersions
-        * @param bool $unsuppress, remove all ar_deleted/fa_deleted restrictions of seletected revs
+        * @param $timestamps Array: pass an empty array to restore all revisions, otherwise list the ones to undelete.
+        * @param $comment String
+        * @param $unsuppress Boolean: remove all ar_deleted/fa_deleted restrictions of seletected revs
         *
-        * @return mixed number of revisions restored or false on failure
+        * @return Mixed: number of revisions restored or false on failure
         */
        private function undeleteRevisions( $timestamps, $unsuppress = false, $comment = '' ) {
                if ( wfReadOnly() )
@@ -386,13 +395,14 @@ class PageArchive {
 
                # Does this page already exist? We'll have to update it...
                $article = new Article( $this->title );
-               $options = 'FOR UPDATE';
+               $options = 'FOR UPDATE'; // lock page
                $page = $dbw->selectRow( 'page',
                        array( 'page_id', 'page_latest' ),
                        array( 'page_namespace' => $this->title->getNamespace(),
                               'page_title'     => $this->title->getDBkey() ),
                        __METHOD__,
-                       $options );
+                       $options
+               );
                if( $page ) {
                        $makepage = false;
                        # Page already exists. Import the history, and if necessary
@@ -449,31 +459,53 @@ class PageArchive {
                                $oldones ),
                        __METHOD__,
                        /* options */ array( 'ORDER BY' => 'ar_timestamp' )
-                       );
+               );
                $ret = $dbw->resultObject( $result );
                $rev_count = $dbw->numRows( $result );
+               if( !$rev_count ) {
+                       wfDebug( __METHOD__.": no revisions to restore\n" );
+                       return false; // ???
+               }
+
+               $ret->seek( $rev_count - 1 ); // move to last
+               $row = $ret->fetchObject(); // get newest archived rev
+               $ret->seek( 0 ); // move back
 
                if( $makepage ) {
+                       // Check the state of the newest to-be version...
+                       if( !$unsuppress && ($row->ar_deleted & Revision::DELETED_TEXT) ) {
+                               return false; // we can't leave the current revision like this!
+                       }
+                       // Safe to insert now...
                        $newid  = $article->insertOn( $dbw );
                        $pageId = $newid;
+               } else {
+                       // Check if a deleted revision will become the current revision...
+                       if( $row->ar_timestamp > $previousTimestamp ) {
+                               // Check the state of the newest to-be version...
+                               if( !$unsuppress && ($row->ar_deleted & Revision::DELETED_TEXT) ) {
+                                       return false; // we can't leave the current revision like this!
+                               }
+                       }
                }
 
                $revision = null;
                $restored = 0;
 
-               while( $row = $ret->fetchObject() ) {
+               foreach ( $ret as $row ) {
                        // Check for key dupes due to shitty archive integrity.
                        if( $row->ar_rev_id ) {
                                $exists = $dbw->selectField( 'revision', '1', array('rev_id' => $row->ar_rev_id), __METHOD__ );
                                if( $exists ) continue; // don't throw DB errors
                        }
-
-                       $revision = Revision::newFromArchiveRow( $row, 
-                               array( 
-                                       'page' => $pageId, 
+                       // Insert one revision at a time...maintaining deletion status
+                       // unless we are specifically removing all restrictions...
+                       $revision = Revision::newFromArchiveRow( $row,
+                               array(
+                                       'page' => $pageId,
                                        'deleted' => $unsuppress ? 0 : $row->ar_deleted
                                ) );
-                       
+
                        $revision->insertOn( $dbw );
                        $restored++;
 
@@ -486,7 +518,7 @@ class PageArchive {
                                'ar_title' => $this->title->getDBkey(),
                                $oldones ),
                        __METHOD__ );
-               
+
                // Was anything restored at all?
                if( $restored == 0 )
                        return 0;
@@ -495,16 +527,6 @@ class PageArchive {
                        // Attach the latest revision to the page...
                        $wasnew = $article->updateIfNewerOn( $dbw, $revision, $previousRevId );
                        if( $newid || $wasnew ) {
-                               // We don't handle well with top revision deleted
-                               // FIXME: any sysop can unsuppress any revision by just undeleting it into a non-existent page!
-                               if( $revision->getVisibility() ) {
-                                       $dbw->update( 'revision', 
-                                               array( 'rev_deleted' => 0 ),
-                                               array( 'rev_id' => $revision->getId() ),
-                                               __METHOD__
-                                       );
-                                       $revision->mDeleted = 0; // Don't pollute the parser cache
-                               }
                                // Update site stats, link tables, etc
                                $article->createUpdates( $revision );
                        }
@@ -523,7 +545,8 @@ class PageArchive {
                        }
                } else {
                        // Revision couldn't be created. This is very weird
-                       return self::UNDELETE_UNKNOWNERR;
+                       wfDebug( "Undelete: unknown error...\n" );
+                       return false;
                }
 
                return $restored;
@@ -533,48 +556,58 @@ class PageArchive {
 }
 
 /**
- * The HTML form for Special:Undelete, which allows users with the appropriate
- * permissions to view and restore deleted content.
+ * Special page allowing users with the appropriate permissions to view
+ * and restore deleted content.
+ *
  * @ingroup SpecialPage
  */
-class UndeleteForm {
+class SpecialUndelete extends SpecialPage {
        var $mAction, $mTarget, $mTimestamp, $mRestore, $mInvert, $mTargetObj;
-       var $mTargetTimestamp, $mAllowed, $mComment, $mToken;
+       var $mTargetTimestamp, $mAllowed, $mCanView, $mComment, $mToken, $mRequest;
+
+       function __construct( $request = null ) {
+               parent::__construct( 'Undelete', 'deletedhistory' );
 
-       function UndeleteForm( $request, $par = "" ) {
+               if ( $request === null ) {
+                       global $wgRequest;
+                       $this->mRequest = $wgRequest;
+               } else {
+                       $this->mRequest = $request;
+               }
+       }
+
+       function loadRequest() {
                global $wgUser;
-               $this->mAction = $request->getVal( 'action' );
-               $this->mTarget = $request->getVal( 'target' );
-               $this->mSearchPrefix = $request->getText( 'prefix' );
-               $time = $request->getVal( 'timestamp' );
+               $this->mAction = $this->mRequest->getVal( 'action' );
+               $this->mTarget = $this->mRequest->getVal( 'target' );
+               $this->mSearchPrefix = $this->mRequest->getText( 'prefix' );
+               $time = $this->mRequest->getVal( 'timestamp' );
                $this->mTimestamp = $time ? wfTimestamp( TS_MW, $time ) : '';
-               $this->mFile = $request->getVal( 'file' );
-
-               $posted = $request->wasPosted() &&
-                       $wgUser->matchEditToken( $request->getVal( 'wpEditToken' ) );
-               $this->mRestore = $request->getCheck( 'restore' ) && $posted;
-               $this->mInvert = $request->getCheck( 'invert' ) && $posted;
-               $this->mPreview = $request->getCheck( 'preview' ) && $posted;
-               $this->mDiff = $request->getCheck( 'diff' );
-               $this->mComment = $request->getText( 'wpComment' );
-               $this->mUnsuppress = $request->getVal( 'wpUnsuppress' ) && $wgUser->isAllowed( 'suppressrevision' );
-               $this->mToken = $request->getVal( 'token' );
-
-               if( $par != "" ) {
-                       $this->mTarget = $par;
-               }
+               $this->mFile = $this->mRequest->getVal( 'file' );
+
+               $posted = $this->mRequest->wasPosted() &&
+                       $wgUser->matchEditToken( $this->mRequest->getVal( 'wpEditToken' ) );
+               $this->mRestore = $this->mRequest->getCheck( 'restore' ) && $posted;
+               $this->mInvert = $this->mRequest->getCheck( 'invert' ) && $posted;
+               $this->mPreview = $this->mRequest->getCheck( 'preview' ) && $posted;
+               $this->mDiff = $this->mRequest->getCheck( 'diff' );
+               $this->mComment = $this->mRequest->getText( 'wpComment' );
+               $this->mUnsuppress = $this->mRequest->getVal( 'wpUnsuppress' ) && $wgUser->isAllowed( 'suppressrevision' );
+               $this->mToken = $this->mRequest->getVal( 'token' );
+
                if ( $wgUser->isAllowed( 'undelete' ) && !$wgUser->isBlocked() ) {
-                       $this->mAllowed = true;
-               } else {
+                       $this->mAllowed = true; // user can restore
+                       $this->mCanView = true; // user can view content
+               } elseif ( $wgUser->isAllowed( 'deletedtext' ) ) {
+                       $this->mAllowed = false; // user cannot restore
+                       $this->mCanView = true; // user can view content
+               }  else { // user can only view the list of revisions
                        $this->mAllowed = false;
+                       $this->mCanView = false;
                        $this->mTimestamp = '';
                        $this->mRestore = false;
                }
-               if ( $this->mTarget !== "" ) {
-                       $this->mTargetObj = Title::newFromURL( $this->mTarget );
-               } else {
-                       $this->mTargetObj = NULL;
-               }
+
                if( $this->mRestore || $this->mInvert ) {
                        $timestamps = array();
                        $this->mFileVersions = array();
@@ -593,14 +626,34 @@ class UndeleteForm {
                }
        }
 
-       function execute() {
+       function execute( $par ) {
                global $wgOut, $wgUser;
+
+               $this->setHeaders();
+               if ( !$this->userCanExecute( $wgUser ) ) {
+                       $this->displayRestrictionError();
+                       return;
+               }
+               $this->outputHeader();
+
+               $this->loadRequest();
+
                if ( $this->mAllowed ) {
                        $wgOut->setPagetitle( wfMsg( "undeletepage" ) );
                } else {
                        $wgOut->setPagetitle( wfMsg( "viewdeletedpage" ) );
                }
 
+               if( $par != '' ) {
+                       $this->mTarget = $par;
+               }
+               if ( $this->mTarget !== '' ) {
+                       $this->mTargetObj = Title::newFromURL( $this->mTarget );
+                       $wgUser->getSkin()->setRelevantTitle( $this->mTargetObj );
+               } else {
+                       $this->mTargetObj = null;
+               }
+
                if( is_null( $this->mTargetObj ) ) {
                # Not all users can just browse every deleted page from the list
                        if( $wgUser->isAllowed( 'browsearchive' ) ) {
@@ -622,8 +675,15 @@ class UndeleteForm {
                if( $this->mFile !== null ) {
                        $file = new ArchivedFile( $this->mTargetObj, '', $this->mFile );
                        // Check if user is allowed to see this file
-                       if( !$file->userCan( File::DELETED_FILE ) ) {
-                               $wgOut->permissionRequired( 'suppressrevision' );
+                       if ( !$file->exists() ) {
+                               $wgOut->addWikiMsg( 'filedelete-nofile', $this->mFile );
+                               return;
+                       } else if( !$file->userCan( File::DELETED_FILE ) ) {
+                               if( $file->isDeleted( File::DELETED_RESTRICTED ) ) {
+                                       $wgOut->permissionRequired( 'suppressrevision' );
+                               } else {
+                                       $wgOut->permissionRequired( 'deletedtext' );
+                               }
                                return false;
                        } elseif ( !$wgUser->matchEditToken( $this->mToken, $this->mFile ) ) {
                                $this->showFileConfirmationForm( $this->mFile );
@@ -633,6 +693,11 @@ class UndeleteForm {
                        }
                }
                if( $this->mRestore && $this->mAction == "submit" ) {
+                       global $wgUploadMaintenance;
+                       if( $wgUploadMaintenance && $this->mTargetObj && $this->mTargetObj->getNamespace() == NS_FILE ) {
+                               $wgOut->wrapWikiMsg( "<div class='error'>\n$1\n</div>\n", array( 'filedelete-maintenance' ) );
+                               return;
+                       }
                        return $this->undelete();
                }
                if( $this->mInvert && $this->mAction == "submit" ) {
@@ -650,8 +715,8 @@ class UndeleteForm {
                                'method' => 'get',
                                'action' => $wgScript ) ) .
                        Xml::fieldset( wfMsg( 'undelete-search-box' ) ) .
-                       Xml::hidden( 'title',
-                               SpecialPage::getTitleFor( 'Undelete' )->getPrefixedDbKey() ) .
+                       Html::hidden( 'title',
+                               $this->getTitle()->getPrefixedDbKey() ) .
                        Xml::inputLabel( wfMsg( 'undelete-search-prefix' ),
                                'prefix', 'prefix', 20,
                                $this->mSearchPrefix ) . ' ' .
@@ -663,7 +728,7 @@ class UndeleteForm {
 
        // Generic list of deleted pages
        private function showList( $result ) {
-               global $wgLang, $wgContLang, $wgUser, $wgOut;
+               global $wgLang, $wgUser, $wgOut;
 
                if( $result->numRows() == 0 ) {
                        $wgOut->addWikiMsg( 'undelete-no-results' );
@@ -673,9 +738,9 @@ class UndeleteForm {
                $wgOut->addWikiMsg( 'undeletepagetext', $wgLang->formatNum( $result->numRows() ) );
 
                $sk = $wgUser->getSkin();
-               $undelete = SpecialPage::getTitleFor( 'Undelete' );
+               $undelete = $this->getTitle();
                $wgOut->addHTML( "<ul>\n" );
-               while( $row = $result->fetchObject() ) {
+               foreach ( $result as $row ) {
                        $title = Title::makeTitleSafe( $row->ar_namespace, $row->ar_title );
                        $link = $sk->linkKnown(
                                $undelete,
@@ -696,7 +761,7 @@ class UndeleteForm {
 
        private function showRevision( $timestamp ) {
                global $wgLang, $wgUser, $wgOut;
-               $self = SpecialPage::getTitleFor( 'Undelete' );
+
                $skin = $wgUser->getSkin();
 
                if(!preg_match("/[0-9]{14}/",$timestamp)) return 0;
@@ -711,11 +776,11 @@ class UndeleteForm {
 
                if( $rev->isDeleted(Revision::DELETED_TEXT) ) {
                        if( !$rev->userCan(Revision::DELETED_TEXT) ) {
-                               $wgOut->wrapWikiMsg( "<div class='mw-warning plainlinks'>\n$1</div>\n", 'rev-deleted-text-permission' );
+                               $wgOut->wrapWikiMsg( "<div class='mw-warning plainlinks'>\n$1\n</div>\n", 'rev-deleted-text-permission' );
                                return;
                        } else {
-                               $wgOut->wrapWikiMsg( "<div class='mw-warning plainlinks'>\n$1</div>\n", 'rev-deleted-text-view' );
-                               $wgOut->addHTML( '<br/>' );
+                               $wgOut->wrapWikiMsg( "<div class='mw-warning plainlinks'>\n$1\n</div>\n", 'rev-deleted-text-view' );
+                               $wgOut->addHTML( '<br />' );
                                // and we are allowed to see...
                        }
                }
@@ -723,7 +788,7 @@ class UndeleteForm {
                $wgOut->setPageTitle( wfMsg( 'undeletepage' ) );
 
                $link = $skin->linkKnown(
-                       SpecialPage::getTitleFor( 'Undelete', $this->mTargetObj->getPrefixedDBkey() ),
+                       $this->getTitle( $this->mTargetObj->getPrefixedDBkey() ),
                        htmlspecialchars( $this->mTargetObj->getPrefixedText() )
                );
 
@@ -754,7 +819,27 @@ class UndeleteForm {
                        $openDiv = '<div id="mw-undelete-revision">';
                }
 
-               $wgOut->addHTML( $openDiv . wfMsgWikiHtml( 'undelete-revision', $link, $time, $user, $d, $t ) . '</div>' );
+               // Revision delete links
+               $canHide = $wgUser->isAllowed( 'deleterevision' );
+               if( $this->mDiff ) {
+                       $revdlink = ''; // diffs already have revision delete links
+               } else if( $canHide || ($rev->getVisibility() && $wgUser->isAllowed('deletedhistory')) ) {
+                       if( !$rev->userCan(Revision::DELETED_RESTRICTED ) ) {
+                               $revdlink = $skin->revDeleteLinkDisabled( $canHide ); // revision was hidden from sysops
+                       } else {
+                               $query = array(
+                                       'type'   => 'archive',
+                                       'target' => $this->mTargetObj->getPrefixedDBkey(),
+                                       'ids'    => $rev->getTimestamp()
+                               );
+                               $revdlink = $skin->revDeleteLink( $query,
+                                       $rev->isDeleted( File::DELETED_RESTRICTED ), $canHide );
+                       }
+               } else {
+                       $revdlink = '';
+               }
+
+               $wgOut->addHTML( $openDiv . $revdlink . wfMsgWikiHtml( 'undelete-revision', $link, $time, $user, $d, $t ) . '</div>' );
                wfRunHooks( 'UndeleteShowRevision', array( $this->mTargetObj, $rev ) );
 
                if( $this->mPreview ) {
@@ -774,7 +859,7 @@ class UndeleteForm {
                        Xml::openElement( 'div' ) .
                        Xml::openElement( 'form', array(
                                'method' => 'post',
-                               'action' => $self->getLocalURL( array( 'action' => 'submit' ) ) ) ) .
+                               'action' => $this->getTitle()->getLocalURL( array( 'action' => 'submit' ) ) ) ) .
                        Xml::element( 'input', array(
                                'type' => 'hidden',
                                'name' => 'target',
@@ -802,14 +887,15 @@ class UndeleteForm {
        /**
         * Build a diff display between this and the previous either deleted
         * or non-deleted edit.
-        * @param Revision $previousRev
-        * @param Revision $currentRev
-        * @return string HTML
+        *
+        * @param $previousRev Revision
+        * @param $currentRev Revision
+        * @return String: HTML
         */
        function showDiff( $previousRev, $currentRev ) {
                global $wgOut;
 
-               $diffEngine = new DifferenceEngine();
+               $diffEngine = new DifferenceEngine( $previousRev->getTitle() );
                $diffEngine->showDiffStyle();
                $wgOut->addHTML(
                        "<div>" .
@@ -829,40 +915,40 @@ class UndeleteForm {
                        $diffEngine->generateDiffBody(
                                $previousRev->getText(), $currentRev->getText() ) .
                        "</table>" .
-                       "</div>\n" );
-
+                       "</div>\n"
+               );
        }
 
        private function diffHeader( $rev, $prefix ) {
-               global $wgUser, $wgLang, $wgLang;
+               global $wgUser, $wgLang;
                $sk = $wgUser->getSkin();
                $isDeleted = !( $rev->getId() && $rev->getTitle() );
                if( $isDeleted ) {
-                       /// @fixme $rev->getTitle() is null for deleted revs...?
-                       $targetPage = SpecialPage::getTitleFor( 'Undelete' );
+                       /// @todo Fixme: $rev->getTitle() is null for deleted revs...?
+                       $targetPage = $this->getTitle();
                        $targetQuery = array(
                                'target' => $this->mTargetObj->getPrefixedText(),
                                'timestamp' => wfTimestamp( TS_MW, $rev->getTimestamp() )
                        );
                } else {
-                       /// @fixme getId() may return non-zero for deleted revs...
+                       /// @todo Fixme getId() may return non-zero for deleted revs...
                        $targetPage = $rev->getTitle();
                        $targetQuery = array( 'oldid' => $rev->getId() );
                }
-               // Add show/hide link if available
-               if( $wgUser->isAllowed( 'deleterevision' ) ) {
-                       // If revision was hidden from sysops
+               // Add show/hide deletion links if available
+               $canHide = $wgUser->isAllowed( 'deleterevision' );
+               if( $canHide || ($rev->getVisibility() && $wgUser->isAllowed('deletedhistory')) ) {
+                       $del = ' ';
                        if( !$rev->userCan( Revision::DELETED_RESTRICTED ) ) {
-                               $del = ' ' . Xml::tags( 'span', array( 'class'=>'mw-revdelundel-link' ),
-                                       '(' . wfMsgHtml('rev-delundel') . ')' );
-                       // Otherwise, show the link...
+                               $del .= $sk->revDeleteLinkDisabled( $canHide ); // revision was hidden from sysops
                        } else {
-                               $query = array( 
-                                       'type' => 'archive',
+                               $query = array(
+                                       'type'   => 'archive',
                                        'target' => $this->mTargetObj->getPrefixedDbkey(),
-                                       'ids' => $rev->getTimestamp() );
-                               $del = ' ' . $sk->revDeleteLink( $query,
-                                       $rev->isDeleted( Revision::DELETED_RESTRICTED ) );
+                                       'ids'    => $rev->getTimestamp()
+                               );
+                               $del .= $sk->revDeleteLink( $query,
+                                       $rev->isDeleted( Revision::DELETED_RESTRICTED ), $canHide );
                        }
                } else {
                        $del = '';
@@ -882,10 +968,10 @@ class UndeleteForm {
                                ) .
                        '</strong></div>' .
                        '<div id="mw-diff-'.$prefix.'title2">' .
-                               $sk->revUserTools( $rev ) . '<br/>' .
+                               $sk->revUserTools( $rev ) . '<br />' .
                        '</div>' .
                        '<div id="mw-diff-'.$prefix.'title3">' .
-                               $sk->revComment( $rev ) . $del . '<br/>' .
+                               $sk->revComment( $rev ) . $del . '<br />' .
                        '</div>';
        }
 
@@ -899,10 +985,10 @@ class UndeleteForm {
                        $this->mTargetObj->getText(),
                        $wgLang->date( $file->getTimestamp() ),
                        $wgLang->time( $file->getTimestamp() ) );
-               $wgOut->addHTML( 
-                       Xml::openElement( 'form', array( 
+               $wgOut->addHTML(
+                       Xml::openElement( 'form', array(
                                'method' => 'POST',
-                               'action' => SpecialPage::getTitleFor( 'Undelete' )->getLocalUrl(
+                               'action' => $this->getTitle()->getLocalUrl(
                                        'target=' . urlencode( $this->mTarget ) .
                                        '&file=' . urlencode( $key ) .
                                        '&token=' . urlencode( $wgUser->editToken( $key ) ) )
@@ -930,13 +1016,13 @@ class UndeleteForm {
 
                global $IP;
                require_once( "$IP/includes/StreamFile.php" );
-               $repo = RepoGroup::singleton()->getLocalRepo();         
+               $repo = RepoGroup::singleton()->getLocalRepo();
                $path = $repo->getZonePath( 'deleted' ) . '/' . $repo->getDeletedHashPath( $key ) . $key;
                wfStreamFile( $path );
        }
 
        private function showHistory( ) {
-               global $wgLang, $wgUser, $wgOut;
+               global $wgUser, $wgOut;
 
                $sk = $wgUser->getSkin();
                if( $this->mAllowed ) {
@@ -945,7 +1031,7 @@ class UndeleteForm {
                        $wgOut->setPagetitle( wfMsg( 'viewdeletedpage' ) );
                }
 
-               $wgOut->wrapWikiMsg(  "<div class='mw-undelete-pagetitle'>\n$1</div>\n", array ( 'undeletepagetitle', $this->mTargetObj->getPrefixedText() ) );
+               $wgOut->wrapWikiMsg(  "<div class='mw-undelete-pagetitle'>\n$1\n</div>\n", array ( 'undeletepagetitle', $this->mTargetObj->getPrefixedText() ) );
 
                $archive = new PageArchive( $this->mTargetObj );
                /*
@@ -974,7 +1060,7 @@ class UndeleteForm {
                # Batch existence check on user and talk pages
                if( $haveRevisions ) {
                        $batch = new LinkBatch();
-                       while( $row = $revisions->fetchObject() ) {
+                       foreach ( $revisions as $row ) {
                                $batch->addObj( Title::makeTitleSafe( NS_USER, $row->ar_user_text ) );
                                $batch->addObj( Title::makeTitleSafe( NS_USER_TALK, $row->ar_user_text ) );
                        }
@@ -983,7 +1069,7 @@ class UndeleteForm {
                }
                if( $haveFiles ) {
                        $batch = new LinkBatch();
-                       while( $row = $files->fetchObject() ) {
+                       foreach ( $files as $row ) {
                                $batch->addObj( Title::makeTitleSafe( NS_USER, $row->fa_user_text ) );
                                $batch->addObj( Title::makeTitleSafe( NS_USER_TALK, $row->fa_user_text ) );
                        }
@@ -992,8 +1078,7 @@ class UndeleteForm {
                }
 
                if ( $this->mAllowed ) {
-                       $titleObj = SpecialPage::getTitleFor( "Undelete" );
-                       $action = $titleObj->getLocalURL( array( 'action' => 'submit' ) );
+                       $action = $this->getTitle()->getLocalURL( array( 'action' => 'submit' ) );
                        # Start the form here
                        $top = Xml::openElement( 'form', array( 'method' => 'post', 'action' => $action, 'id' => 'undelete' ) );
                        $wgOut->addHTML( $top );
@@ -1014,7 +1099,7 @@ class UndeleteForm {
                        if( $wgUser->isAllowed( 'suppressrevision' ) ) {
                                $unsuppressBox =
                                        "<tr>
-                                               <td>&nbsp;</td>
+                                               <td>&#160;</td>
                                                <td class='mw-input'>" .
                                                        Xml::checkLabel( wfMsg('revdelete-unsuppress'), 'wpUnsuppress',
                                                                'mw-undelete-unsuppress', $this->mUnsuppress ).
@@ -1040,7 +1125,7 @@ class UndeleteForm {
                                                "</td>
                                        </tr>
                                        <tr>
-                                               <td>&nbsp;</td>
+                                               <td>&#160;</td>
                                                <td class='mw-submit'>" .
                                                        Xml::submitButton( wfMsg( 'undeletebtn' ), array( 'name' => 'restore', 'id' => 'mw-undelete-submit' ) ) . ' ' .
                                                        Xml::element( 'input', array( 'type' => 'reset', 'value' => wfMsg( 'undeletereset' ), 'id' => 'mw-undelete-reset' ) ) . ' ' .
@@ -1059,11 +1144,10 @@ class UndeleteForm {
                if( $haveRevisions ) {
                        # The page's stored (deleted) history:
                        $wgOut->addHTML("<ul>");
-                       $target = urlencode( $this->mTarget );
                        $remaining = $revisions->numRows();
                        $earliestLiveTime = $this->mTargetObj->getEarliestRevTime();
 
-                       while( $row = $revisions->fetchObject() ) {
+                       foreach ( $revisions as $row ) {
                                $remaining--;
                                $wgOut->addHTML( $this->formatRevisionRow( $row, $earliestLiveTime, $remaining, $sk ) );
                        }
@@ -1076,7 +1160,7 @@ class UndeleteForm {
                if( $haveFiles ) {
                        $wgOut->addHTML( Xml::element( 'h2', null, wfMsg( 'filehist' ) ) . "\n" );
                        $wgOut->addHTML( "<ul>" );
-                       while( $row = $files->fetchObject() ) {
+                       foreach ( $files as $row ) {
                                $wgOut->addHTML( $this->formatFileRow( $row, $sk ) );
                        }
                        $files->free();
@@ -1085,8 +1169,8 @@ class UndeleteForm {
 
                if ( $this->mAllowed ) {
                        # Slip in the hidden controls here
-                       $misc  = Xml::hidden( 'target', $this->mTarget );
-                       $misc .= Xml::hidden( 'wpEditToken', $wgUser->editToken() );
+                       $misc  = Html::hidden( 'target', $this->mTarget );
+                       $misc .= Html::hidden( 'wpEditToken', $wgUser->editToken() );
                        $misc .= Xml::closeElement( 'form' );
                        $wgOut->addHTML( $misc );
                }
@@ -1097,12 +1181,13 @@ class UndeleteForm {
        private function formatRevisionRow( $row, $earliestLiveTime, $remaining, $sk ) {
                global $wgUser, $wgLang;
 
-               $rev = Revision::newFromArchiveRow( $row, 
+               $rev = Revision::newFromArchiveRow( $row,
                        array( 'page' => $this->mTargetObj->getArticleId() ) );
                $stxt = '';
                $ts = wfTimestamp( TS_MW, $row->ar_timestamp );
+               // Build checkboxen...
                if( $this->mAllowed ) {
-                       if( $this->mInvert){
+                       if( $this->mInvert ) {
                                if( in_array( $ts, $this->mTargetTimestamp ) ) {
                                        $checkBox = Xml::check( "ts$ts");
                                } else {
@@ -1111,12 +1196,18 @@ class UndeleteForm {
                        } else {
                                $checkBox = Xml::check( "ts$ts" );
                        }
-                       $titleObj = SpecialPage::getTitleFor( "Undelete" );
-                       $pageLink = $this->getPageLink( $rev, $titleObj, $ts, $sk );
+               } else {
+                       $checkBox = '';
+               }
+               // Build page & diff links...
+               if( $this->mCanView ) {
+                       $titleObj = $this->getTitle();
                        # Last link
                        if( !$rev->userCan( Revision::DELETED_TEXT ) ) {
+                               $pageLink = htmlspecialchars( $wgLang->timeanddate( $ts, true ) );
                                $last = wfMsgHtml('diff');
                        } else if( $remaining > 0 || ($earliestLiveTime && $ts > $earliestLiveTime) ) {
+                               $pageLink = $this->getPageLink( $rev, $titleObj, $ts, $sk );
                                $last = $sk->linkKnown(
                                        $titleObj,
                                        wfMsgHtml('diff'),
@@ -1128,35 +1219,38 @@ class UndeleteForm {
                                        )
                                );
                        } else {
+                               $pageLink = $this->getPageLink( $rev, $titleObj, $ts, $sk );
                                $last = wfMsgHtml('diff');
                        }
                } else {
-                       $checkBox = '';
                        $pageLink = htmlspecialchars( $wgLang->timeanddate( $ts, true ) );
                        $last = wfMsgHtml('diff');
                }
+               // User links
                $userLink = $sk->revUserTools( $rev );
-
-               if(!is_null($size = $row->ar_len)) {
+               // Revision text size
+               if( !is_null($size = $row->ar_len) ) {
                        $stxt = $sk->formatRevisionSize( $size );
                }
+               // Edit summary
                $comment = $sk->revComment( $rev );
-               $revdlink = '';
-               if( $wgUser->isAllowed( 'deleterevision' ) ) {
+               // Revision delete links
+               $canHide = $wgUser->isAllowed( 'deleterevision' );
+               if( $canHide || ($rev->getVisibility() && $wgUser->isAllowed('deletedhistory')) ) {
                        if( !$rev->userCan( Revision::DELETED_RESTRICTED ) ) {
-                       // If revision was hidden from sysops
-                               $revdlink = Xml::tags( 'span', array( 'class'=>'mw-revdelundel-link' ),
-                                       '('.wfMsgHtml('rev-delundel').')' );
+                               $revdlink = $sk->revDeleteLinkDisabled( $canHide ); // revision was hidden from sysops
                        } else {
                                $query = array(
-                                       'type' => 'archive',
+                                       'type'   => 'archive',
                                        'target' => $this->mTargetObj->getPrefixedDBkey(),
-                                       'ids' => $ts
+                                       'ids'    => $ts
                                );
-                               $revdlink = $sk->revDeleteLink( $query, $rev->isDeleted( Revision::DELETED_RESTRICTED ) );
+                               $revdlink = $sk->revDeleteLink( $query,
+                                       $rev->isDeleted( Revision::DELETED_RESTRICTED ), $canHide );
                        }
+               } else {
+                       $revdlink = '';
                }
-
                return "<li>$checkBox $revdlink ($last) $pageLink . . $userLink $stxt $comment</li>";
        }
 
@@ -1169,14 +1263,12 @@ class UndeleteForm {
                if( $this->mAllowed && $row->fa_storage_key ) {
                        $checkBox = Xml::check( "fileid" . $row->fa_id );
                        $key = urlencode( $row->fa_storage_key );
-                       $target = urlencode( $this->mTarget );
-                       $titleObj = SpecialPage::getTitleFor( "Undelete" );
-                       $pageLink = $this->getFileLink( $file, $titleObj, $ts, $key, $sk );
+                       $pageLink = $this->getFileLink( $file, $this->getTitle(), $ts, $key, $sk );
                } else {
                        $checkBox = '';
                        $pageLink = $wgLang->timeanddate( $ts, true );
                }
-               $userLink = $this->getFileUser( $file, $sk );
+               $userLink = $this->getFileUser( $file, $sk );
                $data =
                        wfMsg( 'widthheight',
                                $wgLang->formatNum( $row->fa_width ),
@@ -1186,19 +1278,22 @@ class UndeleteForm {
                        ')';
                $data = htmlspecialchars( $data );
                $comment = $this->getFileComment( $file, $sk );
-               $revdlink = '';
-               if( $wgUser->isAllowed( 'deleterevision' ) ) {
+               // Add show/hide deletion links if available
+               $canHide = $wgUser->isAllowed( 'deleterevision' );
+               if( $canHide || ($file->getVisibility() && $wgUser->isAllowed('deletedhistory')) ) {
                        if( !$file->userCan(File::DELETED_RESTRICTED ) ) {
-                       // If revision was hidden from sysops
-                               $revdlink = Xml::tags( 'span', array( 'class'=>'mw-revdelundel-link' ), '('.wfMsgHtml('rev-delundel').')' );
+                               $revdlink = $sk->revDeleteLinkDisabled( $canHide ); // revision was hidden from sysops
                        } else {
                                $query = array(
                                        'type' => 'filearchive',
                                        'target' => $this->mTargetObj->getPrefixedDBkey(),
                                        'ids' => $row->fa_id
                                );
-                               $revdlink = $sk->revDeleteLink( $query, $file->isDeleted( File::DELETED_RESTRICTED ) );
+                               $revdlink = $sk->revDeleteLink( $query,
+                                       $file->isDeleted( File::DELETED_RESTRICTED ), $canHide );
                        }
+               } else {
+                       $revdlink = '';
                }
                return "<li>$checkBox $revdlink $pageLink . . $userLink $data $comment</li>\n";
        }
@@ -1232,7 +1327,8 @@ class UndeleteForm {
 
        /**
         * Fetch image view link if it's available to all users
-        * @return string
+        *
+        * @return String: HTML fragment
         */
        function getFileLink( $file, $titleObj, $ts, $key, $sk ) {
                global $wgLang, $wgUser;
@@ -1258,7 +1354,8 @@ class UndeleteForm {
 
        /**
         * Fetch file's user id if it's available to this user
-        * @return string
+        *
+        * @return String: HTML fragment
         */
        function getFileUser( $file, $sk ) {
                if( !$file->userCan(File::DELETED_USER) ) {
@@ -1274,7 +1371,8 @@ class UndeleteForm {
 
        /**
         * Fetch file upload comment if it's available to this user
-        * @return string
+        *
+        * @return String: HTML fragment
         */
        function getFileComment( $file, $sk ) {
                if( !$file->userCan(File::DELETED_COMMENT) ) {