Merge "Exclude redirects from Special:Fewestrevisions"

[lhc/web/wiklou.git] / includes / specials / SpecialUncategorizedimages.php

diff --git a/includes/specials/SpecialUncategorizedimages.php b/includes/specials/SpecialUncategorizedimages.php
index 986ec96..ed2d5cf 100644 (file)
--- a/includes/specials/SpecialUncategorizedimages.php
+++ b/includes/specials/SpecialUncategorizedimages.php
@@ -1,6 +1,21 @@
 <?php
 /**
- * Special page lists images which haven't been categorised
+ * Implements Special:Uncategorizedimages
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ * http://www.gnu.org/copyleft/gpl.html
  *
  * @file
  * @ingroup SpecialPage
@@ -8,12 +23,15 @@
  */
 
 /**
+ * Special page lists images which haven't been categorised
+ *
  * @ingroup SpecialPage
+ * @todo FIXME: Use an instance of UncategorizedPagesPage or something
  */
 class UncategorizedImagesPage extends ImageQueryPage {
-
-       function getName() {
-               return 'Uncategorizedimages';
+       function __construct( $name = 'Uncategorizedimages' ) {
+               parent::__construct( $name );
+               $this->addHelpLink( 'Help:Categories' );
        }
 
        function sortDescending() {
@@ -28,21 +46,21 @@ class UncategorizedImagesPage extends ImageQueryPage {
                return false;
        }
 
-       function getSQL() {
-               $dbr = wfGetDB( DB_SLAVE );
-               list( $page, $categorylinks ) = $dbr->tableNamesN( 'page', 'categorylinks' );
-               $ns = NS_IMAGE;
-
-               return "SELECT 'Uncategorizedimages' AS type, page_namespace AS namespace,
-                               page_title AS title, page_title AS value
-                               FROM {$page} LEFT JOIN {$categorylinks} ON page_id = cl_from
-                               WHERE cl_from IS NULL AND page_namespace = {$ns} AND page_is_redirect = 0";
+       function getQueryInfo() {
+               return [
+                       'tables' => [ 'page', 'categorylinks' ],
+                       'fields' => [ 'namespace' => 'page_namespace',
+                               'title' => 'page_title',
+                               'value' => 'page_title' ],
+                       'conds' => [ 'cl_from IS NULL',
+                               'page_namespace' => NS_FILE,
+                               'page_is_redirect' => 0 ],
+                       'join_conds' => [ 'categorylinks' => [
+                               'LEFT JOIN', 'cl_from=page_id' ] ]
+               ];
        }
 
-}
-
-function wfSpecialUncategorizedimages() {
-       $uip = new UncategorizedImagesPage();
-       list( $limit, $offset ) = wfCheckLimits();
-       return $uip->doQuery( $offset, $limit );
+       protected function getGroupName() {
+               return 'maintenance';
+       }
 }