Merge "Move the global to the place it is needed."

[lhc/web/wiklou.git] / includes / specials / SpecialPopularpages.php

diff --git a/includes/specials/SpecialPopularpages.php b/includes/specials/SpecialPopularpages.php
index 99b586e..2a80f65 100644 (file)
--- a/includes/specials/SpecialPopularpages.php
+++ b/includes/specials/SpecialPopularpages.php
@@ -27,7 +27,6 @@
  * @ingroup SpecialPage
  */
 class PopularPagesPage extends QueryPage {
-
        function __construct( $name = 'Popularpages' ) {
                parent::__construct( $name );
        }
@@ -42,27 +41,37 @@ class PopularPagesPage extends QueryPage {
        }
 
        function getQueryInfo() {
-               return array (
+               return array(
                        'tables' => array( 'page' ),
-                       'fields' => array( 'namespace' => 'page_namespace',
-                                       'title' => 'page_title',
-                                       'value' => 'page_counter' ),
-                       'conds' => array( 'page_is_redirect' => 0,
-                                       'page_namespace' => MWNamespace::getContentNamespaces() ) );
+                       'fields' => array(
+                               'namespace' => 'page_namespace',
+                               'title' => 'page_title',
+                               'value' => 'page_counter' ),
+                       'conds' => array(
+                               'page_is_redirect' => 0,
+                               'page_namespace' => MWNamespace::getContentNamespaces()
+                       )
+               );
        }
 
        /**
-        * @param $skin Skin
-        * @param $result
+        * @param Skin $skin
+        * @param object $result Result row
         * @return string
         */
        function formatResult( $skin, $result ) {
                global $wgContLang;
 
                $title = Title::makeTitleSafe( $result->namespace, $result->title );
-               if( !$title ) {
-                       return Html::element( 'span', array( 'class' => 'mw-invalidtitle' ),
-                               Linker::getInvalidTitleDescription( $this->getContext(), $result->namespace, $result->title ) );
+               if ( !$title ) {
+                       return Html::element(
+                               'span',
+                               array( 'class' => 'mw-invalidtitle' ),
+                               Linker::getInvalidTitleDescription(
+                                       $this->getContext(),
+                                       $result->namespace,
+                                       $result->title )
+                       );
                }
 
                $link = Linker::linkKnown(
@@ -70,6 +79,11 @@ class PopularPagesPage extends QueryPage {
                        htmlspecialchars( $wgContLang->convert( $title->getPrefixedText() ) )
                );
                $nv = $this->msg( 'nviews' )->numParams( $result->value )->escaped();
+
                return $this->getLanguage()->specialList( $link, $nv );
        }
+
+       protected function getGroupName() {
+               return 'wiki';
+       }
 }