Add a way for packagers to override some installation details
[lhc/web/wiklou.git] / includes / specials / SpecialContributions.php
index a6741bf..62b34ad 100644 (file)
@@ -44,17 +44,17 @@ class SpecialContributions extends SpecialPage {
                $this->opts = array();
                $request = $this->getRequest();
 
-               if( $par == 'newbies' ) {
-                       $target = 'newbies';
-                       $this->opts['contribs'] = 'newbie';
-               } elseif( $par !== null ) {
+               if ( $par !== null ) {
                        $target = $par;
                } else {
                        $target = $request->getVal( 'target' );
                }
 
                // check for radiobox
-               if( $request->getVal( 'contribs' ) == 'newbie' ) {
+               if ( $request->getVal( 'contribs' ) == 'newbie' ) {
+                       $target = 'newbies';
+                       $this->opts['contribs'] = 'newbie';
+               } elseif ( $par === 'newbies' ) { // b/c for WMF
                        $target = 'newbies';
                        $this->opts['contribs'] = 'newbie';
                } else {
@@ -63,54 +63,60 @@ class SpecialContributions extends SpecialPage {
 
                $this->opts['deletedOnly'] = $request->getBool( 'deletedOnly' );
 
-               if( !strlen( $target ) ) {
+               if ( !strlen( $target ) ) {
                        $out->addHTML( $this->getForm() );
                        return;
                }
 
                $user = $this->getUser();
 
-               $this->opts['limit'] = $request->getInt( 'limit', $user->getOption('rclimit') );
+               $this->opts['limit'] = $request->getInt( 'limit', $user->getOption( 'rclimit' ) );
                $this->opts['target'] = $target;
                $this->opts['topOnly'] = $request->getBool( 'topOnly' );
 
-               $userObj = User::newFromName( $target, false );
-               if( !$userObj ) {
+               $nt = Title::makeTitleSafe( NS_USER, $target );
+               if ( !$nt ) {
+                       $out->addHTML( $this->getForm() );
+                       return;
+               }
+               $userObj = User::newFromName( $nt->getText(), false );
+               if ( !$userObj ) {
                        $out->addHTML( $this->getForm() );
                        return;
                }
-               $nt = $userObj->getUserPage();
                $id = $userObj->getID();
 
-               if( $this->opts['contribs'] != 'newbie' ) {
+               if ( $this->opts['contribs'] != 'newbie' ) {
                        $target = $nt->getText();
                        $out->addSubtitle( $this->contributionsSub( $userObj ) );
-                       $out->setHTMLTitle( $this->msg( 'pagetitle', wfMsgExt( 'contributions-title', array( 'parsemag' ), $target ) ) );
+                       $out->setHTMLTitle( $this->msg( 'pagetitle', $this->msg( 'contributions-title', $target )->plain() ) );
                        $this->getSkin()->setRelevantUser( $userObj );
                } else {
-                       $out->addSubtitle( $this->msg( 'sp-contributions-newbies-sub') );
-                       $out->setHTMLTitle( $this->msg( 'pagetitle', wfMsg( 'sp-contributions-newbies-title' ) ) );
+                       $out->addSubtitle( $this->msg( 'sp-contributions-newbies-sub' ) );
+                       $out->setHTMLTitle( $this->msg( 'pagetitle', $this->msg( 'sp-contributions-newbies-title' )->plain() ) );
                }
 
-               if( ( $ns = $request->getVal( 'namespace', null ) ) !== null && $ns !== '' ) {
+               if ( ( $ns = $request->getVal( 'namespace', null ) ) !== null && $ns !== '' ) {
                        $this->opts['namespace'] = intval( $ns );
                } else {
                        $this->opts['namespace'] = '';
                }
 
+               $this->opts['associated'] = $request->getBool( 'associated' );
+
                $this->opts['nsInvert'] = (bool) $request->getVal( 'nsInvert' );
 
                $this->opts['tagfilter'] = (string) $request->getVal( 'tagfilter' );
 
                // Allows reverts to have the bot flag in recent changes. It is just here to
                // be passed in the form at the top of the page
-               if( $user->isAllowed( 'markbotedits' ) && $request->getBool( 'bot' ) ) {
+               if ( $user->isAllowed( 'markbotedits' ) && $request->getBool( 'bot' ) ) {
                        $this->opts['bot'] = '1';
                }
 
                $skip = $request->getText( 'offset' ) || $request->getText( 'dir' ) == 'prev';
                # Offset overrides year/month selection
-               if( $skip ) {
+               if ( $skip ) {
                        $this->opts['year'] = '';
                        $this->opts['month'] = '';
                } else {
@@ -119,7 +125,7 @@ class SpecialContributions extends SpecialPage {
                }
 
                $feedType = $request->getVal( 'feed' );
-               if( $feedType ) {
+               if ( $feedType ) {
                        // Maintain some level of backwards compatability
                        // If people request feeds using the old parameters, redirect to API
                        $apiParams = array(
@@ -159,7 +165,7 @@ class SpecialContributions extends SpecialPage {
 
                        $out->addHTML( $this->getForm() );
 
-                       $pager = new ContribsPager( array(
+                       $pager = new ContribsPager( $this->getContext(), array(
                                'target' => $target,
                                'contribs' => $this->opts['contribs'],
                                'namespace' => $this->opts['namespace'],
@@ -168,13 +174,14 @@ class SpecialContributions extends SpecialPage {
                                'deletedOnly' => $this->opts['deletedOnly'],
                                'topOnly' => $this->opts['topOnly'],
                                'nsInvert' => $this->opts['nsInvert'],
+                               'associated' => $this->opts['associated'],
                        ) );
-                       if( !$pager->getNumRows() ) {
+                       if ( !$pager->getNumRows() ) {
                                $out->addWikiMsg( 'nocontribs', $target );
                        } else {
                                # Show a message about slave lag, if applicable
                                $lag = wfGetLB()->safeGetLag( $pager->getDatabase() );
-                               if( $lag > 0 )
+                               if ( $lag > 0 )
                                        $out->showLagWarning( $lag );
 
                                $out->addHTML(
@@ -185,19 +192,21 @@ class SpecialContributions extends SpecialPage {
                        }
                        $out->preventClickjacking( $pager->getPreventClickjacking() );
 
+
                        # Show the appropriate "footer" message - WHOIS tools, etc.
-                       if( $this->opts['contribs'] != 'newbie' ) {
+                       if ( $this->opts['contribs'] == 'newbie' ) {
+                               $message = 'sp-contributions-footer-newbies';
+                       } elseif( IP::isIPAddress( $target ) ) {
+                               $message = 'sp-contributions-footer-anon';
+                       } elseif( $userObj->isAnon() ) {
+                               // No message for non-existing users
+                               $message = '';
+                       } else {
                                $message = 'sp-contributions-footer';
-                               if ( IP::isIPAddress( $target ) ) {
-                                       $message = 'sp-contributions-footer-anon';
-                               } else {
-                                       if ( $userObj->isAnon() ) {
-                                               // No message for non-existing users
-                                               return;
-                                       }
-                               }
+                       }
 
-                               if( !wfMessage( $message, $target )->isDisabled() ) {
+                       if( $message ) {
+                               if ( !$this->msg( $message, $target )->isDisabled() ) {
                                        $out->wrapWikiMsg(
                                                "<div class='mw-contributions-footer'>\n$1\n</div>",
                                                array( $message, $target ) );
@@ -220,12 +229,15 @@ class SpecialContributions extends SpecialPage {
                }
                $nt = $userObj->getUserPage();
                $talk = $userObj->getTalkPage();
-               if( $talk ) {
-                       $tools = self::getUserLinks( $nt, $talk, $userObj, $this->getUser() );
+               $links = '';
+               if ( $talk ) {
+                       $tools = $this->getUserLinks( $nt, $talk, $userObj );
                        $links = $this->getLanguage()->pipeList( $tools );
 
                        // Show a note if the user is blocked and display the last block log entry.
-                       if ( $userObj->isBlocked() ) {
+                       // Do not expose the autoblocks, since that may lead to a leak of accounts' IPs,
+                       // and also this will display a totally irrelevant log entry as a current block.
+                       if ( $userObj->isBlocked() && $userObj->getBlock()->getType() != Block::TYPE_AUTO ) {
                                $out = $this->getOutput(); // showLogExtract() wants first parameter by reference
                                LogEventsList::showLogExtract(
                                        $out,
@@ -251,9 +263,11 @@ class SpecialContributions extends SpecialPage {
                // languages that want to put the "for" bit right after $user but before
                // $links.  If 'contribsub' is around, use it for reverse compatibility,
                // otherwise use 'contribsub2'.
+               // @todo Should this be removed at some point?
                $oldMsg = $this->msg( 'contribsub' );
                if ( $oldMsg->exists() ) {
-                       return $oldMsg->rawParams( "$user ($links)" );
+                       $linksWithParentheses = $this->msg( 'parentheses' )->rawParams( $links )->escaped();
+                       return $oldMsg->rawParams( "$user $linksWithParentheses" );
                } else {
                        return $this->msg( 'contribsub2' )->rawParams( $user, $links );
                }
@@ -264,37 +278,37 @@ class SpecialContributions extends SpecialPage {
         * @param $userpage Title: Target user page
         * @param $talkpage Title: Talk page
         * @param $target User: Target user object
-        * @param $subject User: The viewing user ($wgUser might be still checked in some cases)
+        * @return array
         */
-       public static function getUserLinks( Title $userpage, Title $talkpage, User $target, User $subject ) {
+       public function getUserLinks( Title $userpage, Title $talkpage, User $target ) {
 
                $id = $target->getId();
                $username = $target->getName();
 
-               $tools[] = Linker::link( $talkpage, wfMsgHtml( 'sp-contributions-talk' ) );
+               $tools[] = Linker::link( $talkpage, $this->msg( 'sp-contributions-talk' )->escaped() );
 
-               if( ( $id !== null ) || ( $id === null && IP::isIPAddress( $username ) ) ) {
-                       if( $subject->isAllowed( 'block' ) ) { # Block / Change block / Unblock links
+               if ( ( $id !== null ) || ( $id === null && IP::isIPAddress( $username ) ) ) {
+                       if ( $this->getUser()->isAllowed( 'block' ) ) { # Block / Change block / Unblock links
                                if ( $target->isBlocked() ) {
                                        $tools[] = Linker::linkKnown( # Change block link
                                                SpecialPage::getTitleFor( 'Block', $username ),
-                                               wfMsgHtml( 'change-blocklink' )
+                                               $this->msg( 'change-blocklink' )->escaped()
                                        );
                                        $tools[] = Linker::linkKnown( # Unblock link
                                                SpecialPage::getTitleFor( 'Unblock', $username ),
-                                               wfMsgHtml( 'unblocklink' )
+                                               $this->msg( 'unblocklink' )->escaped()
                                        );
                                } else { # User is not blocked
                                        $tools[] = Linker::linkKnown( # Block link
                                                SpecialPage::getTitleFor( 'Block', $username ),
-                                               wfMsgHtml( 'blocklink' )
+                                               $this->msg( 'blocklink' )->escaped()
                                        );
                                }
                        }
                        # Block log link
                        $tools[] = Linker::linkKnown(
                                SpecialPage::getTitleFor( 'Log', 'block' ),
-                               wfMsgHtml( 'sp-contributions-blocklog' ),
+                               $this->msg( 'sp-contributions-blocklog' )->escaped(),
                                array(),
                                array(
                                        'page' => $userpage->getPrefixedText()
@@ -304,30 +318,30 @@ class SpecialContributions extends SpecialPage {
                # Uploads
                $tools[] = Linker::linkKnown(
                        SpecialPage::getTitleFor( 'Listfiles', $username ),
-                       wfMsgHtml( 'sp-contributions-uploads' )
+                       $this->msg( 'sp-contributions-uploads' )->escaped()
                );
 
                # Other logs link
                $tools[] = Linker::linkKnown(
                        SpecialPage::getTitleFor( 'Log', $username ),
-                       wfMsgHtml( 'sp-contributions-logs' )
+                       $this->msg( 'sp-contributions-logs' )->escaped()
                );
 
                # Add link to deleted user contributions for priviledged users
-               if( $subject->isAllowed( 'deletedhistory' ) ) {
+               if ( $this->getUser()->isAllowed( 'deletedhistory' ) ) {
                        $tools[] = Linker::linkKnown(
                                SpecialPage::getTitleFor( 'DeletedContributions', $username ),
-                               wfMsgHtml( 'sp-contributions-deleted' )
+                               $this->msg( 'sp-contributions-deleted' )->escaped()
                        );
                }
 
                # Add a link to change user rights for privileged users
                $userrightsPage = new UserrightsPage();
-               $userrightsPage->getContext()->setUser( $subject );
-               if( $id !== null && $userrightsPage->userCanChangeRights( $target ) ) {
+               $userrightsPage->setContext( $this->getContext() );
+               if ( $userrightsPage->userCanChangeRights( $target ) ) {
                        $tools[] = Linker::linkKnown(
                                SpecialPage::getTitleFor( 'Userrights', $username ),
-                               wfMsgHtml( 'sp-contributions-userrights' )
+                               $this->msg( 'sp-contributions-userrights' )->escaped()
                        );
                }
 
@@ -343,87 +357,193 @@ class SpecialContributions extends SpecialPage {
                global $wgScript;
 
                $this->opts['title'] = $this->getTitle()->getPrefixedText();
-               if( !isset( $this->opts['target'] ) ) {
+               if ( !isset( $this->opts['target'] ) ) {
                        $this->opts['target'] = '';
                } else {
                        $this->opts['target'] = str_replace( '_' , ' ' , $this->opts['target'] );
                }
 
-               if( !isset( $this->opts['namespace'] ) ) {
+               if ( !isset( $this->opts['namespace'] ) ) {
                        $this->opts['namespace'] = '';
                }
 
-               if( !isset( $this->opts['nsInvert'] ) ) {
+               if ( !isset( $this->opts['nsInvert'] ) ) {
                        $this->opts['nsInvert'] = '';
                }
 
-               if( !isset( $this->opts['contribs'] ) ) {
+               if ( !isset( $this->opts['associated'] ) ) {
+                       $this->opts['associated'] = false;
+               }
+
+               if ( !isset( $this->opts['contribs'] ) ) {
                        $this->opts['contribs'] = 'user';
                }
 
-               if( !isset( $this->opts['year'] ) ) {
+               if ( !isset( $this->opts['year'] ) ) {
                        $this->opts['year'] = '';
                }
 
-               if( !isset( $this->opts['month'] ) ) {
+               if ( !isset( $this->opts['month'] ) ) {
                        $this->opts['month'] = '';
                }
 
-               if( $this->opts['contribs'] == 'newbie' ) {
+               if ( $this->opts['contribs'] == 'newbie' ) {
                        $this->opts['target'] = '';
                }
 
-               if( !isset( $this->opts['tagfilter'] ) ) {
+               if ( !isset( $this->opts['tagfilter'] ) ) {
                        $this->opts['tagfilter'] = '';
                }
 
-               if( !isset( $this->opts['topOnly'] ) ) {
+               if ( !isset( $this->opts['topOnly'] ) ) {
                        $this->opts['topOnly'] = false;
                }
 
-               $f = Xml::openElement( 'form', array( 'method' => 'get', 'action' => $wgScript, 'class' => 'mw-contributions-form' ) );
+               $form = Xml::openElement( 'form', array( 'method' => 'get', 'action' => $wgScript, 'class' => 'mw-contributions-form' ) );
 
                # Add hidden params for tracking except for parameters in $skipParameters
-               $skipParameters = array( 'namespace', 'nsInvert', 'deletedOnly', 'target', 'contribs', 'year', 'month', 'topOnly' );
+               $skipParameters = array( 'namespace', 'nsInvert', 'deletedOnly', 'target', 'contribs', 'year', 'month', 'topOnly', 'associated' );
                foreach ( $this->opts as $name => $value ) {
-                       if( in_array( $name, $skipParameters ) ) {
+                       if ( in_array( $name, $skipParameters ) ) {
                                continue;
                        }
-                       $f .= "\t" . Html::hidden( $name, $value ) . "\n";
+                       $form .= "\t" . Html::hidden( $name, $value ) . "\n";
                }
 
                $tagFilter = ChangeTags::buildTagFilterSelector( $this->opts['tagfilter'] );
 
-               $f .=   Xml::fieldset( wfMsg( 'sp-contributions-search' ) ) .
-                       Xml::radioLabel( wfMsgExt( 'sp-contributions-newbies', array( 'parsemag' ) ),
-                               'contribs', 'newbie' , 'newbie', $this->opts['contribs'] == 'newbie' ) . '<br />' .
-                       Xml::radioLabel( wfMsgExt( 'sp-contributions-username', array( 'parsemag' ) ),
-                               'contribs' , 'user', 'user', $this->opts['contribs'] == 'user' ) . ' ' .
-                       Html::input( 'target', $this->opts['target'], 'text', array(
-                               'size' => '20',
-                               'required' => ''
-                       ) + ( $this->opts['target'] ? array() : array( 'autofocus' ) ) ) . ' '.
+               if ( $tagFilter ) {
+                       $filterSelection =
+                               Xml::tags( 'td', array( 'class' => 'mw-label' ), array_shift( $tagFilter ) ) .
+                               Xml::tags( 'td', array( 'class' => 'mw-input' ), implode( '&#160', $tagFilter ) );
+               } else {
+                       $filterSelection = Xml::tags( 'td', array( 'colspan' => 2 ), '' );
+               }
+
+               $targetSelection = Xml::tags( 'td', array( 'colspan' => 2 ),
+                       Xml::radioLabel(
+                               $this->msg( 'sp-contributions-newbies' )->text(),
+                               'contribs',
+                               'newbie' ,
+                               'newbie',
+                               $this->opts['contribs'] == 'newbie',
+                               array( 'class' => 'mw-input' )
+                       ) . '<br />' .
+                       Xml::radioLabel(
+                               $this->msg( 'sp-contributions-username' )->text(),
+                               'contribs',
+                               'user',
+                               'user',
+                               $this->opts['contribs'] == 'user',
+                               array( 'class' => 'mw-input' )
+                       ) . ' ' .
+                       Html::input(
+                               'target',
+                               $this->opts['target'],
+                               'text',
+                               array( 'size' => '20', 'required' => '', 'class' => 'mw-input' ) +
+                                       ( $this->opts['target'] ? array() : array( 'autofocus' )
+                               )
+                       ) . ' '
+               ) ;
+
+               $namespaceSelection =
+                       Xml::tags( 'td', array( 'class' => 'mw-label' ),
+                               Xml::label(
+                                       $this->msg( 'namespace' )->text(),
+                                       'namespace',
+                                       ''
+                               )
+                       ) .
+                       Xml::tags( 'td', null,
+                               Html::namespaceSelector( array(
+                                       'selected' => $this->opts['namespace'],
+                                       'all'      => '',
+                               ), array(
+                                       'name'  => 'namespace',
+                                       'id'    => 'namespace',
+                                       'class' => 'namespaceselector',
+                               ) ) .
+                               '&#160;' .
+                               Html::rawElement( 'span', array( 'style' => 'white-space: nowrap' ),
+                                       Xml::checkLabel(
+                                               $this->msg( 'invert' )->text(),
+                                               'nsInvert',
+                                               'nsInvert',
+                                               $this->opts['nsInvert'],
+                                               array( 'title' => $this->msg( 'tooltip-invert' )->text(), 'class' => 'mw-input' )
+                                       ) . '&#160;'
+                               ) .
+                               Html::rawElement( 'span', array( 'style' => 'white-space: nowrap' ),
+                                       Xml::checkLabel(
+                                               $this->msg( 'namespace_association' )->text(),
+                                               'associated',
+                                               'associated',
+                                               $this->opts['associated'],
+                                               array( 'title' => $this->msg( 'tooltip-namespace_association' )->text(), 'class' => 'mw-input' )
+                                       ) . '&#160;'
+                               )
+                       ) ;
+
+               $extraOptions = Xml::tags( 'td', array( 'colspan' => 2 ),
                        Html::rawElement( 'span', array( 'style' => 'white-space: nowrap' ),
-                               Xml::label( wfMsg( 'namespace' ), 'namespace' ) . ' ' .
-                               Xml::namespaceSelector( $this->opts['namespace'], '' )
+                               Xml::checkLabel(
+                                       $this->msg( 'history-show-deleted' )->text(),
+                                       'deletedOnly',
+                                       'mw-show-deleted-only',
+                                       $this->opts['deletedOnly'],
+                                       array( 'class' => 'mw-input' )
+                               )
                        ) .
-                       Xml::checkLabel( wfMsg('invert'), 'nsInvert', 'nsInvert', $this->opts['nsInvert'] ) . '&nbsp;' .
-                       Xml::checkLabel( wfMsg( 'history-show-deleted' ),
-                               'deletedOnly', 'mw-show-deleted-only', $this->opts['deletedOnly'] ) . '<br />' .
-                       Xml::tags( 'p', null, Xml::checkLabel( wfMsg( 'sp-contributions-toponly' ),
-                               'topOnly', 'mw-show-top-only', $this->opts['topOnly'] ) ) .
-                       ( $tagFilter ? Xml::tags( 'p', null, implode( '&#160;', $tagFilter ) ) : '' ) .
-                       Html::rawElement( 'p', array( 'style' => 'white-space: nowrap' ),
-                               Xml::dateMenu( $this->opts['year'], $this->opts['month'] ) . ' ' .
-                               Xml::submitButton( wfMsg( 'sp-contributions-submit' ) )
-                       ) . ' ';
-               $explain = wfMessage( 'sp-contributions-explain' );
+                       Html::rawElement( 'span', array( 'style' => 'white-space: nowrap' ),
+                               Xml::checkLabel(
+                                       $this->msg( 'sp-contributions-toponly' )->text(),
+                                       'topOnly',
+                                       'mw-show-top-only',
+                                       $this->opts['topOnly'],
+                                       array( 'class' => 'mw-input' )
+                               )
+                       )
+               ) ;
+
+               $dateSelectionAndSubmit = Xml::tags( 'td', array( 'colspan' => 2 ),
+                       Xml::dateMenu(
+                               $this->opts['year'],
+                               $this->opts['month']
+                       ) . ' ' .
+                       Xml::submitButton(
+                               $this->msg( 'sp-contributions-submit' )->text(),
+                               array( 'class' => 'mw-submit' )
+                       )
+               ) ;
+
+               $form .=
+                       Xml::fieldset( $this->msg( 'sp-contributions-search' )->text() ) .
+                       Xml::openElement( 'table', array( 'class' => 'mw-contributions-table' ) ) .
+                               Xml::openElement( 'tr' ) .
+                                       $targetSelection .
+                               Xml::closeElement( 'tr' ) .
+                               Xml::openElement( 'tr' ) .
+                                       $namespaceSelection .
+                               Xml::closeElement( 'tr' ) .
+                               Xml::openElement( 'tr' ) .
+                                       $filterSelection .
+                               Xml::closeElement( 'tr' ) .
+                               Xml::openElement( 'tr' ) .
+                                       $extraOptions .
+                               Xml::closeElement( 'tr' ) .
+                               Xml::openElement( 'tr' ) .
+                                       $dateSelectionAndSubmit .
+                               Xml::closeElement( 'tr' ) .
+                       Xml::closeElement( 'table' );
+
+               $explain = $this->msg( 'sp-contributions-explain' );
                if ( $explain->exists() ) {
-                       $f .= "<p id='mw-sp-contributions-explain'>{$explain}</p>";
+                       $form .= "<p id='mw-sp-contributions-explain'>{$explain}</p>";
                }
-               $f .= Xml::closeElement('fieldset' ) .
+               $form .= Xml::closeElement( 'fieldset' ) .
                        Xml::closeElement( 'form' );
-               return $f;
+               return $form;
        }
 }
 
@@ -437,13 +557,18 @@ class ContribsPager extends ReverseChronologicalPager {
        var $namespace = '', $mDb;
        var $preventClickjacking = false;
 
-       function __construct( $options ) {
-               parent::__construct();
+       /**
+        * @var array
+        */
+       protected $mParentLens;
+
+       function __construct( IContextSource $context, array $options ) {
+               parent::__construct( $context );
 
                $msgs = array( 'uctop', 'diff', 'newarticle', 'rollbacklink', 'diff', 'hist', 'rev-delundel', 'pipe-separator' );
 
-               foreach( $msgs as $msg ) {
-                       $this->messages[$msg] = wfMsgExt( $msg, array( 'escapenoentities' ) );
+               foreach ( $msgs as $msg ) {
+                       $this->messages[$msg] = $this->msg( $msg )->escaped();
                }
 
                $this->target = isset( $options['target'] ) ? $options['target'] : '';
@@ -451,6 +576,7 @@ class ContribsPager extends ReverseChronologicalPager {
                $this->namespace = isset( $options['namespace'] ) ? $options['namespace'] : '';
                $this->tagFilter = isset( $options['tagfilter'] ) ? $options['tagfilter'] : false;
                $this->nsInvert = isset( $options['nsInvert'] ) ? $options['nsInvert'] : false;
+               $this->associated = isset( $options['associated'] ) ? $options['associated'] : false;
 
                $this->deletedOnly = !empty( $options['deletedOnly'] );
                $this->topOnly = !empty( $options['topOnly'] );
@@ -475,10 +601,10 @@ class ContribsPager extends ReverseChronologicalPager {
                $conds = array_merge( $userCond, $this->getNamespaceCond() );
 
                // Paranoia: avoid brute force searches (bug 17342)
-               if( !$user->isAllowed( 'deletedhistory' ) ) {
-                       $conds[] = $this->mDb->bitAnd('rev_deleted',Revision::DELETED_USER) . ' = 0';
-               } elseif( !$user->isAllowed( 'suppressrevision' ) ) {
-                       $conds[] = $this->mDb->bitAnd('rev_deleted',Revision::SUPPRESSED_USER) .
+               if ( !$user->isAllowed( 'deletedhistory' ) ) {
+                       $conds[] = $this->mDb->bitAnd( 'rev_deleted', Revision::DELETED_USER ) . ' = 0';
+               } elseif ( !$user->isAllowed( 'suppressrevision' ) ) {
+                       $conds[] = $this->mDb->bitAnd( 'rev_deleted', Revision::SUPPRESSED_USER ) .
                                ' != ' . Revision::SUPPRESSED_USER;
                }
 
@@ -517,39 +643,52 @@ class ContribsPager extends ReverseChronologicalPager {
                $condition = array();
                $join_conds = array();
                $tables = array( 'revision', 'page', 'user' );
-               if( $this->contribs == 'newbie' ) {
+               if ( $this->contribs == 'newbie' ) {
                        $tables[] = 'user_groups';
                        $max = $this->mDb->selectField( 'user', 'max(user_id)', false, __METHOD__ );
-                       $condition[] = 'rev_user >' . (int)($max - $max / 100);
+                       $condition[] = 'rev_user >' . (int)( $max - $max / 100 );
                        $condition[] = 'ug_group IS NULL';
                        $index = 'user_timestamp';
                        # @todo FIXME: Other groups may have 'bot' rights
                        $join_conds['user_groups'] = array( 'LEFT JOIN', "ug_user = rev_user AND ug_group = 'bot'" );
                } else {
-                       if ( IP::isIPAddress( $this->target ) ) {
+                       $uid = User::idFromName( $this->target );
+                       if ( $uid ) {
+                               $condition['rev_user'] = $uid;
+                               $index = 'user_timestamp';
+                       } else {
                                $condition['rev_user_text'] = $this->target;
                                $index = 'usertext_timestamp';
-                       } else {
-                               $condition['rev_user'] = User::idFromName( $this->target );
-                               $index = 'user_timestamp';
                        }
                }
-               if( $this->deletedOnly ) {
+               if ( $this->deletedOnly ) {
                        $condition[] = "rev_deleted != '0'";
                }
-               if( $this->topOnly ) {
+               if ( $this->topOnly ) {
                        $condition[] = "rev_id = page_latest";
                }
                return array( $tables, $index, $condition, $join_conds );
        }
 
        function getNamespaceCond() {
-               if( $this->namespace !== '' ) {
-                       if ( $this->nsInvert ) {
-                               return array( 'page_namespace != ' . (int)$this->namespace );
+               if ( $this->namespace !== '' ) {
+                       $selectedNS = $this->mDb->addQuotes( $this->namespace );
+                       $eq_op = $this->nsInvert ? '!=' : '=';
+                       $bool_op = $this->nsInvert ? 'AND' : 'OR';
+
+                       if ( !$this->associated ) {
+                               return array( "page_namespace $eq_op $selectedNS" );
                        } else {
-                               return array( 'page_namespace' => (int)$this->namespace );
+                               $associatedNS = $this->mDb->addQuotes (
+                                       MWNamespace::getAssociated( $this->namespace )
+                               );
+                               return array(
+                                       "page_namespace $eq_op $selectedNS " .
+                                       $bool_op .
+                                       " page_namespace $eq_op $associatedNS"
+                               );
                        }
+
                } else {
                        return array();
                }
@@ -563,27 +702,32 @@ class ContribsPager extends ReverseChronologicalPager {
                $this->mResult->rewind();
                $revIds = array();
                foreach ( $this->mResult as $row ) {
-                       $revIds[] = $row->rev_parent_id;
+                       if( $row->rev_parent_id ) {
+                               $revIds[] = $row->rev_parent_id;
+                       }
                }
                $this->mParentLens = $this->getParentLengths( $revIds );
                $this->mResult->rewind(); // reset
 
-               if ( $this->contribs === 'newbie' ) { // multiple users
-                       # Do a link batch query
-                       $this->mResult->seek( 0 );
-                       $batch = new LinkBatch();
-                       # Give some pointers to make (last) links
-                       foreach ( $this->mResult as $row ) {
-                               $batch->addObj( Title::makeTitleSafe( NS_USER, $row->user_name ) );
-                               $batch->addObj( Title::makeTitleSafe( NS_USER_TALK, $row->user_name ) );
+               # Do a link batch query
+               $this->mResult->seek( 0 );
+               $batch = new LinkBatch();
+               # Give some pointers to make (last) links
+               foreach ( $this->mResult as $row ) {
+                       if ( $this->contribs === 'newbie' ) { // multiple users
+                               $batch->add( NS_USER, $row->user_name );
+                               $batch->add( NS_USER_TALK, $row->user_name );
                        }
-                       $batch->execute();
-                       $this->mResult->seek( 0 );
+                       $batch->add( $row->page_namespace, $row->page_title );
                }
+               $batch->execute();
+               $this->mResult->seek( 0 );
        }
 
        /**
         * Do a batched query to get the parent revision lengths
+        * @param $revIds array
+        * @return array
         */
        private function getParentLengths( array $revIds ) {
                $revLens = array();
@@ -595,17 +739,23 @@ class ContribsPager extends ReverseChronologicalPager {
                        array( 'rev_id', 'rev_len' ),
                        array( 'rev_id' => $revIds ),
                        __METHOD__ );
-               foreach( $res as $row ) {
+               foreach ( $res as $row ) {
                        $revLens[$row->rev_id] = $row->rev_len;
                }
                wfProfileOut( __METHOD__ );
                return $revLens;
        }
 
+       /**
+        * @return string
+        */
        function getStartBody() {
                return "<ul>\n";
        }
 
+       /**
+        * @return string
+        */
        function getEndBody() {
                return "</ul>\n";
        }
@@ -619,6 +769,8 @@ class ContribsPager extends ReverseChronologicalPager {
         * was not written by the target user.
         *
         * @todo This would probably look a lot nicer in a table.
+        * @param $row
+        * @return string
         */
        function formatRow( $row ) {
                wfProfileIn( __METHOD__ );
@@ -635,19 +787,19 @@ class ContribsPager extends ReverseChronologicalPager {
                );
                # Mark current revisions
                $topmarktext = '';
-               if( $row->rev_id == $row->page_latest ) {
+               if ( $row->rev_id == $row->page_latest ) {
                        $topmarktext .= '<span class="mw-uctop">' . $this->messages['uctop'] . '</span>';
                        # Add rollback link
-                       if( !$row->page_is_new && $page->quickUserCan( 'rollback' )
+                       if ( !$row->page_is_new && $page->quickUserCan( 'rollback' )
                                && $page->quickUserCan( 'edit' ) )
                        {
                                $this->preventClickjacking();
-                               $topmarktext .= ' '.Linker::generateRollback( $rev );
+                               $topmarktext .= ' ' . Linker::generateRollback( $rev );
                        }
                }
                $user = $this->getUser();
                # Is there a visible previous revision?
-               if( $rev->userCan( Revision::DELETED_TEXT, $user ) && $rev->getParentId() !== 0 ) {
+               if ( $rev->userCan( Revision::DELETED_TEXT, $user ) && $rev->getParentId() !== 0 ) {
                        $difftext = Linker::linkKnown(
                                $page,
                                $this->messages['diff'],
@@ -667,86 +819,71 @@ class ContribsPager extends ReverseChronologicalPager {
                        array( 'action' => 'history' )
                );
 
-               if ( isset( $this->mParentLens[$row->rev_parent_id] ) ) {
-                       $chardiff = ' . . ' . ChangesList::showCharacterDifference(
-                               $this->mParentLens[$row->rev_parent_id], $row->rev_len ) . ' . . ';
+               if ( $row->rev_parent_id === null ) {
+                       // For some reason rev_parent_id isn't populated for this row.
+                       // Its rumoured this is true on wikipedia for some revisions (bug 34922).
+                       // Next best thing is to have the total number of bytes.
+                       $chardiff = ' . . ' . Linker::formatRevisionSize( $row->rev_len ) . ' . . ';
                } else {
-                       $chardiff = ' ';
+                       $parentLen = isset( $this->mParentLens[$row->rev_parent_id] ) ? $this->mParentLens[$row->rev_parent_id] : 0;
+                       $chardiff = ' . . ' . ChangesList::showCharacterDifference(
+                                       $parentLen, $row->rev_len ) . ' . . ';
                }
 
-               $comment = $this->getLanguage()->getDirMark() . Linker::revComment( $rev, false, true );
-               $date = $this->getLanguage()->timeanddate( wfTimestamp( TS_MW, $row->rev_timestamp ), true );
-               if( $rev->userCan( Revision::DELETED_TEXT, $user ) ) {
+               $lang = $this->getLanguage();
+               $comment = $lang->getDirMark() . Linker::revComment( $rev, false, true );
+               $date = $lang->userTimeAndDate( $row->rev_timestamp, $user );
+               if ( $rev->userCan( Revision::DELETED_TEXT, $user ) ) {
                        $d = Linker::linkKnown(
                                $page,
-                               htmlspecialchars($date),
+                               htmlspecialchars( $date ),
                                array(),
                                array( 'oldid' => intval( $row->rev_id ) )
                        );
                } else {
                        $d = htmlspecialchars( $date );
                }
-               if( $rev->isDeleted( Revision::DELETED_TEXT ) ) {
+               if ( $rev->isDeleted( Revision::DELETED_TEXT ) ) {
                        $d = '<span class="history-deleted">' . $d . '</span>';
                }
 
                # Show user names for /newbies as there may be different users.
                # Note that we already excluded rows with hidden user names.
-               if( $this->contribs == 'newbie' ) {
+               if ( $this->contribs == 'newbie' ) {
                        $userlink = ' . . ' . Linker::userLink( $rev->getUser(), $rev->getUserText() );
-                       $userlink .= ' ' . wfMsg( 'parentheses',
-                               Linker::userTalkLink( $rev->getUser(), $rev->getUserText() ) ) . ' ';
+                       $userlink .= ' ' . $this->msg( 'parentheses' )->rawParams(
+                               Linker::userTalkLink( $rev->getUser(), $rev->getUserText() ) )->escaped() . ' ';
                } else {
                        $userlink = '';
                }
 
-               if( $rev->getParentId() === 0 ) {
+               if ( $rev->getParentId() === 0 ) {
                        $nflag = ChangesList::flag( 'newpage' );
                } else {
                        $nflag = '';
                }
 
-               if( $rev->isMinor() ) {
+               if ( $rev->isMinor() ) {
                        $mflag = ChangesList::flag( 'minor' );
                } else {
                        $mflag = '';
                }
 
-               if ( !is_null( $rev->getSize() ) && !$rev->isDeleted( Revision::DELETED_TEXT ) ) {
-                       $mSize = $this->getSkin()->formatRevisionSize( $rev->getSize() );
-               } else {
-                       $mSize = '';
-               }
-
-               // Don't show useless link to people who cannot hide revisions
-               $canHide = $user->isAllowed( 'deleterevision' );
-               if( $canHide || ($rev->getVisibility() && $user->isAllowed('deletedhistory')) ) {
-                       if( !$rev->userCan( Revision::DELETED_RESTRICTED, $user ) ) {
-                               $del = Linker::revDeleteLinkDisabled( $canHide ); // revision was hidden from sysops
-                       } else {
-                               $query = array(
-                                       'type'   => 'revision',
-                                       'target' => $page->getPrefixedDbkey(),
-                                       'ids'    => $rev->getId()
-                               );
-                               $del = Linker::revDeleteLink( $query,
-                                       $rev->isDeleted( Revision::DELETED_RESTRICTED ), $canHide );
-                       }
+               $del = Linker::getRevDeleteLink( $user, $rev, $page );
+               if ( $del !== '' ) {
                        $del .= ' ';
-               } else {
-                       $del = '';
                }
 
-               $diffHistLinks = '(' . $difftext . $this->messages['pipe-separator'] . $histlink . ')';
-               $ret = "{$del}{$d} {$diffHistLinks}{$chardiff}{$nflag}{$mflag} {$link}{$userlink} {$mSize} {$comment} {$topmarktext}";
+               $diffHistLinks = $this->msg( 'parentheses' )->rawParams( $difftext . $this->messages['pipe-separator'] . $histlink )->escaped();
+               $ret = "{$del}{$d} {$diffHistLinks}{$chardiff}{$nflag}{$mflag} {$link}{$userlink} {$comment} {$topmarktext}";
 
                # Denote if username is redacted for this edit
-               if( $rev->isDeleted( Revision::DELETED_USER ) ) {
-                       $ret .= " <strong>" . wfMsgHtml('rev-deleted-user-contribs') . "</strong>";
+               if ( $rev->isDeleted( Revision::DELETED_USER ) ) {
+                       $ret .= " <strong>" . $this->msg( 'rev-deleted-user-contribs' )->escaped() . "</strong>";
                }
 
                # Tags, if any.
-               list($tagSummary, $newClasses) = ChangeTags::formatSummaryRow( $row->ts_tags, 'contributions' );
+               list( $tagSummary, $newClasses ) = ChangeTags::formatSummaryRow( $row->ts_tags, 'contributions' );
                $classes = array_merge( $classes, $newClasses );
                $ret .= " $tagSummary";
 
@@ -770,6 +907,7 @@ class ContribsPager extends ReverseChronologicalPager {
 
        /**
         * Overwrite Pager function and return a helpful comment
+        * @return string
         */
        function getSqlComment() {
                if ( $this->namespace || $this->deletedOnly ) {
@@ -783,6 +921,9 @@ class ContribsPager extends ReverseChronologicalPager {
                $this->preventClickjacking = true;
        }
 
+       /**
+        * @return bool
+        */
        public function getPreventClickjacking() {
                return $this->preventClickjacking;
        }