Followup r80122, protected, just incase it's needed..
[lhc/web/wiklou.git] / includes / specials / SpecialBlockip.php
index e7f43ee..438bc35 100644 (file)
@@ -1,58 +1,85 @@
 <?php
 /**
- * Constructor for Special:Blockip page
+ * Implements Special:Blockip
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ * http://www.gnu.org/copyleft/gpl.html
  *
  * @file
  * @ingroup SpecialPage
  */
 
 /**
- * Constructor
- */
-function wfSpecialBlockip( $par ) {
-       global $wgUser, $wgOut, $wgRequest;
-       # Can't block when the database is locked
-       if( wfReadOnly() ) {
-               $wgOut->readOnlyPage();
-               return;
-       }
-       # Permission check
-       if( !$wgUser->isAllowed( 'block' ) ) {
-               $wgOut->permissionRequired( 'block' );
-               return;
-       }
-
-       $ipb = new IPBlockForm( $par );
-
-       $action = $wgRequest->getVal( 'action' );
-       if( 'success' == $action ) {
-               $ipb->showSuccess();
-       } else if( $wgRequest->wasPosted() && 'submit' == $action &&
-               $wgUser->matchEditToken( $wgRequest->getVal( 'wpEditToken' ) ) ) {
-               $ipb->doSubmit();
-       } else {
-               $ipb->showForm( '' );
-       }
-}
-
-/**
- * Form object for the Special:Blockip page.
+ * A special page that allows users with 'block' right to block users from
+ * editing pages and other actions
  *
  * @ingroup SpecialPage
  */
-class IPBlockForm {
-       var $BlockAddress, $BlockExpiry, $BlockReason;
+class IPBlockForm extends SpecialPage {
+       var $BlockAddress, $BlockExpiry, $BlockReason, $BlockReasonList, $BlockOther, $BlockAnonOnly, $BlockCreateAccount,
+               $BlockEnableAutoblock, $BlockEmail, $BlockHideName, $BlockAllowUsertalk, $BlockReblock;
        // The maximum number of edits a user can have and still be hidden
        const HIDEUSER_CONTRIBLIMIT = 1000;
 
-       public function __construct( $par ) {
+       public function __construct() {
+               parent::__construct( 'Blockip', 'block' );
+       }
+
+       public function execute( $par ) {
+               global $wgUser, $wgOut, $wgRequest;
+
+               # Can't block when the database is locked
+               if( wfReadOnly() ) {
+                       $wgOut->readOnlyPage();
+                       return;
+               }
+               # Permission check
+               if( !$this->userCanExecute( $wgUser ) ) {
+                       $wgOut->permissionRequired( 'block' );
+                       return;
+               }
+
+               $this->setup( $par );
+       
+               # bug 15810: blocked admins should have limited access here
+               if ( $wgUser->isBlocked() ) {
+                       $status = IPBlockForm::checkUnblockSelf( $this->BlockAddress );
+                       if ( $status !== true ) {
+                               throw new ErrorPageError( 'badaccess', $status );
+                       }
+               }
+
+               $action = $wgRequest->getVal( 'action' );
+               if( 'success' == $action ) {
+                       $this->showSuccess();
+               } elseif( $wgRequest->wasPosted() && 'submit' == $action &&
+                       $wgUser->matchEditToken( $wgRequest->getVal( 'wpEditToken' ) ) ) {
+                       $this->doSubmit();
+               } else {
+                       $this->showForm( '' );
+               }
+       }
+
+       private function setup( $par ) {
                global $wgRequest, $wgUser, $wgBlockAllowsUTEdit;
 
                $this->BlockAddress = $wgRequest->getVal( 'wpBlockAddress', $wgRequest->getVal( 'ip', $par ) );
                $this->BlockAddress = strtr( $this->BlockAddress, '_', ' ' );
                $this->BlockReason = $wgRequest->getText( 'wpBlockReason' );
                $this->BlockReasonList = $wgRequest->getText( 'wpBlockReasonList' );
-               $this->BlockExpiry = $wgRequest->getVal( 'wpBlockExpiry', wfMsg('ipbotheroption') );
+               $this->BlockExpiry = $wgRequest->getVal( 'wpBlockExpiry', wfMsg( 'ipbotheroption' ) );
                $this->BlockOther = $wgRequest->getVal( 'wpBlockOther', '' );
 
                # Unchecked checkboxes are not included in the form data at all, so having one
@@ -65,20 +92,26 @@ class IPBlockForm {
                if( self::canBlockEmail( $wgUser ) ) {
                        $this->BlockEmail = $wgRequest->getBool( 'wpEmailBan', false );
                }
-               $this->BlockWatchUser = $wgRequest->getBool( 'wpWatchUser', false );
-               # Re-check user's rights to hide names, very serious, defaults to 0
-               $this->BlockHideName = ( $wgRequest->getBool( 'wpHideName', 0 ) && $wgUser->isAllowed( 'hideuser' ) ) ? 1 : 0;
+               $this->BlockWatchUser = $wgRequest->getBool( 'wpWatchUser', false ) && $wgUser->isLoggedIn();
+               # Re-check user's rights to hide names, very serious, defaults to null
+               if( $wgUser->isAllowed( 'hideuser' ) ) {
+                       $this->BlockHideName = $wgRequest->getBool( 'wpHideName', null );
+               } else {
+                       $this->BlockHideName = false;
+               }
                $this->BlockAllowUsertalk = ( $wgRequest->getBool( 'wpAllowUsertalk', $byDefault ) && $wgBlockAllowsUTEdit );
                $this->BlockReblock = $wgRequest->getBool( 'wpChangeBlock', false );
+               
+               $this->wasPosted = $wgRequest->wasPosted();
        }
 
        public function showForm( $err ) {
                global $wgOut, $wgUser, $wgSysopUserBans;
 
-               $wgOut->setPagetitle( wfMsg( 'blockip' ) );
+               $wgOut->setPageTitle( wfMsg( 'blockip-title' ) );
                $wgOut->addWikiMsg( 'blockiptext' );
 
-               if($wgSysopUserBans) {
+               if( $wgSysopUserBans ) {
                        $mIpaddress = Xml::label( wfMsg( 'ipadressorusername' ), 'mw-bi-target' );
                } else {
                        $mIpaddress = Xml::label( wfMsg( 'ipaddress' ), 'mw-bi-target' );
@@ -90,25 +123,31 @@ class IPBlockForm {
 
                $titleObj = SpecialPage::getTitleFor( 'Blockip' );
                $user = User::newFromName( $this->BlockAddress );
-               
+               if ( is_object( $user ) || User::isIP( $this->BlockAddress ) ) {
+                       $wgUser->getSkin()->setRelevantUser( is_object($user) ? $user : User::newFromName( $this->BlockAddress, false ) );
+               }
+
                $alreadyBlocked = false;
+               $otherBlockedMsgs = array();
                if( $err && $err[0] != 'ipb_already_blocked' ) {
-                       $key = array_shift($err);
-                       $msg = wfMsgReal($key, $err);
+                       $key = array_shift( $err );
+                       $msg = wfMsgReal( $key, $err );
                        $wgOut->setSubtitle( wfMsgHtml( 'formerror' ) );
                        $wgOut->addHTML( Xml::tags( 'p', array( 'class' => 'error' ), $msg ) );
-               } elseif( $this->BlockAddress ) {
-                       $userId = 0;
-                       if( is_object( $user ) )
-                               $userId = $user->getId();
+               } elseif( $this->BlockAddress !== null ) {
+                       # Get other blocks, i.e. from GlobalBlocking or TorBlock extension
+                       wfRunHooks( 'OtherBlockLogLink', array( &$otherBlockedMsgs, $this->BlockAddress ) );
+
+                       $userId = is_object( $user ) ? $user->getId() : 0;
                        $currentBlock = Block::newFromDB( $this->BlockAddress, $userId );
-                       if( !is_null($currentBlock) && !$currentBlock->mAuto && # The block exists and isn't an autoblock
+                       if( !is_null( $currentBlock ) && !$currentBlock->mAuto && # The block exists and isn't an autoblock
                                ( $currentBlock->mRangeStart == $currentBlock->mRangeEnd || # The block isn't a rangeblock
                                # or if it is, the range is what we're about to block
-                               ( $currentBlock->mAddress == $this->BlockAddress ) ) ) {
-                                       $wgOut->addWikiMsg( 'ipb-needreblock', $this->BlockAddress );
-                                       $alreadyBlocked = true;
-                                       # Set the block form settings to the existing block
+                               ( $currentBlock->mAddress == $this->BlockAddress ) )
+                       ) {
+                               $alreadyBlocked = true;
+                               # Set the block form settings to the existing block
+                               if( !$this->wasPosted ) {
                                        $this->BlockAnonOnly = $currentBlock->mAnonOnly;
                                        $this->BlockCreateAccount = $currentBlock->mCreateAccount;
                                        $this->BlockEnableAutoblock = $currentBlock->mEnableAutoblock;
@@ -121,7 +160,25 @@ class IPBlockForm {
                                                $this->BlockOther = wfTimestamp( TS_ISO_8601, $currentBlock->mExpiry );
                                        }
                                        $this->BlockReason = $currentBlock->mReason;
+                               }
+                       }
+               }
+
+               # Show other blocks from extensions, i.e. GlockBlocking and TorBlock
+               if( count( $otherBlockedMsgs ) ) {
+                       $wgOut->addHTML(
+                               Html::rawElement( 'h2', array(), wfMsgExt( 'ipb-otherblocks-header', 'parseinline', count( $otherBlockedMsgs ) ) ) . "\n"
+                       );
+                       $list = '';
+                       foreach( $otherBlockedMsgs as $link ) {
+                               $list .= Html::rawElement( 'li', array(), $link ) . "\n";
                        }
+                       $wgOut->addHTML( Html::rawElement( 'ul', array( 'class' => 'mw-blockip-alreadyblocked' ), $list ) . "\n" );
+               }
+
+               # Username/IP is blocked already locally
+               if( $alreadyBlocked ) {
+                       $wgOut->wrapWikiMsg( "<div class='mw-ipb-needreblock'>\n$1\n</div>", array( 'ipb-needreblock', $this->BlockAddress ) );
                }
 
                $scBlockExpiryOptions = wfMsgForContent( 'ipboptions' );
@@ -130,35 +187,36 @@ class IPBlockForm {
                if( !$showblockoptions ) $mIpbother = $mIpbexpiry;
 
                $blockExpiryFormOptions = Xml::option( wfMsg( 'ipbotheroption' ), 'other' );
-               foreach (explode(',', $scBlockExpiryOptions) as $option) {
-                       if( strpos($option, ":") === false ) $option = "$option:$option";
-                       list($show, $value) = explode(":", $option);
-                       $show = htmlspecialchars($show);
-                       $value = htmlspecialchars($value);
-                       $blockExpiryFormOptions .= Xml::option( $show, $value, $this->BlockExpiry === $value ? true : false ) . "\n";
+               foreach( explode( ',', $scBlockExpiryOptions ) as $option ) {
+                       if( strpos( $option, ':' ) === false ) $option = "$option:$option";
+                       list( $show, $value ) = explode( ':', $option );
+                       $show = htmlspecialchars( $show );
+                       $value = htmlspecialchars( $value );
+                       $blockExpiryFormOptions .= Xml::option( $show, $value, $this->BlockExpiry === $value ) . "\n";
                }
 
                $reasonDropDown = Xml::listDropDown( 'wpBlockReasonList',
                        wfMsgForContent( 'ipbreason-dropdown' ),
                        wfMsgForContent( 'ipbreasonotherlist' ), $this->BlockReasonList, 'wpBlockDropDown', 4 );
 
-               global $wgStylePath, $wgStyleVersion;
+               $wgOut->addModules( 'mediawiki.legacy.block' );
                $wgOut->addHTML(
-                       Xml::tags( 'script', array( 'type' => 'text/javascript', 'src' => "$wgStylePath/common/block.js?$wgStyleVersion" ), '' ) .
-                       Xml::openElement( 'form', array( 'method' => 'post', 'action' => $titleObj->getLocalURL( "action=submit" ), 'id' => 'blockip' ) ) .
+                       Xml::openElement( 'form', array( 'method' => 'post', 'action' => $titleObj->getLocalURL( 'action=submit' ), 'id' => 'blockip' ) ) .
                        Xml::openElement( 'fieldset' ) .
                        Xml::element( 'legend', null, wfMsg( 'blockip-legend' ) ) .
-                       Xml::openElement( 'table', array ( 'border' => '0', 'id' => 'mw-blockip-table' ) ) .
+                       Xml::openElement( 'table', array( 'border' => '0', 'id' => 'mw-blockip-table' ) ) .
                        "<tr>
                                <td class='mw-label'>
                                        {$mIpaddress}
                                </td>
                                <td class='mw-input'>" .
-                                       Xml::input( 'wpBlockAddress', 45, $this->BlockAddress,
-                                               array(
-                                                       'tabindex' => '1',
-                                                       'id' => 'mw-bi-target',
-                                                       'onchange' => 'updateBlockOptions()' ) ). "
+                                       Html::input( 'wpBlockAddress', $this->BlockAddress, 'text', array(
+                                               'tabindex' => '1',
+                                               'id' => 'mw-bi-target',
+                                               'onchange' => 'updateBlockOptions()',
+                                               'size' => '45',
+                                               'required' => ''
+                                       ) + ( $this->BlockAddress ? array() : array( 'autofocus' ) ) ). "
                                </td>
                        </tr>
                        <tr>"
@@ -203,12 +261,16 @@ class IPBlockForm {
                                        {$mIpbreason}
                                </td>
                                <td class='mw-input'>" .
-                                       Xml::input( 'wpBlockReason', 45, $this->BlockReason,
-                                               array( 'tabindex' => '5', 'id' => 'mw-bi-reason', 'maxlength'=> '200' ) ) . "
+                               Html::input( 'wpBlockReason', $this->BlockReason, 'text', array(
+                                       'tabindex' => '5',
+                                       'id' => 'mw-bi-reason',
+                                       'maxlength' => '200',
+                                       'size' => '45'
+                               ) + ( $this->BlockAddress ? array( 'autofocus' ) : array() ) ) . "
                                </td>
                        </tr>
                        <tr id='wpAnonOnlyRow'>
-                               <td>&nbsp;</td>
+                               <td>&#160;</td>
                                <td class='mw-input'>" .
                                Xml::checkLabel( wfMsg( 'ipbanononly' ),
                                                'wpAnonOnly', 'wpAnonOnly', $this->BlockAnonOnly,
@@ -216,7 +278,7 @@ class IPBlockForm {
                                </td>
                        </tr>
                        <tr id='wpCreateAccountRow'>
-                               <td>&nbsp;</td>
+                               <td>&#160;</td>
                                <td class='mw-input'>" .
                                        Xml::checkLabel( wfMsg( 'ipbcreateaccount' ),
                                                'wpCreateAccount', 'wpCreateAccount', $this->BlockCreateAccount,
@@ -224,7 +286,7 @@ class IPBlockForm {
                                </td>
                        </tr>
                        <tr id='wpEnableAutoblockRow'>
-                               <td>&nbsp;</td>
+                               <td>&#160;</td>
                                <td class='mw-input'>" .
                                        Xml::checkLabel( wfMsg( 'ipbenableautoblock' ),
                                                'wpEnableAutoblock', 'wpEnableAutoblock', $this->BlockEnableAutoblock,
@@ -236,11 +298,11 @@ class IPBlockForm {
                if( self::canBlockEmail( $wgUser ) ) {
                        $wgOut->addHTML("
                                <tr id='wpEnableEmailBan'>
-                                       <td>&nbsp;</td>
+                                       <td>&#160;</td>
                                        <td class='mw-input'>" .
                                                Xml::checkLabel( wfMsg( 'ipbemailban' ),
                                                        'wpEmailBan', 'wpEmailBan', $this->BlockEmail,
-                                                       array( 'tabindex' => '9' )) . "
+                                                       array( 'tabindex' => '9' ) ) . "
                                        </td>
                                </tr>"
                        );
@@ -250,34 +312,37 @@ class IPBlockForm {
                if( $wgUser->isAllowed( 'hideuser' ) ) {
                        $wgOut->addHTML("
                                <tr id='wpEnableHideUser'>
-                                       <td>&nbsp;</td>
+                                       <td>&#160;</td>
                                        <td class='mw-input'><strong>" .
                                                Xml::checkLabel( wfMsg( 'ipbhidename' ),
                                                        'wpHideName', 'wpHideName', $this->BlockHideName,
-                                                       array( 'tabindex' => '10' ) ) . "
+                                                       array( 'tabindex' => '10' )
+                                               ) . "
                                        </strong></td>
                                </tr>"
                        );
                }
-               
-               # Watchlist their user page?
-               $wgOut->addHTML("
+
+               # Watchlist their user page? (Only if user is logged in)
+               if( $wgUser->isLoggedIn() ) {
+                       $wgOut->addHTML("
                        <tr id='wpEnableWatchUser'>
-                               <td>&nbsp;</td>
+                               <td>&#160;</td>
                                <td class='mw-input'>" .
                                        Xml::checkLabel( wfMsg( 'ipbwatchuser' ),
                                                'wpWatchUser', 'wpWatchUser', $this->BlockWatchUser,
                                                array( 'tabindex' => '11' ) ) . "
                                </td>
                        </tr>"
-               );
-               
+                       );
+               }
+
                # Can we explicitly disallow the use of user_talk?
                global $wgBlockAllowsUTEdit;
                if( $wgBlockAllowsUTEdit ){
                        $wgOut->addHTML("
                                <tr id='wpAllowUsertalkRow'>
-                                       <td>&nbsp;</td>
+                                       <td>&#160;</td>
                                        <td class='mw-input'>" .
                                                Xml::checkLabel( wfMsg( 'ipballowusertalk' ),
                                                        'wpAllowUsertalk', 'wpAllowUsertalk', $this->BlockAllowUsertalk,
@@ -289,18 +354,18 @@ class IPBlockForm {
 
                $wgOut->addHTML("
                        <tr>
-                               <td style='padding-top: 1em'>&nbsp;</td>
+                               <td style='padding-top: 1em'>&#160;</td>
                                <td  class='mw-submit' style='padding-top: 1em'>" .
                                        Xml::submitButton( wfMsg( $alreadyBlocked ? 'ipb-change-block' : 'ipbsubmit' ),
-                                               array( 'name' => 'wpBlock', 'tabindex' => '13', 'accesskey' => 's' ) ) . "
+                                               array( 'name' => 'wpBlock', 'tabindex' => '13' )
+                                                       + $wgUser->getSkin()->tooltipAndAccessKeyAttribs( 'blockip-block' ) ). "
                                </td>
                        </tr>" .
                        Xml::closeElement( 'table' ) .
-                       Xml::hidden( 'wpEditToken', $wgUser->editToken() ) .
-                       ( $alreadyBlocked ? Xml::hidden( 'wpChangeBlock', 1 ) : "" ) .
+                       Html::hidden( 'wpEditToken', $wgUser->editToken() ) .
+                       ( $alreadyBlocked ? Html::hidden( 'wpChangeBlock', 1 ) : "" ) .
                        Xml::closeElement( 'fieldset' ) .
-                       Xml::closeElement( 'form' ) .
-                       Xml::tags( 'script', array( 'type' => 'text/javascript' ), 'updateBlockOptions()' ) . "\n"
+                       Xml::closeElement( 'form' )
                );
 
                $wgOut->addHTML( $this->getConvenienceLinks() );
@@ -313,15 +378,41 @@ class IPBlockForm {
                        $this->showLogFragment( $wgOut, Title::makeTitle( NS_USER, $this->BlockAddress ) );
                }
        }
-       
+
        /**
         * Can we do an email block?
-        * @param User $user The sysop wanting to make a block
-        * @return boolean
+        * @param $user User: the sysop wanting to make a block
+        * @return Boolean
         */
        public static function canBlockEmail( $user ) {
                global $wgEnableUserEmail, $wgSysopEmailBans;
-               return ($wgEnableUserEmail && $wgSysopEmailBans && $user->isAllowed( 'blockemail' ));
+               return ( $wgEnableUserEmail && $wgSysopEmailBans && $user->isAllowed( 'blockemail' ) );
+       }
+       
+       /**
+        * bug 15810: blocked admins should not be able to block/unblock
+        * others, and probably shouldn't be able to unblock themselves
+        * either.
+        * @param $user User, Int or String
+        */
+       public static function checkUnblockSelf( $user ) {
+               global $wgUser;
+               if ( is_int( $user ) ) {
+                       $user = User::newFromId( $user );
+               } elseif ( is_string( $user ) ) {
+                       $user = User::newFromName( $user );
+               }
+               if( $user instanceof User && $user->getId() == $wgUser->getId() ) {
+                       # User is trying to unblock themselves
+                       if ( $wgUser->isAllowed( 'unblockself' ) ) {
+                               return true;
+                       } else {
+                               return 'ipbnounblockself';
+                       }
+               } else {
+                       # User is trying to block/unblock someone else
+                       return 'ipbblocked';
+               }
        }
 
        /**
@@ -330,7 +421,7 @@ class IPBlockForm {
         * @return array(message key, arguments) on failure, empty array on success
         */
        function doBlock( &$userId = null, &$expiry = null ) {
-               global $wgUser, $wgSysopUserBans, $wgSysopRangeBans, $wgBlockAllowsUTEdit;
+               global $wgUser, $wgSysopUserBans, $wgSysopRangeBans, $wgBlockAllowsUTEdit, $wgBlockCIDRLimit;
 
                $userId = 0;
                # Expand valid IPv6 addresses, usernames are left as is
@@ -346,19 +437,23 @@ class IPBlockForm {
                        if( preg_match( "/^($rxIP4)\\/(\\d{1,2})$/", $this->BlockAddress, $matches ) ) {
                                # IPv4
                                if( $wgSysopRangeBans ) {
-                                       if( !IP::isIPv4( $this->BlockAddress ) || $matches[2] < 16 || $matches[2] > 32 ) {
-                                               return array('ip_range_invalid');
+                                       if( !IP::isIPv4( $this->BlockAddress ) || $matches[2] > 32 ) {
+                                               return array( 'ip_range_invalid' );
+                                       } elseif ( $matches[2] < $wgBlockCIDRLimit['IPv4'] ) {
+                                               return array( 'ip_range_toolarge', $wgBlockCIDRLimit['IPv4'] );
                                        }
                                        $this->BlockAddress = Block::normaliseRange( $this->BlockAddress );
                                } else {
                                        # Range block illegal
-                                       return array('range_block_disabled');
+                                       return array( 'range_block_disabled' );
                                }
-                       } else if( preg_match( "/^($rxIP6)\\/(\\d{1,3})$/", $this->BlockAddress, $matches ) ) {
+                       } elseif( preg_match( "/^($rxIP6)\\/(\\d{1,3})$/", $this->BlockAddress, $matches ) ) {
                                # IPv6
                                if( $wgSysopRangeBans ) {
-                                       if( !IP::isIPv6( $this->BlockAddress ) || $matches[2] < 64 || $matches[2] > 128 ) {
-                                               return array('ip_range_invalid');
+                                       if( !IP::isIPv6( $this->BlockAddress ) || $matches[2] > 128 ) {
+                                               return array( 'ip_range_invalid' );
+                                       } elseif( $matches[2] < $wgBlockCIDRLimit['IPv6'] ) {
+                                               return array( 'ip_range_toolarge', $wgBlockCIDRLimit['IPv6'] );
                                        }
                                        $this->BlockAddress = Block::normaliseRange( $this->BlockAddress );
                                } else {
@@ -369,15 +464,15 @@ class IPBlockForm {
                                # Username block
                                if( $wgSysopUserBans ) {
                                        $user = User::newFromName( $this->BlockAddress );
-                                       if( !is_null( $user ) && $user->getId() ) {
+                                       if( $user instanceof User && $user->getId() ) {
                                                # Use canonical name
                                                $userId = $user->getId();
                                                $this->BlockAddress = $user->getName();
                                        } else {
-                                               return array('nosuchusershort', htmlspecialchars( $user ? $user->getName() : $this->BlockAddress ) );
+                                               return array( 'nosuchusershort', htmlspecialchars( $user ? $user->getName() : $this->BlockAddress ) );
                                        }
                                } else {
-                                       return array('badipaddress');
+                                       return array( 'badipaddress' );
                                }
                        }
                }
@@ -398,26 +493,26 @@ class IPBlockForm {
                if( $expirestr == 'other' )
                        $expirestr = $this->BlockOther;
 
-               if( ( strlen( $expirestr ) == 0) || ( strlen( $expirestr ) > 50) ) {
-                       return array('ipb_expiry_invalid');
+               if( ( strlen( $expirestr ) == 0) || ( strlen( $expirestr ) > 50 ) ) {
+                       return array( 'ipb_expiry_invalid' );
                }
                
-               if( false === ($expiry = Block::parseExpiryInput( $expirestr )) ) {
+               if( false === ( $expiry = Block::parseExpiryInput( $expirestr ) ) ) {
                        // Bad expiry.
-                       return array('ipb_expiry_invalid');
+                       return array( 'ipb_expiry_invalid' );
                }
-               
+
                if( $this->BlockHideName ) {
                        // Recheck params here...
                        if( !$userId || !$wgUser->isAllowed('hideuser') ) {
                                $this->BlockHideName = false; // IP users should not be hidden
-                       } else if( $expiry !== 'infinity' ) {
+                       } elseif( $expiry !== 'infinity' ) {
                                // Bad expiry.
-                               return array('ipb_expiry_temp');
-                       } else if( User::edits($userId) > self::HIDEUSER_CONTRIBLIMIT ) {
+                               return array( 'ipb_expiry_temp' );
+                       } elseif( User::edits( $userId ) > self::HIDEUSER_CONTRIBLIMIT ) {
                                // Typically, the user should have a handful of edits.
                                // Disallow hiding users with many edits for performance.
-                               return array('ipb_hide_invalid');
+                               return array( 'ipb_hide_invalid' );
                        }
                }
 
@@ -426,12 +521,13 @@ class IPBlockForm {
                $block = new Block( $this->BlockAddress, $userId, $wgUser->getId(),
                        $reasonstr, wfTimestampNow(), 0, $expiry, $this->BlockAnonOnly,
                        $this->BlockCreateAccount, $this->BlockEnableAutoblock, $this->BlockHideName,
-                       $this->BlockEmail, isset( $this->BlockAllowUsertalk ) ? $this->BlockAllowUsertalk : $wgBlockAllowsUTEdit
+                       $this->BlockEmail,
+                       isset( $this->BlockAllowUsertalk ) ? $this->BlockAllowUsertalk : $wgBlockAllowsUTEdit
                );
 
                # Should this be privately logged?
                $suppressLog = (bool)$this->BlockHideName;
-               if( wfRunHooks('BlockIp', array(&$block, &$wgUser)) ) {
+               if( wfRunHooks( 'BlockIp', array( &$block, &$wgUser ) ) ) {
                        # Try to insert block. Is there a conflicting block?
                        if( !$block->insert() ) {
                                # Show form unless the user is already aware of this...
@@ -447,8 +543,8 @@ class IPBlockForm {
                                        }
                                        # If the name was hidden and the blocking user cannot hide
                                        # names, then don't allow any block changes...
-                                       if( $currentBlock->mHideName && !$wgUser->isAllowed('hideuser') ) {
-                                               return array( 'hookaborted' );
+                                       if( $currentBlock->mHideName && !$wgUser->isAllowed( 'hideuser' ) ) {
+                                               return array( 'cant-see-hidden-user' );
                                        }
                                        $currentBlock->delete();
                                        $block->insert();
@@ -463,7 +559,7 @@ class IPBlockForm {
                        } else {
                                $log_action = 'block';
                        }
-                       wfRunHooks('BlockIpComplete', array($block, $wgUser));
+                       wfRunHooks( 'BlockIpComplete', array( $block, $wgUser ) );
 
                        # Set *_deleted fields if requested
                        if( $this->BlockHideName ) {
@@ -474,7 +570,7 @@ class IPBlockForm {
                        if( $this->BlockWatchUser && $block->mRangeStart == $block->mRangeEnd ) {
                                $wgUser->addWatch( Title::makeTitle( NS_USER, $this->BlockAddress ) );
                        }
-                       
+
                        # Block constructor sanitizes certain block options on insert
                        $this->BlockEmail = $block->mBlockEmail;
                        $this->BlockEnableAutoblock = $block->mEnableAutoblock;
@@ -493,23 +589,24 @@ class IPBlockForm {
                        # Report to the user
                        return array();
                } else {
-                       return array('hookaborted');
+                       return array( 'hookaborted' );
                }
        }
-       
-       public static function suppressUserName( $name, $userId ) {
+
+       public static function suppressUserName( $name, $userId, $dbw = null ) {
                $op = '|'; // bitwise OR
-               return self::setUsernameBitfields( $name, $userId, $op );
+               return self::setUsernameBitfields( $name, $userId, $op, $dbw );
        }
-       
-       public static function unsuppressUserName( $name, $userId ) {
+
+       public static function unsuppressUserName( $name, $userId, $dbw = null ) {
                $op = '&'; // bitwise AND
-               return self::setUsernameBitfields( $name, $userId, $op );
+               return self::setUsernameBitfields( $name, $userId, $op, $dbw );
        }
-       
-       private static function setUsernameBitfields( $name, $userId, $op ) {
+
+       private static function setUsernameBitfields( $name, $userId, $op, $dbw ) {
                if( $op !== '|' && $op !== '&' ) return false; // sanity check
-               $dbw = wfGetDB( DB_MASTER );
+               if( !$dbw )
+                       $dbw = wfGetDB( DB_MASTER );
                $delUser = Revision::DELETED_USER | Revision::DELETED_RESTRICTED;
                $delAction = LogPage::DELETED_ACTION | Revision::DELETED_RESTRICTED;
                # Normalize user name
@@ -525,29 +622,29 @@ class IPBlockForm {
                        $delAction = "~{$delAction}";
                }
                # Hide name from live edits
-               $dbw->update( 'revision', array("rev_deleted = rev_deleted $op $delUser"),
-                       array('rev_user' => $userId), __METHOD__ );
+               $dbw->update( 'revision', array( "rev_deleted = rev_deleted $op $delUser" ),
+                       array( 'rev_user' => $userId ), __METHOD__ );
                # Hide name from deleted edits
-               $dbw->update( 'archive', array("ar_deleted = ar_deleted $op $delUser"),
-                       array('ar_user_text' => $name), __METHOD__ );
+               $dbw->update( 'archive', array( "ar_deleted = ar_deleted $op $delUser" ),
+                       array( 'ar_user_text' => $name ), __METHOD__ );
                # Hide name from logs
-               $dbw->update( 'logging', array("log_deleted = log_deleted $op $delUser"),
-                       array('log_user' => $userId, "log_type != 'suppress'"), __METHOD__ );
-               $dbw->update( 'logging', array("log_deleted = log_deleted $op $delAction"),
-                       array('log_namespace' => NS_USER, 'log_title' => $userDbKey,
-                               "log_type != 'suppress'"), __METHOD__ );
+               $dbw->update( 'logging', array( "log_deleted = log_deleted $op $delUser" ),
+                       array( 'log_user' => $userId, "log_type != 'suppress'" ), __METHOD__ );
+               $dbw->update( 'logging', array( "log_deleted = log_deleted $op $delAction" ),
+                       array( 'log_namespace' => NS_USER, 'log_title' => $userDbKey,
+                               "log_type != 'suppress'" ), __METHOD__ );
                # Hide name from RC
-               $dbw->update( 'recentchanges', array("rc_deleted = rc_deleted $op $delUser"),
-                       array('rc_user_text' => $name), __METHOD__ );
-               $dbw->update( 'recentchanges', array("rc_deleted = rc_deleted $op $delAction"),
-                       array('rc_namespace' => NS_USER, 'rc_title' => $userDbKey, 'rc_logid > 0'), __METHOD__ );
+               $dbw->update( 'recentchanges', array( "rc_deleted = rc_deleted $op $delUser" ),
+                       array( 'rc_user_text' => $name ), __METHOD__ );
+               $dbw->update( 'recentchanges', array( "rc_deleted = rc_deleted $op $delAction" ),
+                       array( 'rc_namespace' => NS_USER, 'rc_title' => $userDbKey, 'rc_logid > 0' ), __METHOD__ );
                # Hide name from live images
-               $dbw->update( 'oldimage', array("oi_deleted = oi_deleted $op $delUser"),
-                       array('oi_user_text' => $name), __METHOD__ );
+               $dbw->update( 'oldimage', array( "oi_deleted = oi_deleted $op $delUser" ),
+                       array( 'oi_user_text' => $name ), __METHOD__ );
                # Hide name from deleted images
                # WMF - schema change pending
-               # $dbw->update( 'filearchive', array("fa_deleted = fa_deleted $op $delUser"),
-               #       array('fa_user_text' => $name), __METHOD__ );
+               # $dbw->update( 'filearchive', array( "fa_deleted = fa_deleted $op $delUser" ),
+               #       array( 'fa_user_text' => $name ), __METHOD__ );
                # Done!
                return true;
        }
@@ -559,7 +656,7 @@ class IPBlockForm {
        public function doSubmit() {
                global $wgOut;
                $retval = $this->doBlock();
-               if( empty($retval) ) {
+               if( empty( $retval ) ) {
                        $titleObj = SpecialPage::getTitleFor( 'Blockip' );
                        $wgOut->redirect( $titleObj->getFullURL( 'action=success&ip=' .
                                urlencode( $this->BlockAddress ) ) );
@@ -571,7 +668,7 @@ class IPBlockForm {
        public function showSuccess() {
                global $wgOut;
 
-               $wgOut->setPagetitle( wfMsg( 'blockip' ) );
+               $wgOut->setPageTitle( wfMsg( 'blockip-title' ) );
                $wgOut->setSubtitle( wfMsg( 'blockipsuccesssub' ) );
                $text = wfMsgExt( 'blockipsuccesstext', array( 'parse' ), $this->BlockAddress );
                $wgOut->addHTML( $text );
@@ -579,22 +676,44 @@ class IPBlockForm {
 
        private function showLogFragment( $out, $title ) {
                global $wgUser;
-               $out->addHTML( Xml::element( 'h2', NULL, LogPage::logName( 'block' ) ) );
-               $count = LogEventsList::showLogExtract( $out, 'block', $title->getPrefixedText(), '', 10 );
-               if( $count > 10 ) {
-                       $out->addHTML( $wgUser->getSkin()->link(
-                               SpecialPage::getTitleFor( 'Log' ),
-                               wfMsgHtml( 'blocklog-fulllog' ),
-                               array(),
-                               array(
-                                       'type' => 'block',
-                                       'page' => $title->getPrefixedText() ) ) );
-               }
+
+               // Used to support GENDER in 'blocklog-showlog' and 'blocklog-showsuppresslog'
+               $userBlocked = $title->getText();
+
+               LogEventsList::showLogExtract(
+                       $out,
+                       'block',
+                       $title->getPrefixedText(),
+                       '',
+                       array(
+                               'lim' => 10,
+                               'msgKey' => array(
+                                       'blocklog-showlog',
+                                       $userBlocked
+                               ),
+                               'showIfEmpty' => false
+                       )
+               );
+
                // Add suppression block entries if allowed
-               if( $wgUser->isAllowed('hideuser') ) {
-                       $out->addHTML( Xml::element( 'h2', NULL, LogPage::logName( 'suppress' ) ) );
+               if( $wgUser->isAllowed( 'suppressionlog' ) ) {
                        LogEventsList::showLogExtract( $out, 'suppress', $title->getPrefixedText(), '',
-                               10, array('log_action' => array('block','reblock','unblock')) );
+                               array(
+                                       'lim' => 10,
+                                       'conds' => array(
+                                               'log_action' => array(
+                                                       'block',
+                                                       'reblock',
+                                                       'unblock'
+                                               )
+                                       ),
+                                       'msgKey' => array(
+                                               'blocklog-showsuppresslog',
+                                               $userBlocked
+                                       ),
+                                       'showIfEmpty' => false
+                               )
+                       );
                }
        }
 
@@ -636,16 +755,18 @@ class IPBlockForm {
                        $links[] = $this->getContribsLink( $skin );
                $links[] = $this->getUnblockLink( $skin );
                $links[] = $this->getBlockListLink( $skin );
-               $title = Title::makeTitle( NS_MEDIAWIKI, 'Ipbreason-dropdown' );
-               $links[] = $skin->link(
-                       $title,
-                       wfMsgHtml( 'ipb-edit-dropdown' ),
-                       array(),
-                       array( 'action' => 'edit' )
-               );
+               if ( $wgUser->isAllowed( 'editinterface' ) ) {
+                       $title = Title::makeTitle( NS_MEDIAWIKI, 'Ipbreason-dropdown' );
+                       $links[] = $skin->link(
+                               $title,
+                               wfMsgHtml( 'ipb-edit-dropdown' ),
+                               array(),
+                               array( 'action' => 'edit' )
+                       );
+               }
                return '<p class="mw-ipb-conveniencelinks">' . $wgLang->pipeList( $links ) . '</p>';
        }
-       
+
        /**
         * Build a convenient link to a user or IP's contribs
         * form
@@ -655,7 +776,7 @@ class IPBlockForm {
         */
        private function getContribsLink( $skin ) {
                $contribsPage = SpecialPage::getTitleFor( 'Contributions', $this->BlockAddress );
-               return $skin->link( $contribsPage, wfMsgHtml( 'ipb-blocklist-contribs', $this->BlockAddress ) );
+               return $skin->link( $contribsPage, wfMsgExt( 'ipb-blocklist-contribs', 'escape', $this->BlockAddress ) );
        }
 
        /**
@@ -671,15 +792,15 @@ class IPBlockForm {
                $query = array( 'action' => 'unblock' );
 
                if( $this->BlockAddress ) {
-                       $addr = htmlspecialchars( strtr( $this->BlockAddress, '_', ' ' ) );
-                       $message = wfMsgHtml( 'ipb-unblock-addr', $addr );
+                       $addr = strtr( $this->BlockAddress, '_', ' ' );
+                       $message = wfMsg( 'ipb-unblock-addr', $addr );
                        $query['ip'] = $this->BlockAddress;
                } else {
-                       $message = wfMsgHtml( 'ipb-unblock' );
+                       $message = wfMsg( 'ipb-unblock' );
                }
                return $skin->linkKnown(
                        $list,
-                       $message,
+                       htmlspecialchars( $message ),
                        array(),
                        $query
                );
@@ -692,33 +813,21 @@ class IPBlockForm {
         * @return string
         */
        private function getBlockListLink( $skin ) {
-               $list = SpecialPage::getTitleFor( 'Ipblocklist' );
-               $query = array();
-
-               if( $this->BlockAddress ) {
-                       $addr = htmlspecialchars( strtr( $this->BlockAddress, '_', ' ' ) );
-                       $message = wfMsgHtml( 'ipb-blocklist-addr', $addr );
-                       $query['ip'] = $this->BlockAddress;
-               } else {
-                       $message = wfMsgHtml( 'ipb-blocklist' );
-               }
-
                return $skin->linkKnown(
-                       $list,
-                       $message,
-                       array(),
-                       $query
+                       SpecialPage::getTitleFor( 'Ipblocklist' ),
+                       wfMsg( 'ipb-blocklist' )
                );
        }
-       
+
        /**
-       * Block a list of selected users
-       * @param array $users
-       * @param string $reason
-       * @param string $tag replaces user pages
-       * @param string $talkTag replaces user talk pages
-       * @returns array, list of html-safe usernames
-       */
+        * Block a list of selected users
+        *
+        * @param $users Array
+        * @param $reason String
+        * @param $tag String: replaces user pages
+        * @param $talkTag String: replaces user talk pages
+        * @return Array: list of html-safe usernames
+        */
        public static function doMassUserBlock( $users, $reason = '', $tag = '', $talkTag = '' ) {
                global $wgUser;
                $counter = $blockSize = 0;
@@ -735,7 +844,7 @@ class IPBlockForm {
                        }
                        $u = User::newFromName( $name, false );
                        // If user doesn't exist, it ought to be an IP then
-                       if( is_null($u) || (!$u->getId() && !IP::isIPAddress( $u->getName() )) ) {
+                       if( is_null( $u ) || ( !$u->getId() && !IP::isIPAddress( $u->getName() ) ) ) {
                                continue;
                        }
                        $userTitle = $u->getUserPage();
@@ -774,10 +883,10 @@ class IPBlockForm {
                                $log->addEntry( 'block', $userTitle, $reason, $logParams );
                        }
                        # Tag userpage! (check length to avoid mistakes)
-                       if( strlen($tag) > 2 ) {
+                       if( strlen( $tag ) > 2 ) {
                                $userpage->doEdit( $tag, $reason, EDIT_MINOR );
                        }
-                       if( strlen($talkTag) > 2 ) {
+                       if( strlen( $talkTag ) > 2 ) {
                                $usertalk->doEdit( $talkTag, $reason, EDIT_MINOR );
                        }
                }