resoureloader: Consolidate styles-only queue at the top

[lhc/web/wiklou.git] / includes / resourceloader / ResourceLoaderModule.php

diff --git a/includes/resourceloader/ResourceLoaderModule.php b/includes/resourceloader/ResourceLoaderModule.php
index 7f7aa76..3dd7a4b 100644 (file)
--- a/includes/resourceloader/ResourceLoaderModule.php
+++ b/includes/resourceloader/ResourceLoaderModule.php
@@ -67,10 +67,6 @@ abstract class ResourceLoaderModule {
        // In-object cache for module content
        protected $contents = array();
 
-       // Whether the position returned by getPosition() is defined in the module configuration
-       // and not a default value
-       protected $isPositionDefined = false;
-
        /**
         * @var Config
         */
@@ -291,19 +287,6 @@ abstract class ResourceLoaderModule {
                return 'bottom';
        }
 
-       /**
-        * Whether the position returned by getPosition() is a default value or comes from the module
-        * definition. This method is meant to be short-lived, and is only useful until classes added
-        * via addModuleStyles with a default value define an explicit position. See getModuleStyles()
-        * in OutputPage for the related migration warning.
-        *
-        * @return bool
-        * @since  1.26
-        */
-       public function isPositionDefault() {
-               return !$this->isPositionDefined;
-       }
-
        /**
         * Whether this module's JS expects to work without the client-side ResourceLoader module.
         * Returning true from this function will prevent mw.loader.state() call from being
@@ -423,7 +406,7 @@ abstract class ResourceLoaderModule {
        /**
         * Set the files this module depends on indirectly for a given skin.
         *
-        * @since 1.26
+        * @since 1.27
         * @param ResourceLoaderContext $context
         * @param array $localFileRefs List of files
         */
@@ -457,7 +440,7 @@ abstract class ResourceLoaderModule {
         * This is used to make file paths safe for storing in a database without the paths
         * becoming stale or incorrect when MediaWiki is moved or upgraded (T111481).
         *
-        * @since 1.26
+        * @since 1.27
         * @param array $filePaths
         * @return array
         */
@@ -471,7 +454,7 @@ abstract class ResourceLoaderModule {
        /**
         * Expand directories relative to $IP.
         *
-        * @since 1.26
+        * @since 1.27
         * @param array $filePaths
         * @return array
         */
@@ -527,7 +510,7 @@ abstract class ResourceLoaderModule {
        /**
         * Get module-specific LESS variables, if any.
         *
-        * @since 1.26
+        * @since 1.27
         * @param ResourceLoaderContext $context
         * @return array Module-specific LESS variables.
         */
@@ -619,11 +602,11 @@ abstract class ResourceLoaderModule {
                                                                foreach ( $style as $cssText ) {
                                                                        if ( is_string( $cssText ) ) {
                                                                                $stylePairs[$media][] =
-                                                                                       $rl->filter( 'minify-css', $cssText );
+                                                                                       ResourceLoader::filter( 'minify-css', $cssText );
                                                                        }
                                                                }
                                                        } elseif ( is_string( $style ) ) {
-                                                               $stylePairs[$media] = $rl->filter( 'minify-css', $style );
+                                                               $stylePairs[$media] = ResourceLoader::filter( 'minify-css', $style );
                                                        }
                                                }
                                        }
@@ -874,14 +857,13 @@ abstract class ResourceLoaderModule {
        protected function validateScriptFile( $fileName, $contents ) {
                if ( $this->getConfig()->get( 'ResourceLoaderValidateJS' ) ) {
                        // Try for cache hit
-                       // Use CACHE_ANYTHING since parsing JS is much slower than a DB query
-                       $key = wfMemcKey(
+                       $cache = ObjectCache::getLocalClusterInstance();
+                       $key = $cache->makeKey(
                                'resourceloader',
                                'jsparse',
                                self::$parseCacheVersion,
                                md5( $contents )
                        );
-                       $cache = wfGetCache( CACHE_ANYTHING );
                        $cacheEntry = $cache->get( $key );
                        if ( is_string( $cacheEntry ) ) {
                                return $cacheEntry;