/**
* Helper class that detects high-contention DB queries via profiling calls
*
- * This class is meant to work with a DatabaseBase object, which manages queries
+ * This class is meant to work with an IDatabase object, which manages queries
*
* @since 1.24
*/
}
/**
- * @param bool $value
+ * @param bool $value New value
+ * @return bool Old value
* @since 1.28
*/
public function setSilenced( $value ) {
+ $old = $this->silenced;
$this->silenced = $value;
+
+ return $old;
}
/**
}
}
if ( $slow ) {
- $dbs = implode( ', ', array_keys( $this->dbTrxHoldingLocks[$name]['conns'] ) );
- $msg = "Sub-optimal transaction on DB(s) [{$dbs}]:\n";
+ $trace = '';
foreach ( $this->dbTrxMethodTimes[$name] as $i => $info ) {
list( $query, $sTime, $end ) = $info;
- $msg .= sprintf( "%d\t%.6f\t%s\n", $i, ( $end - $sTime ), $query );
+ $trace .= sprintf( "%d\t%.6f\t%s\n", $i, ( $end - $sTime ), $query );
}
- $this->logger->info( $msg );
+ $this->logger->info( "Sub-optimal transaction on DB(s) [{dbs}]: \n{trace}", [
+ 'dbs' => implode( ', ', array_keys( $this->dbTrxHoldingLocks[$name]['conns'] ) ),
+ 'trace' => $trace
+ ] );
}
unset( $this->dbTrxHoldingLocks[$name] );
unset( $this->dbTrxMethodTimes[$name] );