*/
class CSSMin {
- /** @var string Strip marker for comments. **/
+ /** @var string Strip marker for comments. */
const PLACEHOLDER = "\x7fPLACEHOLDER\x7f";
/**
$url = $match['file'][0];
// Skip fully-qualified and protocol-relative URLs and data URIs
- // Also skips the rare `behavior` property specifying application's default behavior
if (
substr( $url, 0, 2 ) === '//' ||
- parse_url( $url, PHP_URL_SCHEME ) ||
- substr( $url, 0, 9 ) === '#default#'
+ parse_url( $url, PHP_URL_SCHEME )
) {
break;
}
+ // Strip trailing anchors - T115436
+ $anchor = strpos( $url, '#' );
+ if ( $anchor !== false ) {
+ $url = substr( $url, 0, $anchor );
+
+ // '#some-anchors' is not a file
+ if ( $url === '' ) {
+ break;
+ }
+ }
+
$files[] = $path . $url;
}
}
* @return string
*/
public static function serializeStringValue( $value ) {
- $value = strtr( $value, [ "\0" => "\xEF\xBF\xBD", '\\' => '\\\\', '"' => '\\"' ] );
+ $value = strtr( $value, [ "\0" => "\u{FFFD}", '\\' => '\\\\', '"' => '\\"' ] );
$value = preg_replace_callback( '/[\x01-\x1f\x7f]/', function ( $match ) {
return '\\' . base_convert( ord( $match[0] ), 10, 16 ) . ' ';
}, $value );
public static function getMimeType( $file ) {
// Infer the MIME-type from the file extension
$ext = strtolower( pathinfo( $file, PATHINFO_EXTENSION ) );
- if ( isset( self::$mimeTypes[$ext] ) ) {
- return self::$mimeTypes[$ext];
- }
-
- return mime_content_type( realpath( $file ) );
+ return self::$mimeTypes[$ext] ?? mime_content_type( realpath( $file ) );
}
/**
// FIXME: Simplify now we only support PHP 7.0.0+
// Note: PCRE doesn't support multiple capture groups with the same name by default.
// - PCRE 6.7 introduced the "J" modifier (PCRE_INFO_JCHANGED for PCRE_DUPNAMES).
- // https://secure.php.net/manual/en/reference.pcre.pattern.modifiers.php
+ // https://www.php.net/manual/en/reference.pcre.pattern.modifiers.php
// However this isn't useful since it just ignores all but the first one.
// Also, while the modifier was introduced in PCRE 6.7 (PHP 5.2+) it was
// not exposed to public preg_* functions until PHP 5.6.0.
// - PCRE 8.36 fixed this to work as expected (e.g. merge conceptually to
// only return the one matched in the part that actually matched).
// However MediaWiki supports 5.5.9, which has PCRE 8.32
- // Per https://secure.php.net/manual/en/pcre.installation.php:
+ // Per https://www.php.net/manual/en/pcre.installation.php:
// - PCRE 8.32 (PHP 5.5.0)
// - PCRE 8.34 (PHP 5.5.10, PHP 5.6.0)
// - PCRE 8.37 (PHP 5.5.26, PHP 5.6.9, PHP 7.0.0)
// Pass thru fully-qualified and protocol-relative URLs and data URIs, as well as local URLs if
// we can't expand them.
- // Also skips the rare `behavior` property specifying application's default behavior
+ // Also skips anchors or the rare `behavior` property specifying application's default behavior
if (
self::isRemoteUrl( $url ) ||
self::isLocalUrl( $url ) ||
- substr( $url, 0, 9 ) === '#default#'
+ substr( $url, 0, 1 ) === '#'
) {
return $url;
}