(bug 20275) Fixed LIKE queries on SQLite backend
[lhc/web/wiklou.git] / includes / filerepo / LocalRepo.php
index 0d7fbf0..6c4d21a 100644 (file)
@@ -7,24 +7,14 @@
 class LocalRepo extends FSRepo {
        var $fileFactory = array( 'LocalFile', 'newFromTitle' );
        var $oldFileFactory = array( 'OldLocalFile', 'newFromTitle' );
-
-       function getSlaveDB() {
-               return wfGetDB( DB_SLAVE );
-       }
-
-       function getMasterDB() {
-               return wfGetDB( DB_MASTER );
-       }
-
-       function getMemcKey( $key ) {
-               return wfWikiID( $this->getSlaveDB() ) . ":{$key}";
-       }
+       var $fileFromRowFactory = array( 'LocalFile', 'newFromRow' );
+       var $oldFileFromRowFactory = array( 'OldLocalFile', 'newFromRow' );
 
        function newFileFromRow( $row ) {
                if ( isset( $row->img_name ) ) {
-                       return LocalFile::newFromRow( $row, $this );
+                       return call_user_func( $this->fileFromRowFactory, $row, $this );
                } elseif ( isset( $row->oi_name ) ) {
-                       return OldLocalFile::newFromRow( $row, $this );
+                       return call_user_func( $this->oldFileFromRowFactory, $row, $this );
                } else {
                        throw new MWException( __METHOD__.': invalid row' );
                }
@@ -59,8 +49,8 @@ class LocalRepo extends FSRepo {
                                $ext = File::normalizeExtension($ext);
                                $inuse = $dbw->selectField( 'oldimage', '1',
                                        array( 'oi_sha1' => $sha1,
-                                               "oi_archive_name LIKE '%.{$ext}'",
-                                               'oi_deleted & '.File::DELETED_FILE => File::DELETED_FILE ),
+                                               'oi_archive_name ' . $dbw->buildLike( $dbw->anyString(), ".$ext" ),
+                                               $dbw->bitAnd('oi_deleted', File::DELETED_FILE) => File::DELETED_FILE ),
                                        __METHOD__, array( 'FOR UPDATE' ) );
                        }
                        if ( !$inuse ) {
@@ -77,28 +67,12 @@ class LocalRepo extends FSRepo {
                }
                return $status;
        }
-
+       
        /**
-        * Function link Title::getArticleID().
-        * We can't say Title object, what database it should use, so we duplicate that function here.
+        * Checks if there is a redirect named as $title
+        *
+        * @param Title $title Title of image
         */
-       protected function getArticleID( $title ) {
-               if( !$title instanceof Title ) {
-                       return 0;
-               }
-               $dbr = $this->getSlaveDB();
-               $id = $dbr->selectField(
-                       'page', // Table
-                       'page_id',      //Field
-                       array(  //Conditions
-                               'page_namespace' => $title->getNamespace(),
-                               'page_title' => $title->getDbKey(),
-                       ),
-                       __METHOD__      //Function name
-               );
-               return $id;
-       }
-
        function checkRedirect( $title ) {
                global $wgMemc;
 
@@ -106,20 +80,27 @@ class LocalRepo extends FSRepo {
                        $title = Title::newFromTitle( $title );
                }
                if( $title instanceof Title && $title->getNamespace() == NS_MEDIA ) {
-                       $title = Title::makeTitle( NS_IMAGE, $title->getText() );
+                       $title = Title::makeTitle( NS_FILE, $title->getText() );
                }
 
-               $memcKey = $this->getMemcKey( "image_redirect:" . md5( $title->getPrefixedDBkey() ) );
+               $memcKey = $this->getSharedCacheKey( 'image_redirect', md5( $title->getDBkey() ) );
+               if ( $memcKey === false ) {
+                       $memcKey = $this->getLocalCacheKey( 'image_redirect', md5( $title->getDBkey() ) );
+                       $expiry = 300; // no invalidation, 5 minutes
+               } else {
+                       $expiry = 86400; // has invalidation, 1 day
+               }
                $cachedValue = $wgMemc->get( $memcKey );
-               if( $cachedValue ) {
-                       return Title::newFromDbKey( $cachedValue );
-               } elseif( $cachedValue == ' ' ) { # FIXME: ugly hack, but BagOStuff caching seems to be weird and return false if !cachedValue, not only if it doesn't exist
+               if ( $cachedValue === ' '  || $cachedValue === '' ) {
+                       // Does not exist
                        return false;
-               }
+               } elseif ( strval( $cachedValue ) !== '' ) {
+                       return Title::newFromText( $cachedValue, NS_FILE );
+               } // else $cachedValue is false or null: cache miss
 
                $id = $this->getArticleID( $title );
                if( !$id ) {
-                       $wgMemc->set( $memcKey, " ", 9000 );
+                       $wgMemc->set( $memcKey, " ", $expiry );
                        return false;
                }
                $dbr = $this->getSlaveDB();
@@ -130,20 +111,42 @@ class LocalRepo extends FSRepo {
                        __METHOD__
                );
 
-               if( $row ) $targetTitle = Title::makeTitle( $row->rd_namespace, $row->rd_title );
-               $wgMemc->set( $memcKey, ($row ? $targetTitle->getPrefixedDBkey() : " "), 9000 );
-               if( !$row ) {
+               if( $row && $row->rd_namespace == NS_FILE ) {
+                       $targetTitle = Title::makeTitle( $row->rd_namespace, $row->rd_title );
+                       $wgMemc->set( $memcKey, $targetTitle->getDBkey(), $expiry );
+                       return $targetTitle;
+               } else {
+                       $wgMemc->set( $memcKey, '', $expiry );
                        return false;
                }
-               return $targetTitle;
        }
 
-       function invalidateImageRedirect( $title ) {
-               global $wgMemc;
-               $memcKey = $this->getMemcKey( "image_redirect:" . md5( $title->getPrefixedDBkey() ) );
-               $wgMemc->delete( $memcKey );
+
+       /**
+        * Function link Title::getArticleID().
+        * We can't say Title object, what database it should use, so we duplicate that function here.
+        */
+       protected function getArticleID( $title ) {
+               if( !$title instanceof Title ) {
+                       return 0;
+               }
+               $dbr = $this->getSlaveDB();
+               $id = $dbr->selectField(
+                       'page', // Table
+                       'page_id',      //Field
+                       array(  //Conditions
+                               'page_namespace' => $title->getNamespace(),
+                               'page_title' => $title->getDBkey(),
+                       ),
+                       __METHOD__      //Function name
+               );
+               return $id;
        }
-       
+
+       /**
+        * Get an array or iterator of file objects for files that have a given 
+        * SHA-1 content hash.
+        */
        function findBySha1( $hash ) {
                $dbr = $this->getSlaveDB();
                $res = $dbr->select(
@@ -158,36 +161,42 @@ class LocalRepo extends FSRepo {
                $res->free();
                return $result;
        }
-       
-       function findFiles( &$titles, $flags ) {
-               if ( count( $titles ) == 0 ) return array();            
-       
-               $dbKeys = array();
-               $indices = array();
-               
-               foreach ( $titles as $index => $title ) {
-                       if ( !( $title instanceof Title ) )
-                               $title = Title::makeTitleSafe( NS_IMAGE, $title );
-                       if ( is_object( $title ) ) {
-                               $key = $title->getDBkey();
-                               $indices[$key] = $index;
-                               $dbKeys[] = $key;
-                       }
-               }
-       
-               $dbr = $this->getSlaveDB();
-               $res = $dbr->select(
-                       'image',
-                       LocalFile::selectFields(),
-                       array( 'img_name' => $dbKeys )          
-               );
-               
-               $result = array();
-               while ( $row = $res->fetchObject() ) {
-                       $result[$row->img_name] = $this->newFileFromRow( $row );
-                       unset( $titles[$indices[$row->img_name]] );
+
+       /**
+        * Get a connection to the slave DB
+        */
+       function getSlaveDB() {
+               return wfGetDB( DB_SLAVE );
+       }
+
+       /**
+        * Get a connection to the master DB
+        */
+       function getMasterDB() {
+               return wfGetDB( DB_MASTER );
+       }
+
+       /**
+        * Get a key on the primary cache for this repository.
+        * Returns false if the repository's cache is not accessible at this site. 
+        * The parameters are the parts of the key, as for wfMemcKey().
+        */
+       function getSharedCacheKey( /*...*/ ) {
+               $args = func_get_args();
+               return call_user_func_array( 'wfMemcKey', $args );
+       }
+
+       /**
+        * Invalidates image redirect cache related to that image
+        *
+        * @param Title $title Title of image
+        */     
+       function invalidateImageRedirect( $title ) {
+               global $wgMemc;
+               $memcKey = $this->getSharedCacheKey( 'image_redirect', md5( $title->getDBkey() ) );
+               if ( $memcKey ) {
+                       $wgMemc->delete( $memcKey );
                }
-               $res->free();
-               return $result;
        }
 }
+