* (bug 20131) PHP Notice: Undfined index: page_latest in includes/ChangesList.php...
[lhc/web/wiklou.git] / includes / api / ApiQueryUserContributions.php
index 75a7edd..297e5c8 100644 (file)
@@ -5,7 +5,7 @@
  *
  * API for MediaWiki 1.8+
  *
- * Copyright (C) 2006 Yuri Astrakhan <FirstnameLastname@gmail.com>
+ * Copyright (C) 2006 Yuri Astrakhan <Firstname><Lastname>@gmail.com
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -29,7 +29,9 @@ if (!defined('MEDIAWIKI')) {
 }
 
 /**
- * @addtogroup API
+ * This query action adds a list of a specified user's contributions to the output.
+ *
+ * @ingroup API
  */
 class ApiQueryContributions extends ApiQueryBase {
 
@@ -37,91 +39,283 @@ class ApiQueryContributions extends ApiQueryBase {
                parent :: __construct($query, $moduleName, 'uc');
        }
 
-       public function execute() {
+       private $params, $username;
+       private $fld_ids = false, $fld_title = false, $fld_timestamp = false,
+                       $fld_comment = false, $fld_flags = false,
+                       $fld_patrolled = false, $fld_tags = false;
 
-               $this->selectNamedDB('contributions', DB_SLAVE, 'contributions');
+       public function execute() {
 
-               //Blank all our variables
-               $limit = $user = $start = $end = $dir = null;
+               // Parse some parameters
+               $this->params = $this->extractRequestParams();
 
-               //Get our parameters out
-               extract($this->extractRequestParams());
+               $prop = array_flip($this->params['prop']);
+               $this->fld_ids = isset($prop['ids']);
+               $this->fld_title = isset($prop['title']);
+               $this->fld_comment = isset($prop['comment']);
+               $this->fld_size = isset($prop['size']);
+               $this->fld_flags = isset($prop['flags']);
+               $this->fld_timestamp = isset($prop['timestamp']);
+               $this->fld_patrolled = isset($prop['patrolled']);
+               $this->fld_tags = isset($prop['tags']);
 
-               //Get a database instance
+               // TODO: if the query is going only against the revision table, should this be done?
+               $this->selectNamedDB('contributions', DB_SLAVE, 'contributions');
                $db = $this->getDB();
 
-               if (is_null($user))
-                       $this->dieUsage("User parameter may not be empty", 'param_user');
-
-               //Get the table names
-               list ($tbl_page, $tbl_revision) = $db->tableNamesN('page', 'revision');
-
-               //We're after the revision table, and the corresponding page row for
-               //anything we retrieve.
-               $this->addTables("$tbl_revision LEFT OUTER JOIN $tbl_page ON " .
-                       "page_id=rev_page");
-
-               //We want to know the namespace, title, new-ness, and ID of a page,
-               // and the id, text-id, timestamp, minor-status, summary and page
-               // of a revision.
-               $this->addFields(array('page_namespace', 'page_title', 'page_is_new',
-                       'rev_id', 'rev_text_id', 'rev_timestamp', 'rev_minor_edit',
-                               'rev_comment', 'rev_page'));
-
-               // We only want pages by the specified user.
-               $this->addWhereFld('rev_user_text', $user);
-               // ... and in the specified timeframe.
-               $this->addWhereRange('rev_timestamp', $dir, $start, $end );
+               if(isset($this->params['userprefix']))
+               {
+                       $this->prefixMode = true;
+                       $this->multiUserMode = true;
+                       $this->userprefix = $this->params['userprefix'];
+               }
+               else
+               {
+                       $this->usernames = array();
+                       if(!is_array($this->params['user']))
+                               $this->params['user'] = array($this->params['user']);
+                       foreach($this->params['user'] as $u)
+                               $this->prepareUsername($u);
+                       $this->prefixMode = false;
+                       $this->multiUserMode = (count($this->params['user']) > 1);
+               }
+               $this->prepareQuery();
 
-               $this->addOption('LIMIT', $limit + 1);
+               //Do the actual query.
+               $res = $this->select( __METHOD__ );
 
                //Initialise some variables
-               $data = array ();
                $count = 0;
-
-               //Do the actual query.
-               $res = $this->select( __METHOD__ );
+               $limit = $this->params['limit'];
 
                //Fetch each row
                while ( $row = $db->fetchObject( $res ) ) {
                        if (++ $count > $limit) {
                                // We've reached the one extra which shows that there are additional pages to be had. Stop here...
-                               $this->setContinueEnumParameter('start', $row->rev_timestamp);
+                               if($this->multiUserMode)
+                                       $this->setContinueEnumParameter('continue', $this->continueStr($row));
+                               else
+                                       $this->setContinueEnumParameter('start', wfTimestamp(TS_ISO_8601, $row->rev_timestamp));
+                               break;
+                       }
+
+                       $vals = $this->extractRowInfo($row);
+                       $fit = $this->getResult()->addValue(array('query', $this->getModuleName()), null, $vals);
+                       if(!$fit)
+                       {
+                               if($this->multiUserMode)
+                                       $this->setContinueEnumParameter('continue', $this->continueStr($row));
+                               else
+                                       $this->setContinueEnumParameter('start', wfTimestamp(TS_ISO_8601, $row->rev_timestamp));
                                break;
                        }
+               }
 
-                       //There's a fancy function in ApiQueryBase that does
-                       // most of the work for us. Use that for the page
-                       // and revision.
-                       $revvals = $this->addRowInfo('rev', $row);
-                       $pagevals = $this->addRowInfo('page', $row);
+               //Free the database record so the connection can get on with other stuff
+               $db->freeResult($res);
 
-                       //If we got data on the revision only, use only
-                       // that data.
-                       if($revvals && !$pagevals) {
-                               $data[] = $revvals;
+               $this->getResult()->setIndexedTagName_internal(array('query', $this->getModuleName()), 'item');
+       }
+
+       /**
+        * Validate the 'user' parameter and set the value to compare
+        * against `revision`.`rev_user_text`
+        */
+       private function prepareUsername($user) {
+               if( $user ) {
+                       $name = User::isIP( $user )
+                               ? $user
+                               : User::getCanonicalName( $user, 'valid' );
+                       if( $name === false ) {
+                               $this->dieUsage( "User name {$user} is not valid", 'param_user' );
+                       } else {
+                               $this->usernames[] = $name;
                        }
-                       //If we got data on the page only, use only
-                       // that data.
-                       else if($pagevals && !$revvals) {
-                               $data[] = $pagevals;
+               } else {
+                       $this->dieUsage( 'User parameter may not be empty', 'param_user' );
+               }
+       }
+
+       /**
+        * Prepares the query and returns the limit of rows requested
+        */
+       private function prepareQuery() {
+               // We're after the revision table, and the corresponding page
+               // row for anything we retrieve. We may also need the
+               // recentchanges row and/or tag summary row.
+               global $wgUser;
+               $tables = array('page', 'revision'); // Order may change
+               $this->addWhere('page_id=rev_page');
+
+               // Handle continue parameter
+               if($this->multiUserMode && !is_null($this->params['continue']))
+               {
+                       $continue = explode('|', $this->params['continue']);
+                       if(count($continue) != 2)
+                               $this->dieUsage("Invalid continue param. You should pass the original " .
+                                       "value returned by the previous query", "_badcontinue");
+                       $encUser = $this->getDB()->strencode($continue[0]);
+                       $encTS = wfTimestamp(TS_MW, $continue[1]);
+                       $op = ($this->params['dir'] == 'older' ? '<' : '>');
+                       $this->addWhere("rev_user_text $op '$encUser' OR " .
+                                       "(rev_user_text = '$encUser' AND " .
+                                       "rev_timestamp $op= '$encTS')");
+               }
+
+               if(!$wgUser->isAllowed('hideuser'))
+                       $this->addWhere($this->getDB()->bitAnd('rev_deleted',Revision::DELETED_USER) . ' = 0');
+               // We only want pages by the specified users.
+               if($this->prefixMode)
+                       $this->addWhere("rev_user_text LIKE '" . $this->getDB()->escapeLike($this->userprefix) . "%'");
+               else
+                       $this->addWhereFld('rev_user_text', $this->usernames);
+               // ... and in the specified timeframe.
+               // Ensure the same sort order for rev_user_text and rev_timestamp
+               // so our query is indexed
+               if($this->multiUserMode)
+                       $this->addWhereRange('rev_user_text', $this->params['dir'], null, null);
+               $this->addWhereRange('rev_timestamp',
+                       $this->params['dir'], $this->params['start'], $this->params['end'] );
+               $this->addWhereFld('page_namespace', $this->params['namespace']);
+
+               $show = $this->params['show'];
+               if (!is_null($show)) {
+                       $show = array_flip($show);
+                       if ((isset($show['minor']) && isset($show['!minor']))
+                                       || (isset($show['patrolled']) && isset($show['!patrolled'])))
+                               $this->dieUsage("Incorrect parameter - mutually exclusive values may not be supplied", 'show');
+
+                       $this->addWhereIf('rev_minor_edit = 0', isset($show['!minor']));
+                       $this->addWhereIf('rev_minor_edit != 0', isset($show['minor']));
+                       $this->addWhereIf('rc_patrolled = 0', isset($show['!patrolled']));
+                       $this->addWhereIf('rc_patrolled != 0', isset($show['patrolled']));
+               }
+               $this->addOption('LIMIT', $this->params['limit'] + 1);
+               $index['revision'] = 'usertext_timestamp';
+
+               // Mandatory fields: timestamp allows request continuation
+               // ns+title checks if the user has access rights for this page
+               // user_text is necessary if multiple users were specified
+               $this->addFields(array(
+                       'rev_timestamp',
+                       'page_namespace',
+                       'page_title',
+                       'rev_user_text',
+                       'rev_deleted'
+               ));
+               
+               if(isset($show['patrolled']) || isset($show['!patrolled']) ||
+                                $this->fld_patrolled)
+               {
+                       global $wgUser;
+                       if(!$wgUser->useRCPatrol() && !$wgUser->useNPPatrol())
+                               $this->dieUsage("You need the patrol right to request the patrolled flag", 'permissiondenied');
+                       // Use a redundant join condition on both
+                       // timestamp and ID so we can use the timestamp
+                       // index
+                       $index['recentchanges'] = 'rc_user_text';
+                       if(isset($show['patrolled']) || isset($show['!patrolled']))
+                       {
+                               // Put the tables in the right order for
+                               // STRAIGHT_JOIN
+                               $tables = array('revision', 'recentchanges', 'page');
+                               $this->addOption('STRAIGHT_JOIN');
+                               $this->addWhere('rc_user_text=rev_user_text');
+                               $this->addWhere('rc_timestamp=rev_timestamp');
+                               $this->addWhere('rc_this_oldid=rev_id');
                        }
-                       //... and if we got data on both the revision and
-                       // the page, merge the data and send it out.
-                       else if($pagevals && $revvals) {
-                               $data[] = array_merge($revvals, $pagevals);
+                       else
+                       {
+                               $tables[] = 'recentchanges';
+                               $this->addJoinConds(array('recentchanges' => array(
+                                       'LEFT JOIN', array(
+                                               'rc_user_text=rev_user_text',
+                                               'rc_timestamp=rev_timestamp',
+                                               'rc_this_oldid=rev_id'))));
                        }
                }
 
-               //Free the database record so the connection can get on with other stuff
-               $db->freeResult($res);
+               $this->addTables($tables);
+               $this->addOption('USE INDEX', $index);
+               $this->addFieldsIf('rev_page', $this->fld_ids);
+               $this->addFieldsIf('rev_id', $this->fld_ids || $this->fld_flags);
+               $this->addFieldsIf('page_latest', $this->fld_flags);
+               // $this->addFieldsIf('rev_text_id', $this->fld_ids); // Should this field be exposed?
+               $this->addFieldsIf('rev_comment', $this->fld_comment);
+               $this->addFieldsIf('rev_len', $this->fld_size);
+               $this->addFieldsIf('rev_minor_edit', $this->fld_flags);
+               $this->addFieldsIf('rev_parent_id', $this->fld_flags);
+               $this->addFieldsIf('rc_patrolled', $this->fld_patrolled);
+               
+               if($this->fld_tags || !is_null($this->params['tag'])) {
+                       $this->addTables('tag_summary');
+                       $this->addJoinConds(array('tag_summary' => array('LEFT JOIN', array('rev_id=ts_rev_id'))));
+                       $this->addFields('ts_tags');
+               }
+               
+               if( !is_null($this->params['tag']) ) {
+                       $this->addWhereFld('ts_tags', $this->params['tag']);
+               }
+       }
+
+       /**
+        * Extract fields from the database row and append them to a result array
+        */
+       private function extractRowInfo($row) {
+
+               $vals = array();
+
+               $vals['user'] = $row->rev_user_text;
+               if ($row->rev_deleted & Revision::DELETED_USER)
+                       $vals['userhidden'] = '';
+               if ($this->fld_ids) {
+                       $vals['pageid'] = intval($row->rev_page);
+                       $vals['revid'] = intval($row->rev_id);
+                       // $vals['textid'] = intval($row->rev_text_id); // todo: Should this field be exposed?
+               }
+
+               if ($this->fld_title)
+                       ApiQueryBase :: addTitleInfo($vals,
+                               Title :: makeTitle($row->page_namespace, $row->page_title));
 
-               //And send the whole shebang out as output.
-               $this->getResult()->setIndexedTagName($data, 'item');
-               $this->getResult()->addValue('query', $this->getModuleName(), $data);
+               if ($this->fld_timestamp)
+                       $vals['timestamp'] = wfTimestamp(TS_ISO_8601, $row->rev_timestamp);
+
+               if ($this->fld_flags) {
+                       if ($row->rev_parent_id == 0 && !is_null($row->rev_parent_id))
+                               $vals['new'] = '';
+                       if ($row->rev_minor_edit)
+                               $vals['minor'] = '';
+                       if ($row->page_latest == $row->rev_id)
+                               $vals['top'] = '';
+               }
+
+               if ($this->fld_comment && isset($row->rev_comment)) {
+                       if ($row->rev_deleted & Revision::DELETED_COMMENT)
+                               $vals['commenthidden'] = '';
+                       else
+                               $vals['comment'] = $row->rev_comment;
+               }
+
+               if ($this->fld_patrolled && $row->rc_patrolled)
+                       $vals['patrolled'] = '';
+               
+               if ($this->fld_size && !is_null($row->rev_len))
+                       $vals['size'] = intval($row->rev_len);
+
+               if ($this->fld_tags && $row->ts_tags)
+                       $vals['tags'] = $row->ts_tags;
+                       
+               return $vals;
+       }
+       
+       private function continueStr($row)
+       {
+               return $row->rev_user_text . '|' .
+                       wfTimestamp(TS_ISO_8601, $row->rev_timestamp);
        }
 
-       protected function getAllowedParams() {
+       public function getAllowedParams() {
                return array (
                        'limit' => array (
                                ApiBase :: PARAM_DFLT => 10,
@@ -136,36 +330,74 @@ class ApiQueryContributions extends ApiQueryBase {
                        'end' => array (
                                ApiBase :: PARAM_TYPE => 'timestamp'
                        ),
+                       'continue' => null,
                        'user' => array (
-                               ApiBase :: PARAM_TYPE => 'user'
+                               ApiBase :: PARAM_ISMULTI => true
                        ),
+                       'userprefix' => null,
                        'dir' => array (
                                ApiBase :: PARAM_DFLT => 'older',
                                ApiBase :: PARAM_TYPE => array (
                                        'newer',
                                        'older'
                                )
-                       )
+                       ),
+                       'namespace' => array (
+                               ApiBase :: PARAM_ISMULTI => true,
+                               ApiBase :: PARAM_TYPE => 'namespace'
+                       ),
+                       'prop' => array (
+                               ApiBase :: PARAM_ISMULTI => true,
+                               ApiBase :: PARAM_DFLT => 'ids|title|timestamp|comment|size|flags',
+                               ApiBase :: PARAM_TYPE => array (
+                                       'ids',
+                                       'title',
+                                       'timestamp',
+                                       'comment',
+                                       'size',
+                                       'flags',
+                                       'patrolled',
+                                       'tags',
+                               )
+                       ),
+                       'show' => array (
+                               ApiBase :: PARAM_ISMULTI => true,
+                               ApiBase :: PARAM_TYPE => array (
+                                       'minor',
+                                       '!minor',
+                                       'patrolled',
+                                       '!patrolled',
+                               )
+                       ),
+                       'tag' => null,
                );
        }
 
-       protected function getParamDescription() {
+       public function getParamDescription() {
                return array (
                        'limit' => 'The maximum number of contributions to return.',
                        'start' => 'The start timestamp to return from.',
                        'end' => 'The end timestamp to return to.',
+                       'continue' => 'When more results are available, use this to continue.',
                        'user' => 'The user to retrieve contributions for.',
-                       'dir' => 'The direction to search (older or newer).'
+                       'userprefix' => 'Retrieve contibutions for all users whose names begin with this value. Overrides ucuser.',
+                       'dir' => 'The direction to search (older or newer).',
+                       'namespace' => 'Only list contributions in these namespaces',
+                       'prop' => 'Include additional pieces of information',
+                       'show' => array('Show only items that meet this criteria, e.g. non minor edits only: show=!minor',
+                                       'NOTE: if show=patrolled or show=!patrolled is set, revisions older than $wgRCMaxAge won\'t be shown',),
+                       'tag' => 'Only list contributions with this tag',
                );
        }
 
-       protected function getDescription() {
-               return 'Get edits by a user..';
+       public function getDescription() {
+               return 'Get all edits by a user';
        }
 
        protected function getExamples() {
                return array (
-                       'api.php?action=query&list=usercontribs&ucuser=YurikBot'
+                       'api.php?action=query&list=usercontribs&ucuser=YurikBot',
+                       'api.php?action=query&list=usercontribs&ucuserprefix=217.121.114.',
                );
        }
 
@@ -173,4 +405,3 @@ class ApiQueryContributions extends ApiQueryBase {
                return __CLASS__ . ': $Id$';
        }
 }
-?>