* (bug 20131) PHP Notice: Undfined index: page_latest in includes/ChangesList.php...
[lhc/web/wiklou.git] / includes / api / ApiQueryUserContributions.php
index 6a90658..297e5c8 100644 (file)
@@ -41,7 +41,8 @@ class ApiQueryContributions extends ApiQueryBase {
 
        private $params, $username;
        private $fld_ids = false, $fld_title = false, $fld_timestamp = false,
-                       $fld_comment = false, $fld_flags = false;
+                       $fld_comment = false, $fld_flags = false,
+                       $fld_patrolled = false, $fld_tags = false;
 
        public function execute() {
 
@@ -52,8 +53,11 @@ class ApiQueryContributions extends ApiQueryBase {
                $this->fld_ids = isset($prop['ids']);
                $this->fld_title = isset($prop['title']);
                $this->fld_comment = isset($prop['comment']);
+               $this->fld_size = isset($prop['size']);
                $this->fld_flags = isset($prop['flags']);
                $this->fld_timestamp = isset($prop['timestamp']);
+               $this->fld_patrolled = isset($prop['patrolled']);
+               $this->fld_tags = isset($prop['tags']);
 
                // TODO: if the query is going only against the revision table, should this be done?
                $this->selectNamedDB('contributions', DB_SLAVE, 'contributions');
@@ -81,7 +85,6 @@ class ApiQueryContributions extends ApiQueryBase {
                $res = $this->select( __METHOD__ );
 
                //Initialise some variables
-               $data = array ();
                $count = 0;
                $limit = $this->params['limit'];
 
@@ -97,16 +100,21 @@ class ApiQueryContributions extends ApiQueryBase {
                        }
 
                        $vals = $this->extractRowInfo($row);
-                       if ($vals)
-                               $data[] = $vals;
+                       $fit = $this->getResult()->addValue(array('query', $this->getModuleName()), null, $vals);
+                       if(!$fit)
+                       {
+                               if($this->multiUserMode)
+                                       $this->setContinueEnumParameter('continue', $this->continueStr($row));
+                               else
+                                       $this->setContinueEnumParameter('start', wfTimestamp(TS_ISO_8601, $row->rev_timestamp));
+                               break;
+                       }
                }
 
                //Free the database record so the connection can get on with other stuff
                $db->freeResult($res);
 
-               //And send the whole shebang out as output.
-               $this->getResult()->setIndexedTagName($data, 'item');
-               $this->getResult()->addValue('query', $this->getModuleName(), $data);
+               $this->getResult()->setIndexedTagName_internal(array('query', $this->getModuleName()), 'item');
        }
 
        /**
@@ -132,12 +140,13 @@ class ApiQueryContributions extends ApiQueryBase {
         * Prepares the query and returns the limit of rows requested
         */
        private function prepareQuery() {
-
-               //We're after the revision table, and the corresponding page row for
-               //anything we retrieve.
-               $this->addTables(array('revision', 'page'));
+               // We're after the revision table, and the corresponding page
+               // row for anything we retrieve. We may also need the
+               // recentchanges row and/or tag summary row.
+               global $wgUser;
+               $tables = array('page', 'revision'); // Order may change
                $this->addWhere('page_id=rev_page');
-               
+
                // Handle continue parameter
                if($this->multiUserMode && !is_null($this->params['continue']))
                {
@@ -153,16 +162,18 @@ class ApiQueryContributions extends ApiQueryBase {
                                        "rev_timestamp $op= '$encTS')");
                }
 
-               $this->addWhereFld('rev_deleted', 0);
+               if(!$wgUser->isAllowed('hideuser'))
+                       $this->addWhere($this->getDB()->bitAnd('rev_deleted',Revision::DELETED_USER) . ' = 0');
                // We only want pages by the specified users.
                if($this->prefixMode)
-                       $this->addWhere("rev_user_text LIKE '" . $this->getDb()->escapeLike($this->userprefix) . "%'");
+                       $this->addWhere("rev_user_text LIKE '" . $this->getDB()->escapeLike($this->userprefix) . "%'");
                else
                        $this->addWhereFld('rev_user_text', $this->usernames);
                // ... and in the specified timeframe.
                // Ensure the same sort order for rev_user_text and rev_timestamp
                // so our query is indexed
-               $this->addWhereRange('rev_user_text', $this->params['dir'], null, null);
+               if($this->multiUserMode)
+                       $this->addWhereRange('rev_user_text', $this->params['dir'], null, null);
                $this->addWhereRange('rev_timestamp',
                        $this->params['dir'], $this->params['start'], $this->params['end'] );
                $this->addWhereFld('page_namespace', $this->params['namespace']);
@@ -170,14 +181,17 @@ class ApiQueryContributions extends ApiQueryBase {
                $show = $this->params['show'];
                if (!is_null($show)) {
                        $show = array_flip($show);
-                       if (isset ($show['minor']) && isset ($show['!minor']))
+                       if ((isset($show['minor']) && isset($show['!minor']))
+                                       || (isset($show['patrolled']) && isset($show['!patrolled'])))
                                $this->dieUsage("Incorrect parameter - mutually exclusive values may not be supplied", 'show');
 
-                       $this->addWhereIf('rev_minor_edit = 0', isset ($show['!minor']));
-                       $this->addWhereIf('rev_minor_edit != 0', isset ($show['minor']));
+                       $this->addWhereIf('rev_minor_edit = 0', isset($show['!minor']));
+                       $this->addWhereIf('rev_minor_edit != 0', isset($show['minor']));
+                       $this->addWhereIf('rc_patrolled = 0', isset($show['!patrolled']));
+                       $this->addWhereIf('rc_patrolled != 0', isset($show['patrolled']));
                }
                $this->addOption('LIMIT', $this->params['limit'] + 1);
-               $this->addOption( 'FORCE INDEX', 'user_name' );
+               $index['revision'] = 'usertext_timestamp';
 
                // Mandatory fields: timestamp allows request continuation
                // ns+title checks if the user has access rights for this page
@@ -187,15 +201,61 @@ class ApiQueryContributions extends ApiQueryBase {
                        'page_namespace',
                        'page_title',
                        'rev_user_text',
-                       ));
+                       'rev_deleted'
+               ));
+               
+               if(isset($show['patrolled']) || isset($show['!patrolled']) ||
+                                $this->fld_patrolled)
+               {
+                       global $wgUser;
+                       if(!$wgUser->useRCPatrol() && !$wgUser->useNPPatrol())
+                               $this->dieUsage("You need the patrol right to request the patrolled flag", 'permissiondenied');
+                       // Use a redundant join condition on both
+                       // timestamp and ID so we can use the timestamp
+                       // index
+                       $index['recentchanges'] = 'rc_user_text';
+                       if(isset($show['patrolled']) || isset($show['!patrolled']))
+                       {
+                               // Put the tables in the right order for
+                               // STRAIGHT_JOIN
+                               $tables = array('revision', 'recentchanges', 'page');
+                               $this->addOption('STRAIGHT_JOIN');
+                               $this->addWhere('rc_user_text=rev_user_text');
+                               $this->addWhere('rc_timestamp=rev_timestamp');
+                               $this->addWhere('rc_this_oldid=rev_id');
+                       }
+                       else
+                       {
+                               $tables[] = 'recentchanges';
+                               $this->addJoinConds(array('recentchanges' => array(
+                                       'LEFT JOIN', array(
+                                               'rc_user_text=rev_user_text',
+                                               'rc_timestamp=rev_timestamp',
+                                               'rc_this_oldid=rev_id'))));
+                       }
+               }
 
+               $this->addTables($tables);
+               $this->addOption('USE INDEX', $index);
                $this->addFieldsIf('rev_page', $this->fld_ids);
                $this->addFieldsIf('rev_id', $this->fld_ids || $this->fld_flags);
                $this->addFieldsIf('page_latest', $this->fld_flags);
                // $this->addFieldsIf('rev_text_id', $this->fld_ids); // Should this field be exposed?
                $this->addFieldsIf('rev_comment', $this->fld_comment);
+               $this->addFieldsIf('rev_len', $this->fld_size);
                $this->addFieldsIf('rev_minor_edit', $this->fld_flags);
-               $this->addFieldsIf('page_is_new', $this->fld_flags);
+               $this->addFieldsIf('rev_parent_id', $this->fld_flags);
+               $this->addFieldsIf('rc_patrolled', $this->fld_patrolled);
+               
+               if($this->fld_tags || !is_null($this->params['tag'])) {
+                       $this->addTables('tag_summary');
+                       $this->addJoinConds(array('tag_summary' => array('LEFT JOIN', array('rev_id=ts_rev_id'))));
+                       $this->addFields('ts_tags');
+               }
+               
+               if( !is_null($this->params['tag']) ) {
+                       $this->addWhereFld('ts_tags', $this->params['tag']);
+               }
        }
 
        /**
@@ -206,6 +266,8 @@ class ApiQueryContributions extends ApiQueryBase {
                $vals = array();
 
                $vals['user'] = $row->rev_user_text;
+               if ($row->rev_deleted & Revision::DELETED_USER)
+                       $vals['userhidden'] = '';
                if ($this->fld_ids) {
                        $vals['pageid'] = intval($row->rev_page);
                        $vals['revid'] = intval($row->rev_id);
@@ -220,7 +282,7 @@ class ApiQueryContributions extends ApiQueryBase {
                        $vals['timestamp'] = wfTimestamp(TS_ISO_8601, $row->rev_timestamp);
 
                if ($this->fld_flags) {
-                       if ($row->page_is_new)
+                       if ($row->rev_parent_id == 0 && !is_null($row->rev_parent_id))
                                $vals['new'] = '';
                        if ($row->rev_minor_edit)
                                $vals['minor'] = '';
@@ -228,9 +290,22 @@ class ApiQueryContributions extends ApiQueryBase {
                                $vals['top'] = '';
                }
 
-               if ($this->fld_comment && isset( $row->rev_comment ) )
-                       $vals['comment'] = $row->rev_comment;
+               if ($this->fld_comment && isset($row->rev_comment)) {
+                       if ($row->rev_deleted & Revision::DELETED_COMMENT)
+                               $vals['commenthidden'] = '';
+                       else
+                               $vals['comment'] = $row->rev_comment;
+               }
+
+               if ($this->fld_patrolled && $row->rc_patrolled)
+                       $vals['patrolled'] = '';
+               
+               if ($this->fld_size && !is_null($row->rev_len))
+                       $vals['size'] = intval($row->rev_len);
 
+               if ($this->fld_tags && $row->ts_tags)
+                       $vals['tags'] = $row->ts_tags;
+                       
                return $vals;
        }
        
@@ -273,13 +348,16 @@ class ApiQueryContributions extends ApiQueryBase {
                        ),
                        'prop' => array (
                                ApiBase :: PARAM_ISMULTI => true,
-                               ApiBase :: PARAM_DFLT => 'ids|title|timestamp|flags|comment',
+                               ApiBase :: PARAM_DFLT => 'ids|title|timestamp|comment|size|flags',
                                ApiBase :: PARAM_TYPE => array (
                                        'ids',
                                        'title',
                                        'timestamp',
                                        'comment',
-                                       'flags'
+                                       'size',
+                                       'flags',
+                                       'patrolled',
+                                       'tags',
                                )
                        ),
                        'show' => array (
@@ -287,8 +365,11 @@ class ApiQueryContributions extends ApiQueryBase {
                                ApiBase :: PARAM_TYPE => array (
                                        'minor',
                                        '!minor',
+                                       'patrolled',
+                                       '!patrolled',
                                )
                        ),
+                       'tag' => null,
                );
        }
 
@@ -303,7 +384,9 @@ class ApiQueryContributions extends ApiQueryBase {
                        'dir' => 'The direction to search (older or newer).',
                        'namespace' => 'Only list contributions in these namespaces',
                        'prop' => 'Include additional pieces of information',
-                       'show' => 'Show only items that meet this criteria, e.g. non minor edits only: show=!minor',
+                       'show' => array('Show only items that meet this criteria, e.g. non minor edits only: show=!minor',
+                                       'NOTE: if show=patrolled or show=!patrolled is set, revisions older than $wgRCMaxAge won\'t be shown',),
+                       'tag' => 'Only list contributions with this tag',
                );
        }