foreach ( $res as $row ) {
$names[$row->user_name] = $row;
}
- call_user_func_array(
- $this->params['dir'] == 'newer' ? 'ksort' : 'krsort', [ &$names, SORT_STRING ]
- );
+ if ( $this->params['dir'] == 'newer' ) {
+ ksort( $names, SORT_STRING );
+ } else {
+ krsort( $names, SORT_STRING );
+ }
$neg = $op === '>' ? -1 : 1;
$userIter = call_user_func( function () use ( $names, $fromName, $neg ) {
foreach ( $names as $name => $row ) {
if ( $batchSize === 1 ) { // One user, can't be different
$ret = 0;
} elseif ( $this->orderBy === 'id' ) {
- $ret = $a[0]->rev_user - $b[0]->rev_user;
+ $ret = $a[0]->rev_user <=> $b[0]->rev_user;
} elseif ( $this->orderBy === 'name' ) {
$ret = strcmp( $a[0]->rev_user_text, $b[0]->rev_user_text );
} else {
- $ret = $a[0]->rev_actor - $b[0]->rev_actor;
+ $ret = $a[0]->rev_actor <=> $b[0]->rev_actor;
}
if ( !$ret ) {
}
if ( !$ret ) {
- $ret = $a[0]->rev_id - $b[0]->rev_id;
+ $ret = $a[0]->rev_id <=> $b[0]->rev_id;
}
return $neg * $ret;
&& !is_null( $row->rev_len )
&& !is_null( $row->rev_parent_id )
) {
- $parentLen = isset( $this->parentLens[$row->rev_parent_id] )
- ? $this->parentLens[$row->rev_parent_id]
- : 0;
+ $parentLen = $this->parentLens[$row->rev_parent_id] ?? 0;
$vals['sizediff'] = intval( $row->rev_len - $parentLen );
}