Move ApiFormatYaml_spyc.php to spyc.php as per r71763
[lhc/web/wiklou.git] / includes / api / ApiBase.php
index 19779d4..29881e7 100644 (file)
@@ -1,10 +1,9 @@
 <?php
-
 /**
- * Created on Sep 5, 2006
- *
  * API for MediaWiki 1.8+
  *
+ * Created on Sep 5, 2006
+ *
  * Copyright © 2006, 2010 Yuri Astrakhan <Firstname><Lastname>@gmail.com
  *
  * This program is free software; you can redistribute it and/or modify
@@ -21,6 +20,8 @@
  * with this program; if not, write to the Free Software Foundation, Inc.,
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  * http://www.gnu.org/copyleft/gpl.html
+ *
+ * @file
  */
 
 /**
@@ -50,6 +51,7 @@ abstract class ApiBase {
        const PARAM_MIN = 5; // Lowest value allowed for a parameter. Only applies if TYPE='integer'
        const PARAM_ALLOW_DUPLICATES = 6; // Boolean, do we allow the same value to be set more than once when ISMULTI=true
        const PARAM_DEPRECATED = 7; // Boolean, is the parameter deprecated (will show a warning)
+       const PARAM_REQUIRED = 8; // Boolean, is the parameter required?
 
        const LIMIT_BIG1 = 500; // Fast query, std user limit
        const LIMIT_BIG2 = 5000; // Fast query, bot/sysop limit
@@ -57,6 +59,7 @@ abstract class ApiBase {
        const LIMIT_SML2 = 500; // Slow query, bot/sysop limit
 
        private $mMainModule, $mModuleName, $mModulePrefix;
+       private $mParamCache = array();
 
        /**
         * Constructor
@@ -306,6 +309,12 @@ abstract class ApiBase {
                                        $desc = "DEPRECATED! $desc";
                                }
 
+                               $required = isset( $paramSettings[self::PARAM_REQUIRED] ) ?
+                                       $paramSettings[self::PARAM_REQUIRED] : false;
+                               if ( $required ) {
+                                       $desc .= $paramPrefix . "This parameter is required";
+                               }
+
                                $type = isset( $paramSettings[self::PARAM_TYPE] ) ? $paramSettings[self::PARAM_TYPE] : null;
                                if ( isset( $type ) ) {
                                        if ( isset( $paramSettings[self::PARAM_ISMULTI] ) ) {
@@ -329,7 +338,7 @@ abstract class ApiBase {
                                                switch ( $type ) {
                                                        case 'namespace':
                                                                // Special handling because namespaces are type-limited, yet they are not given
-                                                               $desc .= $paramPrefix . $prompt . implode( ', ', ApiBase::getValidNamespaces() );
+                                                               $desc .= $paramPrefix . $prompt . implode( ', ', MWNamespace::getValidNamespaces() );
                                                                break;
                                                        case 'limit':
                                                                $desc .= $paramPrefix . "No more than {$paramSettings[self :: PARAM_MAX]} ({$paramSettings[self::PARAM_MAX2]} for bots) allowed";
@@ -479,16 +488,20 @@ abstract class ApiBase {
         * @return array
         */
        public function extractRequestParams( $parseLimit = true ) {
-               $params = $this->getFinalParams();
-               $results = array();
-
-               if ( $params ) { // getFinalParams() can return false
-                       foreach ( $params as $paramName => $paramSettings ) {
-                               $results[$paramName] = $this->getParameterFromSettings( $paramName, $paramSettings, $parseLimit );
+               // Cache parameters, for performance and to avoid bug 24564.
+               if ( !isset( $this->mParamCache[$parseLimit] ) ) {
+                       $params = $this->getFinalParams();
+                       $results = array();
+
+                       if ( $params ) { // getFinalParams() can return false
+                               foreach ( $params as $paramName => $paramSettings ) {
+                                       $results[$paramName] = $this->getParameterFromSettings(
+                                               $paramName, $paramSettings, $parseLimit );
+                               }
                        }
+                       $this->mParamCache[$parseLimit] = $results;
                }
-
-               return $results;
+               return $this->mParamCache[$parseLimit];
        }
 
        /**
@@ -522,24 +535,10 @@ abstract class ApiBase {
        }
 
        /**
-        * Returns an array of the namespaces (by integer id) that exist on the
-        * wiki. Used primarily in help documentation.
-        * @return array
+        * @deprecated use MWNamespace::getValidNamespaces()
         */
        public static function getValidNamespaces() {
-               static $mValidNamespaces = null;
-
-               if ( is_null( $mValidNamespaces ) ) {
-                       global $wgCanonicalNamespaceNames;
-                       $mValidNamespaces = array( NS_MAIN ); // Doesn't appear in $wgCanonicalNamespaceNames for some reason
-                       foreach ( array_keys( $wgCanonicalNamespaceNames ) as $ns ) {
-                               if ( $ns > 0 ) {
-                                       $mValidNamespaces[] = $ns;
-                               }
-                       }
-               }
-
-               return $mValidNamespaces;
+               return MWNamespace::getValidNamespaces();
        }
 
        /**
@@ -551,6 +550,7 @@ abstract class ApiBase {
         * @returns mixed
         */
        protected function getWatchlistValue ( $watchlist, $titleObj, $userOption = null ) {
+               global $wgUser;
                switch ( $watchlist ) {
                        case 'watch':
                                return true;
@@ -559,7 +559,6 @@ abstract class ApiBase {
                                return false;
 
                        case 'preferences':
-                               global $wgUser;
                                # If the user is already watching, don't bother checking
                                if ( $titleObj->userIsWatching() ) {
                                        return null;
@@ -619,12 +618,14 @@ abstract class ApiBase {
                        $type = gettype( $paramSettings );
                        $dupes = false;
                        $deprecated = false;
+                       $required = false;
                } else {
                        $default = isset( $paramSettings[self::PARAM_DFLT] ) ? $paramSettings[self::PARAM_DFLT] : null;
                        $multi = isset( $paramSettings[self::PARAM_ISMULTI] ) ? $paramSettings[self::PARAM_ISMULTI] : false;
                        $type = isset( $paramSettings[self::PARAM_TYPE] ) ? $paramSettings[self::PARAM_TYPE] : null;
                        $dupes = isset( $paramSettings[self::PARAM_ALLOW_DUPLICATES] ) ? $paramSettings[self::PARAM_ALLOW_DUPLICATES] : false;
                        $deprecated = isset( $paramSettings[self::PARAM_DEPRECATED] ) ? $paramSettings[self::PARAM_DEPRECATED] : false;
+                       $required = isset( $paramSettings[self::PARAM_REQUIRED] ) ? $paramSettings[self::PARAM_REQUIRED] : false;
 
                        // When type is not given, and no choices, the type is the same as $default
                        if ( !isset( $type ) ) {
@@ -647,7 +648,7 @@ abstract class ApiBase {
                        $value = $this->getMain()->getRequest()->getVal( $encParamName, $default );
 
                        if ( isset( $value ) && $type == 'namespace' ) {
-                               $type = ApiBase::getValidNamespaces();
+                               $type = MWNamespace::getValidNamespaces();
                        }
                }
 
@@ -662,7 +663,11 @@ abstract class ApiBase {
                                switch ( $type ) {
                                        case 'NULL': // nothing to do
                                                break;
-                                       case 'string': // nothing to do
+                                       case 'string':
+                                               if ( $required && $value === '' ) {
+                                                       $this->dieUsageMsg( array( 'missingparam', $paramName ) );
+                                               }
+
                                                break;
                                        case 'integer': // Force everything using intval() and optionally validate limits
 
@@ -691,7 +696,7 @@ abstract class ApiBase {
                                                $min = isset( $paramSettings[self::PARAM_MIN] ) ? $paramSettings[self::PARAM_MIN] : 0;
                                                if ( $value == 'max' ) {
                                                        $value = $this->getMain()->canApiHighLimits() ? $paramSettings[self::PARAM_MAX2] : $paramSettings[self::PARAM_MAX];
-                                                       $this->getResult()->addValue( 'limits', $this->getModuleName(), $value );
+                                                       $this->getResult()->setParsedLimit( $this->getModuleName(), $value );
                                                } else {
                                                        $value = intval( $value );
                                                        $this->validateLimit( $paramName, $value, $min, $paramSettings[self::PARAM_MAX], $paramSettings[self::PARAM_MAX2] );
@@ -714,8 +719,8 @@ abstract class ApiBase {
                                                break;
                                        case 'user':
                                                if ( !is_array( $value ) ) {
-                            $value = array( $value );
-                        }
+                                                       $value = array( $value );
+                                               }
 
                                                foreach ( $value as $key => $val ) {
                                                        $title = Title::makeTitleSafe( NS_USER, $val );
@@ -726,9 +731,9 @@ abstract class ApiBase {
                                                }
 
                                                if ( !$multi ) {
-                            $value = $value[0];
-                        }
-                        break;
+                                                       $value = $value[0];
+                                               }
+                                               break;
                                        default:
                                                ApiBase::dieDebug( __METHOD__, "Param $encParamName's type is unknown - $type" );
                                }
@@ -743,6 +748,8 @@ abstract class ApiBase {
                        if ( $deprecated && $value !== false ) {
                                $this->setWarning( "The $encParamName parameter has been deprecated." );
                        }
+               } else if ( $required ) {
+                       $this->dieUsageMsg( array( 'missingparam', $paramName ) );
                }
 
                return $value;
@@ -1120,6 +1127,15 @@ abstract class ApiBase {
        public function getPossibleErrors() {
                $ret = array();
 
+               $params = $this->getFinalParams();
+               if ( $params ) {
+                       foreach ( $params as $paramName => $paramSettings ) {
+                               if ( isset( $paramSettings[ApiBase::PARAM_REQUIRED] ) ) {
+                                       $ret[] = array( 'missingparam', $paramName );
+                               }
+                       }
+               }
+
                if ( $this->mustBePosted() ) {
                        $ret[] = array( 'mustbeposted', $this->getModuleName() );
                }